From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC19C433ED for ; Mon, 26 Apr 2021 01:25:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0524961078 for ; Mon, 26 Apr 2021 01:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231629AbhDZB0X (ORCPT ); Sun, 25 Apr 2021 21:26:23 -0400 Received: from mail.netfilter.org ([217.70.188.207]:49816 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231597AbhDZB0X (ORCPT ); Sun, 25 Apr 2021 21:26:23 -0400 Received: from us.es (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 4D019605A8; Mon, 26 Apr 2021 03:25:06 +0200 (CEST) Date: Mon, 26 Apr 2021 03:25:39 +0200 From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [PATCH] netfilter: nf_log_syslog: Unset bridge logger in pernet exit Message-ID: <20210426012539.GA31075@salvia> References: <20210421103421.6168-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210421103421.6168-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Apr 21, 2021 at 12:34:21PM +0200, Phil Sutter wrote: > Without this, a stale pointer remains in pernet loggers after module > unload causing a kernel oops during dereference. Easily reproduced by: > > | # modprobe nf_log_syslog > | # rmmod nf_log_syslog > | # cat /proc/net/netfilter/nf_log Applied, thanks.