All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] dmaengine: qcom: fix platform_get_irq.cocci warnings
Date: Mon, 26 Apr 2021 13:40:09 +0800	[thread overview]
Message-ID: <20210426054009.GA97412@9c13384fa064> (raw)
In-Reply-To: <202104261342.mEVSTZIa-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Nathan Chancellor <natechancellor@gmail.com>
CC: Vinod Koul <vkoul@kernel.org>
CC: Andy Gross <agross@kernel.org>
CC: Bjorn Andersson <bjorn.andersson@linaro.org>
CC: Dan Williams <dan.j.williams@intel.com>
CC: linux-arm-msm(a)vger.kernel.org
CC: dmaengine(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/dma/qcom/gpi.c:2210:3-10: line 2210 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 0a6d3038d914 ("dmaengine: qcom: Always inline gpi_update_reg")
CC: Nathan Chancellor <natechancellor@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9f4ad9e425a1d3b6a34617b8ea226d56a119a717
commit: 0a6d3038d914b51d6860f23ea2b508590e8340de dmaengine: qcom: Always inline gpi_update_reg
:::::: branch date: 9 hours ago
:::::: commit date: 3 months ago

Please take the patch only if it's a positive warning. Thanks!

 gpi.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2207,7 +2207,6 @@ static int gpi_probe(struct platform_dev
 		/* set up irq */
 		ret = platform_get_irq(pdev, i);
 		if (ret < 0) {
-			dev_err(gpi_dev->dev, "platform_get_irq failed for %d:%d\n", i, ret);
 			return ret;
 		}
 		gpii->irq = ret;

      reply	other threads:[~2021-04-26  5:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  5:40 drivers/dma/qcom/gpi.c:2210:3-10: line 2210 is redundant because platform_get_irq() already prints an error kernel test robot
2021-04-26  5:40 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210426054009.GA97412@9c13384fa064 \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.