From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D2EC433B4 for ; Mon, 26 Apr 2021 13:01:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C1D061263 for ; Mon, 26 Apr 2021 13:01:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233619AbhDZNCT (ORCPT ); Mon, 26 Apr 2021 09:02:19 -0400 Received: from elvis.franken.de ([193.175.24.41]:43655 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233593AbhDZNCT (ORCPT ); Mon, 26 Apr 2021 09:02:19 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lb0rm-0001U1-00; Mon, 26 Apr 2021 15:01:34 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id DF10CC0BBF; Mon, 26 Apr 2021 15:00:05 +0200 (CEST) Date: Mon, 26 Apr 2021 15:00:05 +0200 From: Thomas Bogendoerfer To: zhouchuangao Cc: Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG. Message-ID: <20210426130005.GA9176@alpha.franken.de> References: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, Apr 24, 2021 at 08:59:50AM -0700, zhouchuangao wrote: > BUG_ON uses unlikely in if(), it can be optimized at compile time. > > Usually, the condition in if() is not satisfied. In my opinion, > this can improve the efficiency of the multi-stage pipeline. > > Signed-off-by: zhouchuangao > --- > arch/mips/bcm63xx/gpio.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECB48C433ED for ; Mon, 26 Apr 2021 13:03:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83A3E60FD7 for ; Mon, 26 Apr 2021 13:03:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83A3E60FD7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fepKB0ky+juMn68QePabdKYqNF7e9zJ0xF02rZ+rJWM=; b=gYmvAkxP71cuL6Q9hzpZnMAk4 iHVtIINtFgHF8sQ8kkOdk9tIfpQe02NYSB18Q91DkSc44Le9iGyzfg6jOxuo616NEUodBXjVk901P nI652NBQqdQDzQ1rtUdVZurYJKAahCryvySeDRGDY/SXmKtYBfFtB4Yjv8uOwWgcHDz0wGAf7aFvo JIRHUSKaZGrkGmX8lCaGQUSpS8kZCPgI4i8cqm9CanTeqXnrwTzAxvBOIeziwkulM6Rk8JoZdpFtg 4TbEfN1oim1sz10nhFps681aHS6DdMUUwyC8Qzu5va+mUGigVey7ybFU4GnZKCp/SRiAlAYvodqM/ K6BAiMDQg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lb0s2-007fMm-Mz; Mon, 26 Apr 2021 13:01:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb0rz-007fMO-Oe for linux-arm-kernel@desiato.infradead.org; Mon, 26 Apr 2021 13:01:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lQ4s3Q/Tyqv2Nxgr8pGNRBAS74lJ6B3xncZlqaTXtfo=; b=08GDHyja2EiypuV1wS+sBPUGAJ jwvDP5KlKdDyEJAzb+mQ7qGshBFS1REM1FlsuO3GL2+aL5RSgWcird6TCIY/hTmSjTCH4umLHWVuz 3XV1Kd4Zc4F+GHRh0OIiRGJn6qMX5QVwydYyh8+XxsW8e9kPd8+qo3xwgbeoEcqNI0osV/alAAxMS 4aqS4yCLypTAmBBeVf3IvxFDB3JU7LCDv+QQ50od0Gjd+ahHjksuDsLHFno+jQVw8Z0zaBHwp/swm mD8C7WMUs88hCht5cbCYAWUvt0VRLEUkCMKLcLtmTD+wnxR+or5mwqDyumdNZ1gRFqWZeBvpm5W0J K9U9WVvg==; Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lb0ru-00FyKb-Qh for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 13:01:44 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lb0rm-0001U1-00; Mon, 26 Apr 2021 15:01:34 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id DF10CC0BBF; Mon, 26 Apr 2021 15:00:05 +0200 (CEST) Date: Mon, 26 Apr 2021 15:00:05 +0200 From: Thomas Bogendoerfer To: zhouchuangao Cc: Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG. Message-ID: <20210426130005.GA9176@alpha.franken.de> References: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_060143_068316_DDBDE474 X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 24, 2021 at 08:59:50AM -0700, zhouchuangao wrote: > BUG_ON uses unlikely in if(), it can be optimized at compile time. > > Usually, the condition in if() is not satisfied. In my opinion, > this can improve the efficiency of the multi-stage pipeline. > > Signed-off-by: zhouchuangao > --- > arch/mips/bcm63xx/gpio.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel