[bvanassche:scsi-remove-done-callback 80/83] drivers/staging/unisys/visorhba/visorhba_main.c:347:3: error: implicit declaration of function 'scsiscsi_done'; did you mean 'scsi_done'?

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2558 bytes --]

tree:   https://github.com/bvanassche/linux scsi-remove-done-callback
head:   0fcbd84b06fef935eeac38e0677f03ddbc69cab0
commit: e393a3735f52aefd23460037b05db3a3e836f558 [80/83] staging: unisys: visorhba: Call scsi_done() directly
config: x86_64-randconfig-s021-20210426 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/bvanassche/linux/commit/e393a3735f52aefd23460037b05db3a3e836f558
        git remote add bvanassche https://github.com/bvanassche/linux
        git fetch --no-tags bvanassche scsi-remove-done-callback
        git checkout e393a3735f52aefd23460037b05db3a3e836f558
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_abort_handler':
>> drivers/staging/unisys/visorhba/visorhba_main.c:347:3: error: implicit declaration of function 'scsiscsi_done'; did you mean 'scsi_done'? [-Werror=implicit-function-declaration]
     347 |   scsiscsi_done(scsicmd);
         |   ^~~~~~~~~~~~~
         |   scsi_done
   cc1: some warnings being treated as errors


vim +347 drivers/staging/unisys/visorhba/visorhba_main.c

   324	
   325	/*
   326	 * visorhba_abort_handler - Send TASK_MGMT_ABORT_TASK
   327	 * @scsicmd: The scsicmd that needs aborted
   328	 *
   329	 * Return: SUCCESS if inserted, FAILED otherwise
   330	 */
   331	static int visorhba_abort_handler(struct scsi_cmnd *scsicmd)
   332	{
   333		/* issue TASK_MGMT_ABORT_TASK */
   334		struct scsi_device *scsidev;
   335		struct visordisk_info *vdisk;
   336		int rtn;
   337	
   338		scsidev = scsicmd->device;
   339		vdisk = scsidev->hostdata;
   340		if (atomic_read(&vdisk->error_count) < VISORHBA_ERROR_COUNT)
   341			atomic_inc(&vdisk->error_count);
   342		else
   343			atomic_set(&vdisk->ios_threshold, IOS_ERROR_THRESHOLD);
   344		rtn = forward_taskmgmt_command(TASK_MGMT_ABORT_TASK, scsidev);
   345		if (rtn == SUCCESS) {
   346			scsicmd->result = DID_ABORT << 16;
 > 347			scsiscsi_done(scsicmd);
   348		}
   349		return rtn;
   350	}
   351	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40794 bytes --]