From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: mwilck@suse.com, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Chao Leng <lengchao@huawei.com>,
Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: rdma/tcp: call nvme_mpath_stop() from reconnect workqueue
Date: Mon, 26 Apr 2021 16:51:05 +0200 [thread overview]
Message-ID: <20210426145105.GA22120@lst.de> (raw)
In-Reply-To: <37607acc-74a0-ea13-88a1-0197bf43fc2b@grimberg.me>
On Fri, Apr 23, 2021 at 05:21:03PM -0700, Sagi Grimberg wrote:
>
>> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
>> index be905d4fdb47..fc07a7b0dc1d 100644
>> --- a/drivers/nvme/host/rdma.c
>> +++ b/drivers/nvme/host/rdma.c
>> @@ -1202,6 +1202,7 @@ static void nvme_rdma_error_recovery_work(struct work_struct *work)
>> return;
>> }
>> + nvme_mpath_stop(&ctrl->ctrl);
>> nvme_rdma_reconnect_or_remove(ctrl);
>
> Its pretty annoying to have to needlessly wait for the ana log page
> request to timeout... But this is also needed because we init ana_lock
> in nvme_mpath_init while it can be potentially taken in ana_work, which
> is a precipice for bad things...
I also really hate open coding this mpath detail in the transport
drivers. Didn't you at some point have a series to factor out more
common code from the whole reset and reconnect path?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-26 14:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 13:38 [PATCH v2] nvme: rdma/tcp: call nvme_mpath_stop() from reconnect workqueue mwilck
[not found] ` <CAFL455k3aBLcZrZPq=Q-9aws4UesstA5gSOr_E7mEFrLT+KbKw@mail.gmail.com>
2021-04-23 16:43 ` Martin Wilck
2021-04-23 17:09 ` Martin Wilck
2021-04-24 0:21 ` Sagi Grimberg
2021-04-26 14:51 ` Christoph Hellwig [this message]
2021-04-26 16:27 ` Martin Wilck
2021-04-27 1:45 ` Chao Leng
2021-04-27 7:30 ` Martin Wilck
2021-04-27 8:56 ` Martin Wilck
2021-04-27 9:04 ` Martin Wilck
2021-04-25 1:07 ` Chao Leng
2021-04-25 11:34 ` Hannes Reinecke
2021-04-26 2:31 ` Chao Leng
2021-04-26 15:18 ` Martin Wilck
2021-04-26 9:34 ` Martin Wilck
2021-04-26 10:06 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210426145105.GA22120@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mwilck@suse.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.