From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CA2C433B4 for ; Mon, 26 Apr 2021 21:25:51 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58D7361182 for ; Mon, 26 Apr 2021 21:25:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58D7361182 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FTdH053Wjz2yyL for ; Tue, 27 Apr 2021 07:25:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.53; helo=mail-ot1-f53.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FTdGc3KPgz2yR4 for ; Tue, 27 Apr 2021 07:25:26 +1000 (AEST) Received: by mail-ot1-f53.google.com with SMTP id f75-20020a9d03d10000b0290280def9ab76so48384143otf.12 for ; Mon, 26 Apr 2021 14:25:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=if+kpOrEBMc7EsjeYPdnBYrLSadizKO99PTh1HWp/+w=; b=GZEcN8sl+n6/iHDATKEM5n31kS9UT2AhTEh7XRp03Qxr93bOXBAyVoIE7diHXN+PKP WSn9odmYwmxXEG/u88pcLRTmqAdfouU9EBEY+X0P+BcMcx8nzw3Gcr+KSTsXtvJ/wq1a V0IvfNCUm77nOXwhoLbiX1BnOIrr+pchleCiMSKsEw8SBisMnY9D38VmoRPF1HXTESaa Lyk9anGycGzgtgOFgQDGnzeqhr4Vy9r3vp/G+u0ei3hGS9Z18xGEgqL7N2Hg5upa3KI/ 5fKz3rlASa1DjhAdQDmYU+Qj8TLkfL2kgq/iS/eQe1argMdd/Ci8XM10XoaHWMTCljw+ Wfxw== X-Gm-Message-State: AOAM5304zz4wmT2yzWnAs3fPJL8WVCO4evsyhosLVxvuB3eEZLzhXgON t/PNu5JFMEsar3ci2VPYJg== X-Google-Smtp-Source: ABdhPJytQsNTWy1y3O3rVhWawKgoMbsNBLoMOI596n65aAt19DCMYv0gC0X7OPoXraB6/B6TdKT2Yw== X-Received: by 2002:a9d:4616:: with SMTP id y22mr6630504ote.250.1619472322465; Mon, 26 Apr 2021 14:25:22 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id p2sm227792ool.15.2021.04.26.14.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 14:25:21 -0700 (PDT) Received: (nullmailer pid 4112837 invoked by uid 1000); Mon, 26 Apr 2021 21:25:20 -0000 Date: Mon, 26 Apr 2021 16:25:20 -0500 From: Rob Herring To: Lakshmi Ramasubramanian Subject: Re: [PATCH v2 1/2] powerpc: Free fdt on error in elf64_load() Message-ID: <20210426212520.GA4112479@robh.at.kernel.org> References: <20210421163610.23775-1-nramas@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421163610.23775-1-nramas@linux.microsoft.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, kbuild-all@lists.01.org, lkp@intel.com, bauerman@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, dan.carpenter@oracle.com, dja@axtens.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 21 Apr 2021 09:36:09 -0700, Lakshmi Ramasubramanian wrote: > There are a few "goto out;" statements before the local variable "fdt" > is initialized through the call to of_kexec_alloc_and_setup_fdt() in > elf64_load(). This will result in an uninitialized "fdt" being passed > to kvfree() in this function if there is an error before the call to > of_kexec_alloc_and_setup_fdt(). > > If there is any error after fdt is allocated, but before it is > saved in the arch specific kimage struct, free the fdt. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Michael Ellerman > Signed-off-by: Lakshmi Ramasubramanian > --- > arch/powerpc/kexec/elf_64.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > Applied, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4013C433ED for ; Mon, 26 Apr 2021 21:25:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B593961040 for ; Mon, 26 Apr 2021 21:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234146AbhDZV0E (ORCPT ); Mon, 26 Apr 2021 17:26:04 -0400 Received: from mail-ot1-f46.google.com ([209.85.210.46]:36818 "EHLO mail-ot1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234207AbhDZV0E (ORCPT ); Mon, 26 Apr 2021 17:26:04 -0400 Received: by mail-ot1-f46.google.com with SMTP id i16-20020a9d68d00000b0290286edfdfe9eso42867146oto.3 for ; Mon, 26 Apr 2021 14:25:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=if+kpOrEBMc7EsjeYPdnBYrLSadizKO99PTh1HWp/+w=; b=NfXayFCY9TtzP0uEONGUb81MOzuL/0vWHQjEqTNPpxpm0nzhURii0moJ5hkRW5++hB a6Eza2I2X044owOwro5q/CgCSVkbywGQsxZXpEiUl9nSucqRWLsBISiNWcg4R7n7RsVc k1aNoC9osehtjqNbg9AaFUxjr/rt2qaatXbL4rlpw1TerMG3wbJy6jBRjdRLqGOredLf fl3h1WACnYQ+8AhtMLIwpoBw84YnNF3BMNR5FnmTa62edkyMHUfD+sEO5EGFgu6aVd4W I28qANa+dNrN120t8wEwSdf0dUSrhn2aBvCWfVVz+uUQzbXRkXJE+DXrNpusD1e6NMeF 1XbQ== X-Gm-Message-State: AOAM530WpVJwq2SinC0lAsuDb5+dfgb2KNZIkvifoRPt/b1yF16jCKU8 6WUCyQO4wkgVzCCmqVL3KA== X-Google-Smtp-Source: ABdhPJytQsNTWy1y3O3rVhWawKgoMbsNBLoMOI596n65aAt19DCMYv0gC0X7OPoXraB6/B6TdKT2Yw== X-Received: by 2002:a9d:4616:: with SMTP id y22mr6630504ote.250.1619472322465; Mon, 26 Apr 2021 14:25:22 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id p2sm227792ool.15.2021.04.26.14.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 14:25:21 -0700 (PDT) Received: (nullmailer pid 4112837 invoked by uid 1000); Mon, 26 Apr 2021 21:25:20 -0000 Date: Mon, 26 Apr 2021 16:25:20 -0500 From: Rob Herring To: Lakshmi Ramasubramanian Cc: devicetree@vger.kernel.org, bauerman@linux.ibm.com, christophe.leroy@csgroup.eu, dan.carpenter@oracle.com, mpe@ellerman.id.au, lkp@intel.com, dja@axtens.net, linuxppc-dev@lists.ozlabs.org, kbuild-all@lists.01.org Subject: Re: [PATCH v2 1/2] powerpc: Free fdt on error in elf64_load() Message-ID: <20210426212520.GA4112479@robh.at.kernel.org> References: <20210421163610.23775-1-nramas@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421163610.23775-1-nramas@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 21 Apr 2021 09:36:09 -0700, Lakshmi Ramasubramanian wrote: > There are a few "goto out;" statements before the local variable "fdt" > is initialized through the call to of_kexec_alloc_and_setup_fdt() in > elf64_load(). This will result in an uninitialized "fdt" being passed > to kvfree() in this function if there is an error before the call to > of_kexec_alloc_and_setup_fdt(). > > If there is any error after fdt is allocated, but before it is > saved in the arch specific kimage struct, free the fdt. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Michael Ellerman > Signed-off-by: Lakshmi Ramasubramanian > --- > arch/powerpc/kexec/elf_64.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > Applied, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3857727396234866316==" MIME-Version: 1.0 From: Rob Herring To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 1/2] powerpc: Free fdt on error in elf64_load() Date: Mon, 26 Apr 2021 16:25:20 -0500 Message-ID: <20210426212520.GA4112479@robh.at.kernel.org> In-Reply-To: <20210421163610.23775-1-nramas@linux.microsoft.com> List-Id: --===============3857727396234866316== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, 21 Apr 2021 09:36:09 -0700, Lakshmi Ramasubramanian wrote: > There are a few "goto out;" statements before the local variable "fdt" > is initialized through the call to of_kexec_alloc_and_setup_fdt() in > elf64_load(). This will result in an uninitialized "fdt" being passed > to kvfree() in this function if there is an error before the call to > of_kexec_alloc_and_setup_fdt(). > = > If there is any error after fdt is allocated, but before it is > saved in the arch specific kimage struct, free the fdt. > = > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Michael Ellerman > Signed-off-by: Lakshmi Ramasubramanian > --- > arch/powerpc/kexec/elf_64.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > = Applied, thanks! --===============3857727396234866316==--