From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v11 3/9] Use atomic_t for ucounts reference counting
Date: Wed, 28 Apr 2021 06:36:00 +0800 [thread overview]
Message-ID: <202104280652.DbZtg95c-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2869 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <94d1dbecab060a6b116b0a2d1accd8ca1bbb4f5f.1619094428.git.legion@kernel.org>
References: <94d1dbecab060a6b116b0a2d1accd8ca1bbb4f5f.1619094428.git.legion@kernel.org>
TO: legion(a)kernel.org
TO: LKML <linux-kernel@vger.kernel.org>
TO: Kernel Hardening <kernel-hardening@lists.openwall.com>
TO: Linux Containers <containers@lists.linux-foundation.org>
TO: linux-mm(a)kvack.org
CC: Alexey Gladkov <legion@kernel.org>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Christian Brauner <christian.brauner@ubuntu.com>
CC: "Eric W . Biederman" <ebiederm@xmission.com>
CC: Jann Horn <jannh@google.com>
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kselftest/next]
[also build test WARNING on linux/master linus/master v5.12 next-20210427]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/legion-kernel-org/Count-rlimits-in-each-user-namespace/20210427-162857
base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> kernel/ucount.c:188:5-24: atomic_dec_and_test variation before object free at line 190.
vim +188 kernel/ucount.c
0c1ee4f3f49c0f Alexey Gladkov 2021-04-22 183
0c1ee4f3f49c0f Alexey Gladkov 2021-04-22 184 void put_ucounts(struct ucounts *ucounts)
f6b2db1a3e8d14 Eric W. Biederman 2016-08-08 185 {
880a38547ff087 Nikolay Borisov 2017-01-20 186 unsigned long flags;
880a38547ff087 Nikolay Borisov 2017-01-20 187
33b16ca5b8cf91 Alexey Gladkov 2021-04-22 @188 if (atomic_dec_and_test(&ucounts->count)) {
880a38547ff087 Nikolay Borisov 2017-01-20 189 spin_lock_irqsave(&ucounts_lock, flags);
f6b2db1a3e8d14 Eric W. Biederman 2016-08-08 @190 hlist_del_init(&ucounts->node);
880a38547ff087 Nikolay Borisov 2017-01-20 191 spin_unlock_irqrestore(&ucounts_lock, flags);
f6b2db1a3e8d14 Eric W. Biederman 2016-08-08 192 kfree(ucounts);
f6b2db1a3e8d14 Eric W. Biederman 2016-08-08 193 }
33b16ca5b8cf91 Alexey Gladkov 2021-04-22 194 }
f6b2db1a3e8d14 Eric W. Biederman 2016-08-08 195
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65454 bytes --]
next reply other threads:[~2021-04-27 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 22:36 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-22 12:27 [PATCH v11 0/9] Count rlimits in each user namespace legion
2021-04-22 12:27 ` [PATCH v11 3/9] Use atomic_t for ucounts reference counting legion
2021-04-22 12:27 ` legion
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104280652.DbZtg95c-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.