From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32BC0C433B4 for ; Wed, 28 Apr 2021 06:45:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 783CC61423 for ; Wed, 28 Apr 2021 06:45:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 783CC61423 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zvjIgA1qG/rPXd8IQ6tRNBAJzCQOk5dS8yfroiOXq8c=; b=RQyp5KUFP8rOpqhbzQv+tWhw/ OY8hXGeyZTCAJ5IJZ3a9o5ZwqjX7ozWzF3L/JcXwh0EwraUmuwGrztU7U7bXZeik5VbV9hHNJ3yrt KguTA+h216cAjeTUnSeZ00cBUF6eng9FrmbKfXNqqKH8k67LwF7BeDwLmogBs6LnthzPjjJ/2rkTm kInsVmh4WRP/gRcG3dQZV2G8FB7VRBPWR1QO8WkqlfJxgkF6wy5p8T/ZKCipFkvm7IQyww0wI9OMD nKiHJZTMLp0SBLyRkhrnGyaStU/8JYLzb9EnXhWIrthjUnWoz+Zv7JJTJPpowSg0VCrli0/Hjk7qL /oiYbktWA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbdwa-002xNd-1N; Wed, 28 Apr 2021 06:45:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbdw8-002xGt-Vl for linux-rockchip@desiato.infradead.org; Wed, 28 Apr 2021 06:44:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=lbgwYstGUOJ9xiDt4AnAkyIrn/0PHdTae37erSJBmH0=; b=V04QHxMzeNQ9AcLImP3BibiR7B 5YY7BQ5i+xGIL/TwBLvZO3uFbm04NLcbznXg/fXUQIJWaHnWO4rOVyxuAWeIAWhMXdhiCwbQAg8qM zS1OU9QOYmK5R8fq7HfE0x5ONSSK5D7MTITuQMRKbb7fyVYbwMqewwkC31WxrG3WYKYQIvgejP9Qe 97ivc+I8ei+kARRq58NDcy3prLPSx7rugLdfLFNCntQQKBbw7OZy/Jn9r/Bh4JzxNbdxAwOHj4Z6+ pz9UZskEM6T5qpPbiQowC9+cAPEce3rfRWI2KD0uTyTJMzAw11/oQKu+ylDdEmgJZ/2Lx7mUrA18l l+mozc/w==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbdw6-00HDpY-0h for linux-rockchip@lists.infradead.org; Wed, 28 Apr 2021 06:44:39 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id AF33661422; Wed, 28 Apr 2021 06:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619592277; bh=S5Mcku9BqGbqEVzg3DUAzz6HUqoWQEP/3bQrKYHAHMc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r9ycOZc92ZLGH/GJuCv8MF7WWLmvTEaREagiqxoz+xK7lS7SbaUOHTzN1PMuj8UjJ QWyI3+JkOZA8z6EGW4Xme+vGCTDqcmo8OO3306UV3aURYRQfW8z9n1Tzk2keHc64cr IW0HJL4lG2zKVRksW0AYgU+vUWvmgLgnqR1U34mPnXxf5bZOWnbqKvibhO4rFeW37+ i7RHXl9HsZxwdH3hCS2lrTprfoZ5B2YkeM3E/1oDy+JQsJ7ahj5CXImovf4/Ev87eF 5dZUBedqinMq/KJ+5wDpfTmXenF6H8psD75QQq4WY4FpCXiL11BTb+jkI422CRl7hh HUMdUbdPFl1wg== Date: Wed, 28 Apr 2021 08:44:31 +0200 From: Mauro Carvalho Chehab To: Ezequiel Garcia Cc: Robin Murphy , linuxarm@huawei.com, mauro.chehab@huawei.com, Greg Kroah-Hartman , Mauro Carvalho Chehab , Philipp Zabel , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync() Message-ID: <20210428084431.0c2d505b@coco.lan> In-Reply-To: <20210428082742.20d54db1@coco.lan> References: <230f22170db7fa57b49cff4570cef15bf11b2ad5.1619519080.git.mchehab+huawei@kernel.org> <02948673-9572-a570-d28e-03a7208f39e1@arm.com> <95ea572e201545b27ff9f48313f7aaea157d4764.camel@collabora.com> <20210428082742.20d54db1@coco.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210427_234438_132705_8C591041 X-CRM114-Status: GOOD ( 33.39 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org RW0gV2VkLCAyOCBBcHIgMjAyMSAwODoyNzo0MiArMDIwMApNYXVybyBDYXJ2YWxobyBDaGVoYWIg PG1jaGVoYWIraHVhd2VpQGtlcm5lbC5vcmc+IGVzY3JldmV1OgoKPiBFbSBUdWUsIDI3IEFwciAy MDIxIDEyOjE4OjMyIC0wMzAwCj4gRXplcXVpZWwgR2FyY2lhIDxlemVxdWllbEBjb2xsYWJvcmEu Y29tPiBlc2NyZXZldToKPiAKPiA+IE9uIFR1ZSwgMjAyMS0wNC0yNyBhdCAxNjowOCArMDEwMCwg Um9iaW4gTXVycGh5IHdyb3RlOiAgCj4gPiA+IE9uIDIwMjEtMDQtMjcgMTE6MjcsIE1hdXJvIENh cnZhbGhvIENoZWhhYiB3cm90ZTogICAgCj4gPiA+ID4gRGVzcGl0ZSBvdGhlciAqX2dldCgpLypf cHV0KCkgZnVuY3Rpb25zLCB3aGVyZSB1c2FnZSBjb3VudCBpcwo+ID4gPiA+IGluY3JlbWVudGVk IG9ubHkgaWYgbm90IGVycm9ycywgdGhlIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBoYXMKPiA+ID4g PiBhIGRpZmZlcmVudCBiZWhhdmlvciwgaW5jcmVtZW50aW5nIHRoZSBjb3VudGVyICpldmVuKiBv bgo+ID4gPiA+IGVycm9ycy4KPiA+ID4gPiAKPiA+ID4gPiBUaGF0J3MgYW4gZXJyb3IgcHJvbmUg YmVoYXZpb3IsIGFzIHBlb3BsZSBvZnRlbiBmb3JnZXQgdG8KPiA+ID4gPiBkZWNyZW1lbnQgdGhl IHVzYWdlIGNvdW50ZXIuCj4gPiA+ID4gCj4gPiA+ID4gSG93ZXZlciwgdGhlIGhhbnRybyBkcml2 ZXIgZGVwZW5kcyBvbiB0aGlzIGJlaGF2aW9yLCBhcyBpdAo+ID4gPiA+IHdpbGwgZGVjcmVtZW50 IHRoZSB1c2FnZV9jb3VudCB1bmNvbmRpdGlvbmFsbHkgYXQgdGhlIG0ybQo+ID4gPiA+IGpvYiBm aW5pc2ggdGltZSwgd2hpY2ggbWFrZXMgc2Vuc2UuCj4gPiA+ID4gCj4gPiA+ID4gU28sIGludGVh ZCBvZiB1c2luZyB0aGUgcG1fcnVudGltZV9yZXN1bWVfYW5kX2dldCgpIHRoYXQKPiA+ID4gPiB3 b3VsZCBkZWNyZW1lbnQgdGhlIGNvdW50ZXIgb24gZXJyb3IsIGtlZXAgdGhlIGN1cnJlbnQKPiA+ ID4gPiBBUEksIGJ1dCBhZGQgYSBkb2N1bWVudGF0aW9uIGV4cGxhaW5pbmcgdGhlIHJhdGlvbmFs ZSBmb3IKPiA+ID4gPiBrZWVwIHVzaW5nIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKS4KPiA+ID4gPiAK PiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1jaGVoYWIraHVh d2VpQGtlcm5lbC5vcmc+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gwqAgZHJpdmVycy9zdGFnaW5nL21l ZGlhL2hhbnRyby9oYW50cm9fZHJ2LmMgfCA3ICsrKysrKysKPiA+ID4gPiDCoCAxIGZpbGUgY2hh bmdlZCwgNyBpbnNlcnRpb25zKCspCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvc3RhZ2luZy9tZWRpYS9oYW50cm8vaGFudHJvX2Rydi5jIGIvZHJpdmVycy9zdGFnaW5nL21l ZGlhL2hhbnRyby9oYW50cm9fZHJ2LmMKPiA+ID4gPiBpbmRleCA1OTVlODJhODI3MjguLjk2Zjk0 MGMxYzg1YyAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvaGFudHJv L2hhbnRyb19kcnYuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50cm8v aGFudHJvX2Rydi5jCj4gPiA+ID4gQEAgLTE1NSw2ICsxNTUsMTMgQEAgc3RhdGljIHZvaWQgZGV2 aWNlX3J1bih2b2lkICpwcml2KQo+ID4gPiA+IMKgwqDCoMKgwqDCoMKgwqByZXQgPSBjbGtfYnVs a19lbmFibGUoY3R4LT5kZXYtPnZhcmlhbnQtPm51bV9jbG9ja3MsIGN0eC0+ZGV2LT5jbG9ja3Mp Owo+ID4gPiA+IMKgwqDCoMKgwqDCoMKgwqBpZiAocmV0KQo+ID4gPiA+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgZ290byBlcnJfY2FuY2VsX2pvYjsgICAgCj4gPiA+IAo+ID4gPiAu LmV4Y2VwdCB0aGlzIGNhbiBhbHNvIGNhdXNlIHRoZSBzYW1lIHBtX3J1bnRpbWVfcHV0X2F1dG9z dXNwZW5kKCkgY2FsbCAKPiA+ID4gd2l0aG91dCBldmVuIHJlYWNoaW5nIHRoZSAibWF0Y2hpbmci IGdldCBiZWxvdywgc28gcmF0aGVyIHRoYW4gc29tZSBraW5kIAo+ID4gPiBvZiBjbGV2ZXJuZXNz IGl0IHNlZW1zIG1vcmUgbGlrZSBpdCdzIGp1c3QgYnJva2VuIDovCj4gPiA+ICAgICAKPiA+IAo+ ID4gSW5kZWVkLCBJIHdhcyB0cnlpbmcgdG8gZmluZCB0aW1lIHRvIGNvb2sgYSBxdWljayBwYXRj aCwgYnV0IGtlcHQKPiA+IGdldHRpbmcgcHJlZW1wdGVkLgo+ID4gCj4gPiBGZWVsIGZyZWUgdG8g c3VibWl0IGEgZml4IGZvciB0aGlzLCBvdGhlcndpc2UsIEknbGwgdHJ5IHRvIGZpbmQKPiA+IHRp bWUgbGF0ZXIgdGhpcyB3ZWVrLiAgCj4gCj4gV2hhdCBhYm91dCBkb2luZyB0aGlzIGluc3RlYWQ6 Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50cm8vaGFudHJvX2Ry di5jIGIvZHJpdmVycy9zdGFnaW5nL21lZGlhL2hhbnRyby9oYW50cm9fZHJ2LmMKPiBpbmRleCA1 OTVlODJhODI3MjguLjY3ZGU2YjE1MjM2ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcv bWVkaWEvaGFudHJvL2hhbnRyb19kcnYuYwo+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9o YW50cm8vaGFudHJvX2Rydi5jCj4gQEAgLTU2LDE0ICs1NiwxMiBAQCBkbWFfYWRkcl90IGhhbnRy b19nZXRfcmVmKHN0cnVjdCBoYW50cm9fY3R4ICpjdHgsIHU2NCB0cykKPiAgCXJldHVybiBoYW50 cm9fZ2V0X2RlY19idWZfYWRkcihjdHgsIGJ1Zik7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGhh bnRyb19qb2JfZmluaXNoKHN0cnVjdCBoYW50cm9fZGV2ICp2cHUsCj4gLQkJCSAgICAgIHN0cnVj dCBoYW50cm9fY3R4ICpjdHgsCj4gLQkJCSAgICAgIGVudW0gdmIyX2J1ZmZlcl9zdGF0ZSByZXN1 bHQpCj4gK3N0YXRpYyB2b2lkIGhhbnRyb19qb2JfZmluaXNoX25vX3BtKHN0cnVjdCBoYW50cm9f ZGV2ICp2cHUsCj4gKwkJCQkgICAgc3RydWN0IGhhbnRyb19jdHggKmN0eCwKPiArCQkJCSAgICBl bnVtIHZiMl9idWZmZXJfc3RhdGUgcmVzdWx0KQo+ICB7Cj4gIAlzdHJ1Y3QgdmIyX3Y0bDJfYnVm ZmVyICpzcmMsICpkc3Q7Cj4gIAo+IC0JcG1fcnVudGltZV9tYXJrX2xhc3RfYnVzeSh2cHUtPmRl dik7Cj4gLQlwbV9ydW50aW1lX3B1dF9hdXRvc3VzcGVuZCh2cHUtPmRldik7Cj4gIAljbGtfYnVs a19kaXNhYmxlKHZwdS0+dmFyaWFudC0+bnVtX2Nsb2NrcywgdnB1LT5jbG9ja3MpOwo+ICAKPiAg CXNyYyA9IHY0bDJfbTJtX25leHRfc3JjX2J1ZihjdHgtPmZoLm0ybV9jdHgpOwo+IEBAIC04MSw2 ICs3OSwxNiBAQCBzdGF0aWMgdm9pZCBoYW50cm9fam9iX2ZpbmlzaChzdHJ1Y3QgaGFudHJvX2Rl diAqdnB1LAo+ICAJCQkJCSByZXN1bHQpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBoYW50cm9f am9iX2ZpbmlzaChzdHJ1Y3QgaGFudHJvX2RldiAqdnB1LAo+ICsJCQkgICAgICBzdHJ1Y3QgaGFu dHJvX2N0eCAqY3R4LAo+ICsJCQkgICAgICBlbnVtIHZiMl9idWZmZXJfc3RhdGUgcmVzdWx0KQo+ ICt7Cj4gKwlwbV9ydW50aW1lX21hcmtfbGFzdF9idXN5KHZwdS0+ZGV2KTsKPiArCXBtX3J1bnRp bWVfcHV0X2F1dG9zdXNwZW5kKHZwdS0+ZGV2KTsKPiArCj4gKwloYW50cm9fam9iX2ZpbmlzaF9u b19wbSh2cHUsIGN0eCwgcmVzdWx0KTsKPiArfQo+ICsKPiAgdm9pZCBoYW50cm9faXJxX2RvbmUo c3RydWN0IGhhbnRyb19kZXYgKnZwdSwKPiAgCQkgICAgIGVudW0gdmIyX2J1ZmZlcl9zdGF0ZSBy ZXN1bHQpCj4gIHsKPiBAQCAtMTUyLDEyICsxNjAsMTMgQEAgc3RhdGljIHZvaWQgZGV2aWNlX3J1 bih2b2lkICpwcml2KQo+ICAJc3JjID0gaGFudHJvX2dldF9zcmNfYnVmKGN0eCk7Cj4gIAlkc3Qg PSBoYW50cm9fZ2V0X2RzdF9idWYoY3R4KTsKPiAgCj4gKwlyZXQgPSBwbV9ydW50aW1lX3Jlc3Vt ZV9hbmRfZ2V0KGN0eC0+ZGV2LT5kZXYpOwo+ICsJaWYgKHJldCA8IDApCj4gKwkJZ290byBlcnJf Y2FuY2VsX2pvYjsKPiArCj4gIAlyZXQgPSBjbGtfYnVsa19lbmFibGUoY3R4LT5kZXYtPnZhcmlh bnQtPm51bV9jbG9ja3MsIGN0eC0+ZGV2LT5jbG9ja3MpOwo+ICAJaWYgKHJldCkKPiAgCQlnb3Rv IGVycl9jYW5jZWxfam9iOwo+IC0JcmV0ID0gcG1fcnVudGltZV9nZXRfc3luYyhjdHgtPmRldi0+ ZGV2KTsKPiAtCWlmIChyZXQgPCAwKQo+IC0JCWdvdG8gZXJyX2NhbmNlbF9qb2I7Cj4gIAo+ICAJ djRsMl9tMm1fYnVmX2NvcHlfbWV0YWRhdGEoc3JjLCBkc3QsIHRydWUpOwo+ICAKPiBAQCAtMTY1 LDcgKzE3NCw3IEBAIHN0YXRpYyB2b2lkIGRldmljZV9ydW4odm9pZCAqcHJpdikKPiAgCXJldHVy bjsKPiAgCj4gIGVycl9jYW5jZWxfam9iOgo+IC0JaGFudHJvX2pvYl9maW5pc2goY3R4LT5kZXYs IGN0eCwgVkIyX0JVRl9TVEFURV9FUlJPUik7Cj4gKwloYW50cm9fam9iX2ZpbmlzaF9ub19wbShj dHgtPmRldiwgY3R4LCBWQjJfQlVGX1NUQVRFX0VSUk9SKTsKPiAgfQo+ICAKPiAgc3RhdGljIHN0 cnVjdCB2NGwyX20ybV9vcHMgdnB1X20ybV9vcHMgPSB7Cj4gCj4gVGhhbmtzLAo+IE1hdXJvCgpB Y3R1YWxseSwgdGhlIG9yZGVyIGF0IHRoZSBmaW5pc2ggbG9naWMgc2hvdWxkIGNoYW5nZSBhcyB3 ZWxsLgpNYXliZSBsaWtlIHRoaXM6Cgo8c25pcD4Kc3RhdGljIHZvaWQgaGFudHJvX2pvYl9maW5p c2hfbm9fcG0oc3RydWN0IGhhbnRyb19kZXYgKnZwdSwKCQkJCSAgICBzdHJ1Y3QgaGFudHJvX2N0 eCAqY3R4LAoJCQkJICAgIGVudW0gdmIyX2J1ZmZlcl9zdGF0ZSByZXN1bHQpCnsKCXN0cnVjdCB2 YjJfdjRsMl9idWZmZXIgKnNyYywgKmRzdDsKCglzcmMgPSB2NGwyX20ybV9uZXh0X3NyY19idWYo Y3R4LT5maC5tMm1fY3R4KTsKCWRzdCA9IHY0bDJfbTJtX25leHRfZHN0X2J1ZihjdHgtPmZoLm0y bV9jdHgpOwoKCWlmIChXQVJOX09OKCFzcmMpKQoJCXJldHVybjsKCWlmIChXQVJOX09OKCFkc3Qp KQoJCXJldHVybjsKCglzcmMtPnNlcXVlbmNlID0gY3R4LT5zZXF1ZW5jZV9vdXQrKzsKCWRzdC0+ c2VxdWVuY2UgPSBjdHgtPnNlcXVlbmNlX2NhcCsrOwoKCXY0bDJfbTJtX2J1Zl9kb25lX2FuZF9q b2JfZmluaXNoKGN0eC0+ZGV2LT5tMm1fZGV2LCBjdHgtPmZoLm0ybV9jdHgsCgkJCQkJIHJlc3Vs dCk7Cn0KCnN0YXRpYyB2b2lkIGhhbnRyb19qb2JfZmluaXNoKHN0cnVjdCBoYW50cm9fZGV2ICp2 cHUsCgkJCSAgICAgIHN0cnVjdCBoYW50cm9fY3R4ICpjdHgsCgkJCSAgICAgIGVudW0gdmIyX2J1 ZmZlcl9zdGF0ZSByZXN1bHQpCnsKCgloYW50cm9fam9iX2ZpbmlzaF9ub19wbSh2cHUsIGN0eCwg cmVzdWx0KTsKCgljbGtfYnVsa19kaXNhYmxlKHZwdS0+dmFyaWFudC0+bnVtX2Nsb2NrcywgdnB1 LT5jbG9ja3MpOwoKCXBtX3J1bnRpbWVfbWFya19sYXN0X2J1c3kodnB1LT5kZXYpOwoJcG1fcnVu dGltZV9wdXRfYXV0b3N1c3BlbmQodnB1LT5kZXYpOwp9CgpzdGF0aWMgdm9pZCBkZXZpY2VfcnVu KHZvaWQgKnByaXYpCnsKCXN0cnVjdCBoYW50cm9fY3R4ICpjdHggPSBwcml2OwoJc3RydWN0IHZi Ml92NGwyX2J1ZmZlciAqc3JjLCAqZHN0OwoJaW50IHJldDsKCglzcmMgPSBoYW50cm9fZ2V0X3Ny Y19idWYoY3R4KTsKCWRzdCA9IGhhbnRyb19nZXRfZHN0X2J1ZihjdHgpOwoKCXJldCA9IHBtX3J1 bnRpbWVfcmVzdW1lX2FuZF9nZXQoY3R4LT5kZXYtPmRldik7CglpZiAocmV0IDwgMCkKCQlnb3Rv IGVycl9jYW5jZWxfam9iOwoKCXJldCA9IGNsa19idWxrX2VuYWJsZShjdHgtPmRldi0+dmFyaWFu dC0+bnVtX2Nsb2NrcywgY3R4LT5kZXYtPmNsb2Nrcyk7CglpZiAocmV0KQoJCWdvdG8gZXJyX2Nh bmNlbF9qb2I7CgoJdjRsMl9tMm1fYnVmX2NvcHlfbWV0YWRhdGEoc3JjLCBkc3QsIHRydWUpOwoK CWN0eC0+Y29kZWNfb3BzLT5ydW4oY3R4KTsKCXJldHVybjsKCmVycl9jYW5jZWxfam9iOgoJaGFu dHJvX2pvYl9maW5pc2hfbm9fcG0oY3R4LT5kZXYsIGN0eCwgVkIyX0JVRl9TVEFURV9FUlJPUik7 Cn0KPC9zbmlwPgoKClRoYW5rcywKTWF1cm8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2Nr Y2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A3DC433ED for ; Wed, 28 Apr 2021 06:44:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D52161413 for ; Wed, 28 Apr 2021 06:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236236AbhD1GpW (ORCPT ); Wed, 28 Apr 2021 02:45:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:46352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236145AbhD1GpV (ORCPT ); Wed, 28 Apr 2021 02:45:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AF33661422; Wed, 28 Apr 2021 06:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619592277; bh=S5Mcku9BqGbqEVzg3DUAzz6HUqoWQEP/3bQrKYHAHMc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r9ycOZc92ZLGH/GJuCv8MF7WWLmvTEaREagiqxoz+xK7lS7SbaUOHTzN1PMuj8UjJ QWyI3+JkOZA8z6EGW4Xme+vGCTDqcmo8OO3306UV3aURYRQfW8z9n1Tzk2keHc64cr IW0HJL4lG2zKVRksW0AYgU+vUWvmgLgnqR1U34mPnXxf5bZOWnbqKvibhO4rFeW37+ i7RHXl9HsZxwdH3hCS2lrTprfoZ5B2YkeM3E/1oDy+JQsJ7ahj5CXImovf4/Ev87eF 5dZUBedqinMq/KJ+5wDpfTmXenF6H8psD75QQq4WY4FpCXiL11BTb+jkI422CRl7hh HUMdUbdPFl1wg== Date: Wed, 28 Apr 2021 08:44:31 +0200 From: Mauro Carvalho Chehab To: Ezequiel Garcia Cc: Robin Murphy , linuxarm@huawei.com, mauro.chehab@huawei.com, Greg Kroah-Hartman , Mauro Carvalho Chehab , Philipp Zabel , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync() Message-ID: <20210428084431.0c2d505b@coco.lan> In-Reply-To: <20210428082742.20d54db1@coco.lan> References: <230f22170db7fa57b49cff4570cef15bf11b2ad5.1619519080.git.mchehab+huawei@kernel.org> <02948673-9572-a570-d28e-03a7208f39e1@arm.com> <95ea572e201545b27ff9f48313f7aaea157d4764.camel@collabora.com> <20210428082742.20d54db1@coco.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Wed, 28 Apr 2021 08:27:42 +0200 Mauro Carvalho Chehab escreveu: > Em Tue, 27 Apr 2021 12:18:32 -0300 > Ezequiel Garcia escreveu: >=20 > > On Tue, 2021-04-27 at 16:08 +0100, Robin Murphy wrote: =20 > > > On 2021-04-27 11:27, Mauro Carvalho Chehab wrote: =20 > > > > Despite other *_get()/*_put() functions, where usage count is > > > > incremented only if not errors, the pm_runtime_get_sync() has > > > > a different behavior, incrementing the counter *even* on > > > > errors. > > > >=20 > > > > That's an error prone behavior, as people often forget to > > > > decrement the usage counter. > > > >=20 > > > > However, the hantro driver depends on this behavior, as it > > > > will decrement the usage_count unconditionally at the m2m > > > > job finish time, which makes sense. > > > >=20 > > > > So, intead of using the pm_runtime_resume_and_get() that > > > > would decrement the counter on error, keep the current > > > > API, but add a documentation explaining the rationale for > > > > keep using pm_runtime_get_sync(). > > > >=20 > > > > Signed-off-by: Mauro Carvalho Chehab > > > > --- > > > > =C2=A0 drivers/staging/media/hantro/hantro_drv.c | 7 +++++++ > > > > =C2=A0 1 file changed, 7 insertions(+) > > > >=20 > > > > diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/st= aging/media/hantro/hantro_drv.c > > > > index 595e82a82728..96f940c1c85c 100644 > > > > --- a/drivers/staging/media/hantro/hantro_drv.c > > > > +++ b/drivers/staging/media/hantro/hantro_drv.c > > > > @@ -155,6 +155,13 @@ static void device_run(void *priv) > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ret =3D clk_bulk_en= able(ctx->dev->variant->num_clocks, ctx->dev->clocks); > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (ret) > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0goto err_cancel_job; =20 > > >=20 > > > ..except this can also cause the same pm_runtime_put_autosuspend() ca= ll=20 > > > without even reaching the "matching" get below, so rather than some k= ind=20 > > > of cleverness it seems more like it's just broken :/ > > > =20 > >=20 > > Indeed, I was trying to find time to cook a quick patch, but kept > > getting preempted. > >=20 > > Feel free to submit a fix for this, otherwise, I'll try to find > > time later this week. =20 >=20 > What about doing this instead: >=20 > diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/= media/hantro/hantro_drv.c > index 595e82a82728..67de6b15236d 100644 > --- a/drivers/staging/media/hantro/hantro_drv.c > +++ b/drivers/staging/media/hantro/hantro_drv.c > @@ -56,14 +56,12 @@ dma_addr_t hantro_get_ref(struct hantro_ctx *ctx, u64= ts) > return hantro_get_dec_buf_addr(ctx, buf); > } > =20 > -static void hantro_job_finish(struct hantro_dev *vpu, > - struct hantro_ctx *ctx, > - enum vb2_buffer_state result) > +static void hantro_job_finish_no_pm(struct hantro_dev *vpu, > + struct hantro_ctx *ctx, > + enum vb2_buffer_state result) > { > struct vb2_v4l2_buffer *src, *dst; > =20 > - pm_runtime_mark_last_busy(vpu->dev); > - pm_runtime_put_autosuspend(vpu->dev); > clk_bulk_disable(vpu->variant->num_clocks, vpu->clocks); > =20 > src =3D v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx); > @@ -81,6 +79,16 @@ static void hantro_job_finish(struct hantro_dev *vpu, > result); > } > =20 > +static void hantro_job_finish(struct hantro_dev *vpu, > + struct hantro_ctx *ctx, > + enum vb2_buffer_state result) > +{ > + pm_runtime_mark_last_busy(vpu->dev); > + pm_runtime_put_autosuspend(vpu->dev); > + > + hantro_job_finish_no_pm(vpu, ctx, result); > +} > + > void hantro_irq_done(struct hantro_dev *vpu, > enum vb2_buffer_state result) > { > @@ -152,12 +160,13 @@ static void device_run(void *priv) > src =3D hantro_get_src_buf(ctx); > dst =3D hantro_get_dst_buf(ctx); > =20 > + ret =3D pm_runtime_resume_and_get(ctx->dev->dev); > + if (ret < 0) > + goto err_cancel_job; > + > ret =3D clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks= ); > if (ret) > goto err_cancel_job; > - ret =3D pm_runtime_get_sync(ctx->dev->dev); > - if (ret < 0) > - goto err_cancel_job; > =20 > v4l2_m2m_buf_copy_metadata(src, dst, true); > =20 > @@ -165,7 +174,7 @@ static void device_run(void *priv) > return; > =20 > err_cancel_job: > - hantro_job_finish(ctx->dev, ctx, VB2_BUF_STATE_ERROR); > + hantro_job_finish_no_pm(ctx->dev, ctx, VB2_BUF_STATE_ERROR); > } > =20 > static struct v4l2_m2m_ops vpu_m2m_ops =3D { >=20 > Thanks, > Mauro Actually, the order at the finish logic should change as well. Maybe like this: static void hantro_job_finish_no_pm(struct hantro_dev *vpu, struct hantro_ctx *ctx, enum vb2_buffer_state result) { struct vb2_v4l2_buffer *src, *dst; src =3D v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx); dst =3D v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx); if (WARN_ON(!src)) return; if (WARN_ON(!dst)) return; src->sequence =3D ctx->sequence_out++; dst->sequence =3D ctx->sequence_cap++; v4l2_m2m_buf_done_and_job_finish(ctx->dev->m2m_dev, ctx->fh.m2m_ctx, result); } static void hantro_job_finish(struct hantro_dev *vpu, struct hantro_ctx *ctx, enum vb2_buffer_state result) { hantro_job_finish_no_pm(vpu, ctx, result); clk_bulk_disable(vpu->variant->num_clocks, vpu->clocks); pm_runtime_mark_last_busy(vpu->dev); pm_runtime_put_autosuspend(vpu->dev); } static void device_run(void *priv) { struct hantro_ctx *ctx =3D priv; struct vb2_v4l2_buffer *src, *dst; int ret; src =3D hantro_get_src_buf(ctx); dst =3D hantro_get_dst_buf(ctx); ret =3D pm_runtime_resume_and_get(ctx->dev->dev); if (ret < 0) goto err_cancel_job; ret =3D clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks); if (ret) goto err_cancel_job; v4l2_m2m_buf_copy_metadata(src, dst, true); ctx->codec_ops->run(ctx); return; err_cancel_job: hantro_job_finish_no_pm(ctx->dev, ctx, VB2_BUF_STATE_ERROR); } Thanks, Mauro