From: Dan Carpenter <dan.carpenter@oracle.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v3 3/6] staging: media: atomisp: use __func__ over function names
Date: Wed, 28 Apr 2021 13:27:17 +0300 [thread overview]
Message-ID: <20210428102717.GT1981@kadam> (raw)
In-Reply-To: <2cb42846abb7cab5e64bc29d5e496766f5df169b.1619199344.git.drv@mailo.com>
On Sun, Apr 25, 2021 at 02:13:15PM +0530, Deepak R Varma wrote:
> Replace hard coded function names from the debug print strings by
> standard __func__ predefined identifier. This resolves following
> checkpatch script WARNING:
> Prefer using '"%s...", __func__' to using function's name, in a string.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
>
> Changes since v2:
> - None.
> Changes since v1:
> - None.
>
> .../staging/media/atomisp/i2c/atomisp-gc0310.c | 2 +-
> .../staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
> .../staging/media/atomisp/i2c/atomisp-lm3554.c | 2 +-
> .../staging/media/atomisp/i2c/atomisp-ov2680.c | 16 ++++++++--------
> .../staging/media/atomisp/i2c/atomisp-ov2722.c | 2 +-
> 5 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
> index d68a2bcc9ae1..b572551f1a0d 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
> @@ -1292,7 +1292,7 @@ static int gc0310_remove(struct i2c_client *client)
> struct v4l2_subdev *sd = i2c_get_clientdata(client);
> struct gc0310_device *dev = to_gc0310_sensor(sd);
>
> - dev_dbg(&client->dev, "gc0310_remove...\n");
> + dev_dbg(&client->dev, "%s...\n", __func__);
>
> dev->platform_data->csi_cfg(sd, 0);
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> index e722c639b60d..548c572d3b57 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> @@ -1034,7 +1034,7 @@ static int gc2235_remove(struct i2c_client *client)
> struct v4l2_subdev *sd = i2c_get_clientdata(client);
> struct gc2235_device *dev = to_gc2235_sensor(sd);
>
> - dev_dbg(&client->dev, "gc2235_remove...\n");
> + dev_dbg(&client->dev, "%s...\n", __func__);
Just delete printks that only print the function name. We have ftrace
for that. There are several others below.
regards,
dan carpenter
next prev parent reply other threads:[~2021-04-28 10:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 8:40 [PATCH RESEND v3 0/6] staging: media: atomisp: code cleanup fixes Deepak R Varma
2021-04-25 8:41 ` [PATCH RESEND v3 1/6] staging: media: atomisp: improve function argument alignment Deepak R Varma
2021-04-28 11:38 ` Hans Verkuil
2021-04-25 8:42 ` [PATCH RESEND v3 2/6] staging: media: atomisp: balance braces around if...else block Deepak R Varma
2021-04-26 9:56 ` Fabio Aiuto
2021-04-26 14:30 ` Deepak R Varma
2021-04-26 17:22 ` Fabio Aiuto
2021-04-25 8:43 ` [PATCH RESEND v3 3/6] staging: media: atomisp: use __func__ over function names Deepak R Varma
2021-04-28 10:27 ` Dan Carpenter [this message]
2021-04-28 13:49 ` Deepak R Varma
2021-04-25 8:43 ` [PATCH RESEND v3 4/6] staging: media: atomisp: reformat code comment blocks Deepak R Varma
2021-04-25 8:45 ` [PATCH RESEND v3 5/6] staging: media: atomisp: fix CamelCase variable naming Deepak R Varma
2021-04-25 8:46 ` [PATCH RESEND v3 6/6] staging: media: atomisp: replace raw printk() by dev_info() Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428102717.GT1981@kadam \
--to=dan.carpenter@oracle.com \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.