From: Florian Westphal <fw@strlen.de>
To: Ali Abdallah <ali.abdallah@suse.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Avoid potentially erroneos RST check
Date: Wed, 28 Apr 2021 15:23:38 +0200 [thread overview]
Message-ID: <20210428132338.GF975@breakpoint.cc> (raw)
In-Reply-To: <20210428131147.w2ppmrt6hpcjin5i@Fryzen495>
Ali Abdallah <ali.abdallah@suse.com> wrote:
> In 'commit b303e7b80ff1 ("Reset the max ACK flag on SYN in ignore state")'
> we reset the max ACK number to avoid dropping valid RST that is a
> response to a SYN.
>
> Unfortunately that might not be enough, an out of order ACK in origin
> might reset it back, and we might end up again dropping valid RST.
>
> This patch disables the RST check when we are not in established state
> and we receive an RST with SEQ=0 that is most likely a response to a
> SYN we had let it go through.
>
> Signed-off-by: Ali Abdallah <aabdallah@suse.de>
Looks good, thanks!
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2021-04-28 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 13:11 [PATCH] Avoid potentially erroneos RST check Ali Abdallah
2021-04-28 13:23 ` Florian Westphal [this message]
2021-04-28 14:30 ` Pablo Neira Ayuso
2021-04-30 9:27 ` Ali Abdallah
2021-05-03 21:07 ` Pablo Neira Ayuso
2021-05-04 6:55 ` Ali Abdallah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428132338.GF975@breakpoint.cc \
--to=fw@strlen.de \
--cc=ali.abdallah@suse.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.