From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01866C433ED for ; Thu, 29 Apr 2021 20:24:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8023E613FA for ; Thu, 29 Apr 2021 20:24:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8023E613FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 260EA6F4B1; Thu, 29 Apr 2021 20:24:54 +0000 (UTC) X-Greylist: delayed 378 seconds by postgrey-1.36 at gabe; Thu, 29 Apr 2021 20:05:05 UTC Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EF606F49D; Thu, 29 Apr 2021 20:05:05 +0000 (UTC) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id C43DD1C0BA2; Thu, 29 Apr 2021 21:58:44 +0200 (CEST) Date: Thu, 29 Apr 2021 21:58:43 +0200 From: Pavel Machek To: Daniel Vetter Message-ID: <20210429195843.GA1067@bug> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Mailman-Approved-At: Thu, 29 Apr 2021 20:24:52 +0000 Subject: Re: [Intel-gfx] [PATCH 000/190] Revertion of all of the umn.edu commits X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean Delvare , David Airlie , Greg Kroah-Hartman , intel-gfx , Kangjie Lu , Linux Kernel Mailing List , dri-devel , "Anholt, Eric" , Ben Skeggs , Aditya Pakki , Alex Deucher , Linus Walleij , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi! > > Revert "drm/radeon: Fix reference count leaks caused by > > pm_runtime_get_sync" > > Revert "drm/radeon: fix multiple reference count leak" > > Revert "drm/amdkfd: Fix reference count leaks." > > I didn't review these carefully, but from a quick look they all seem > rather inconsequental. Either error paths that are very unlikely, or > drivers which are very dead (looking at the entire list, not just what > you reverted here). > > Acked-by: Daniel Vetter So you are knowingly acking patch re-introducing bugs into kernel, because the bugs are minor? I don't believe that's an okay thing to do. Maybe something needs reverting, but lets not introduce bugs into kernel because they are "minor". Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB480C43461 for ; Fri, 30 Apr 2021 06:53:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F9E0613E8 for ; Fri, 30 Apr 2021 06:53:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F9E0613E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 893176E491; Fri, 30 Apr 2021 06:53:28 +0000 (UTC) X-Greylist: delayed 378 seconds by postgrey-1.36 at gabe; Thu, 29 Apr 2021 20:05:05 UTC Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EF606F49D; Thu, 29 Apr 2021 20:05:05 +0000 (UTC) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id C43DD1C0BA2; Thu, 29 Apr 2021 21:58:44 +0200 (CEST) Date: Thu, 29 Apr 2021 21:58:43 +0200 From: Pavel Machek To: Daniel Vetter Subject: Re: [PATCH 000/190] Revertion of all of the umn.edu commits Message-ID: <20210429195843.GA1067@bug> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Mailman-Approved-At: Fri, 30 Apr 2021 06:53:27 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean Delvare , David Airlie , Greg Kroah-Hartman , intel-gfx , Kangjie Lu , Linux Kernel Mailing List , dri-devel , Ben Skeggs , Aditya Pakki , Alex Deucher , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi! > > Revert "drm/radeon: Fix reference count leaks caused by > > pm_runtime_get_sync" > > Revert "drm/radeon: fix multiple reference count leak" > > Revert "drm/amdkfd: Fix reference count leaks." > > I didn't review these carefully, but from a quick look they all seem > rather inconsequental. Either error paths that are very unlikely, or > drivers which are very dead (looking at the entire list, not just what > you reverted here). > > Acked-by: Daniel Vetter So you are knowingly acking patch re-introducing bugs into kernel, because the bugs are minor? I don't believe that's an okay thing to do. Maybe something needs reverting, but lets not introduce bugs into kernel because they are "minor". Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537ECC43461 for ; Thu, 29 Apr 2021 20:01:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39FE1613C1 for ; Thu, 29 Apr 2021 20:01:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237065AbhD2UB4 convert rfc822-to-8bit (ORCPT ); Thu, 29 Apr 2021 16:01:56 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:51684 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236978AbhD2T7c (ORCPT ); Thu, 29 Apr 2021 15:59:32 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id C43DD1C0BA2; Thu, 29 Apr 2021 21:58:44 +0200 (CEST) Date: Thu, 29 Apr 2021 21:58:43 +0200 From: Pavel Machek To: Daniel Vetter Cc: Greg Kroah-Hartman , Ben Skeggs , Alex Deucher , dri-devel , intel-gfx , "Anholt, Eric" , "airlied@gmail.com" , Linux Kernel Mailing List , Aditya Pakki , Kangjie Lu , David Airlie , Linus Walleij , Jean Delvare , Laurent Pinchart Subject: Re: [PATCH 000/190] Revertion of all of the umn.edu commits Message-ID: <20210429195843.GA1067@bug> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > Revert "drm/radeon: Fix reference count leaks caused by > > pm_runtime_get_sync" > > Revert "drm/radeon: fix multiple reference count leak" > > Revert "drm/amdkfd: Fix reference count leaks." > > I didn't review these carefully, but from a quick look they all seem > rather inconsequental. Either error paths that are very unlikely, or > drivers which are very dead (looking at the entire list, not just what > you reverted here). > > Acked-by: Daniel Vetter So you are knowingly acking patch re-introducing bugs into kernel, because the bugs are minor? I don't believe that's an okay thing to do. Maybe something needs reverting, but lets not introduce bugs into kernel because they are "minor". Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html