Re: [RFC PATCH v4 25/27] qedn: Add IO level fastpath functionality

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 11325 bytes --]

Hi Shai,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on ipvs/master]
[also build test WARNING on hch-configfs/for-next linus/master v5.12 next-20210429]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210430-032713
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2a840fd9894aaff7c29039f836288694208bb6fa
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210430-032713
        git checkout 2a840fd9894aaff7c29039f836288694208bb6fa
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/nvme/hw/qedn/qedn_task.c: In function 'qedn_destroy_single_task':
   drivers/nvme/hw/qedn/qedn_task.c:102:6: warning: variable 'itid' set but not used [-Wunused-but-set-variable]
     102 |  u16 itid;
         |      ^~~~
   drivers/nvme/hw/qedn/qedn_task.c: At top level:
   drivers/nvme/hw/qedn/qedn_task.c:349:6: warning: no previous prototype for 'qedn_return_task_to_pool' [-Wmissing-prototypes]
     349 | void qedn_return_task_to_pool(struct qedn_conn_ctx *conn_ctx,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c:379:1: warning: no previous prototype for 'qedn_get_free_task_from_pool' [-Wmissing-prototypes]
     379 | qedn_get_free_task_from_pool(struct qedn_conn_ctx *conn_ctx, u16 cccid)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c:439:5: warning: no previous prototype for 'qedn_send_read_cmd' [-Wmissing-prototypes]
     439 | int qedn_send_read_cmd(struct qedn_task_ctx *qedn_task, struct qedn_conn_ctx *conn_ctx)
         |     ^~~~~~~~~~~~~~~~~~
   In file included from include/linux/swab.h:5,
                    from include/uapi/linux/byteorder/big_endian.h:13,
                    from include/linux/byteorder/big_endian.h:5,
                    from arch/mips/include/uapi/asm/byteorder.h:13,
                    from arch/mips/include/asm/bitops.h:20,
                    from include/linux/bitops.h:32,
                    from include/linux/kernel.h:11,
                    from drivers/nvme/hw/qedn/qedn_task.c:9:
   drivers/nvme/hw/qedn/qedn_task.c: In function 'qedn_send_read_cmd':
>> drivers/nvme/hw/qedn/qedn_task.c:455:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     455 |  task_params.opq.lo = cpu_to_le32(((u64)(qedn_task)) & 0xffffffff);
         |                                    ^
   include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32'
     115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
         |                                                      ^
   include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32'
      88 | #define cpu_to_le32 __cpu_to_le32
         |                     ^~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c:455:23: note: in expansion of macro 'cpu_to_le32'
     455 |  task_params.opq.lo = cpu_to_le32(((u64)(qedn_task)) & 0xffffffff);
         |                       ^~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c:456:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     456 |  task_params.opq.hi = cpu_to_le32(((u64)(qedn_task)) >> 32);
         |                                    ^
   include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32'
     115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
         |                                                      ^
   include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32'
      88 | #define cpu_to_le32 __cpu_to_le32
         |                     ^~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c:456:23: note: in expansion of macro 'cpu_to_le32'
     456 |  task_params.opq.hi = cpu_to_le32(((u64)(qedn_task)) >> 32);
         |                       ^~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c: At top level:
   drivers/nvme/hw/qedn/qedn_task.c:494:5: warning: no previous prototype for 'qedn_send_write_cmd' [-Wmissing-prototypes]
     494 | int qedn_send_write_cmd(struct qedn_task_ctx *qedn_task, struct qedn_conn_ctx *conn_ctx)
         |     ^~~~~~~~~~~~~~~~~~~
   In file included from include/linux/swab.h:5,
                    from include/uapi/linux/byteorder/big_endian.h:13,
                    from include/linux/byteorder/big_endian.h:5,
                    from arch/mips/include/uapi/asm/byteorder.h:13,
                    from arch/mips/include/asm/bitops.h:20,
                    from include/linux/bitops.h:32,
                    from include/linux/kernel.h:11,
                    from drivers/nvme/hw/qedn/qedn_task.c:9:
   drivers/nvme/hw/qedn/qedn_task.c: In function 'qedn_send_write_cmd':
   drivers/nvme/hw/qedn/qedn_task.c:526:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     526 |  task_params.opq.lo = cpu_to_le32(((u64)(qedn_task)) & 0xffffffff);
         |                                    ^
   include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32'
     115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
         |                                                      ^
   include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32'
      88 | #define cpu_to_le32 __cpu_to_le32
         |                     ^~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c:526:23: note: in expansion of macro 'cpu_to_le32'
     526 |  task_params.opq.lo = cpu_to_le32(((u64)(qedn_task)) & 0xffffffff);
         |                       ^~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c:527:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     527 |  task_params.opq.hi = cpu_to_le32(((u64)(qedn_task)) >> 32);
         |                                    ^
   include/uapi/linux/swab.h:115:54: note: in definition of macro '__swab32'
     115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
         |                                                      ^
   include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32'
      88 | #define cpu_to_le32 __cpu_to_le32
         |                     ^~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c:527:23: note: in expansion of macro 'cpu_to_le32'
     527 |  task_params.opq.hi = cpu_to_le32(((u64)(qedn_task)) >> 32);
         |                       ^~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c: At top level:
   drivers/nvme/hw/qedn/qedn_task.c:680:23: warning: no previous prototype for 'qedn_cqe_get_active_task' [-Wmissing-prototypes]
     680 | struct qedn_task_ctx *qedn_cqe_get_active_task(struct nvmetcp_fw_cqe *cqe)
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c: In function 'qedn_cqe_get_active_task':
   drivers/nvme/hw/qedn/qedn_task.c:684:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     684 |  return (struct qedn_task_ctx *)((((u64)(le32_to_cpu(p->hi)) << 32)
         |         ^
   drivers/nvme/hw/qedn/qedn_task.c: At top level:
   drivers/nvme/hw/qedn/qedn_task.c:722:5: warning: no previous prototype for 'qedn_process_nvme_cqe' [-Wmissing-prototypes]
     722 | int qedn_process_nvme_cqe(struct qedn_task_ctx *qedn_task, struct nvme_completion *cqe)
         |     ^~~~~~~~~~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c:736:5: warning: no previous prototype for 'qedn_complete_c2h' [-Wmissing-prototypes]
     736 | int qedn_complete_c2h(struct qedn_task_ctx *qedn_task)
         |     ^~~~~~~~~~~~~~~~~
   drivers/nvme/hw/qedn/qedn_task.c: In function 'qedn_io_work_cq':
   drivers/nvme/hw/qedn/qedn_task.c:756:6: warning: variable 'cid' set but not used [-Wunused-but-set-variable]
     756 |  u32 cid;
         |      ^~~
   drivers/nvme/hw/qedn/qedn_task.c:755:6: warning: variable 'itid' set but not used [-Wunused-but-set-variable]
     755 |  u16 itid;
         |      ^~~~


vim +455 drivers/nvme/hw/qedn/qedn_task.c

   438	
   439	int qedn_send_read_cmd(struct qedn_task_ctx *qedn_task, struct qedn_conn_ctx *conn_ctx)
   440	{
   441		struct nvme_command *nvme_cmd = &qedn_task->req->nvme_cmd;
   442		struct qedn_ctx *qedn = conn_ctx->qedn;
   443		struct nvmetcp_cmd_capsule_hdr cmd_hdr;
   444		struct nvmetcp_task_params task_params;
   445		struct nvmetcp_conn_params conn_params;
   446		struct nvmetcp_wqe *chain_sqe;
   447		struct nvmetcp_wqe local_sqe;
   448		int rc;
   449		int i;
   450	
   451		rc = qedn_init_sgl(qedn, qedn_task);
   452		if (rc)
   453			return rc;
   454	
 > 455		task_params.opq.lo = cpu_to_le32(((u64)(qedn_task)) & 0xffffffff);
   456		task_params.opq.hi = cpu_to_le32(((u64)(qedn_task)) >> 32);
   457	
   458		/* Initialize task params */
   459		task_params.context = qedn_task->fw_task_ctx;
   460		task_params.sqe = &local_sqe;
   461		task_params.tx_io_size = 0;
   462		task_params.rx_io_size = qedn_task->task_size;
   463		task_params.conn_icid = (u16)conn_ctx->conn_handle;
   464		task_params.itid = qedn_task->itid;
   465		task_params.cq_rss_number = conn_ctx->default_cq;
   466		task_params.send_write_incapsule = 0;
   467	
   468		/* Initialize conn params */
   469		conn_params.max_burst_length = QEDN_MAX_IO_SIZE;
   470	
   471		cmd_hdr.chdr.pdu_type = nvme_tcp_cmd;
   472		cmd_hdr.chdr.flags = 0;
   473		cmd_hdr.chdr.hlen = sizeof(cmd_hdr);
   474		cmd_hdr.chdr.pdo = 0x0;
   475		cmd_hdr.chdr.plen_swapped = cpu_to_le32(__swab32(cmd_hdr.chdr.hlen));
   476	
   477		for (i = 0; i < 16; i++)
   478			cmd_hdr.pshdr.raw_swapped[i] = cpu_to_le32(__swab32(((u32 *)nvme_cmd)[i]));
   479	
   480		qed_ops->init_read_io(&task_params, &conn_params, &cmd_hdr, &qedn_task->sgl_task_params);
   481	
   482		set_bit(QEDN_TASK_USED_BY_FW, &qedn_task->flags);
   483		atomic_inc(&conn_ctx->num_active_fw_tasks);
   484	
   485		spin_lock(&conn_ctx->ep.doorbell_lock);
   486		chain_sqe = qed_chain_produce(&conn_ctx->ep.fw_sq_chain);
   487		memcpy(chain_sqe, &local_sqe, sizeof(local_sqe));
   488		qedn_ring_doorbell(conn_ctx);
   489		spin_unlock(&conn_ctx->ep.doorbell_lock);
   490	
   491		return 0;
   492	}
   493	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 70250 bytes --]