Re: [RFT PATCH] ACPICA: Fix memory leak caused by _CID repair function

[Shawn Guo <shawn.guo@linaro.org>]

On Wed, Apr 28, 2021 at 03:52:47PM -0700, Erik Kaneda wrote:
> ACPICA commit 5fc4f4b87d6890d48d050ab279ed01f0132662ca
> 
> According to the ACPI spec, _CID returns a package containing
> hardware ID's. Each element of an ASL package contains a reference
> count from the parent package as well as the element itself.
> 
> Name (TEST, Package() {
>     "String object" // this package element has a reference count of 2
> })
> 
> A memory leak was caused in the _CID repair function because it did
> not decrement the reference count created by the package. Fix the
> memory leak by calling acpi_ut_remove_reference on _CID package elements
> that represent a hardware ID (_HID).
> 
> Link: https://github.com/acpica/acpica/commit/5fc4f4b8
> 
> Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>

Tested on Snapdragon laptops, and nothing seems broken.

Tested-by: Shawn Guo <shawn.guo@linaro.org>