From: Marek Behun <marek.behun@nic.cz>
To: Enzo Matsumiya <ematsumiya@suse.de>
Cc: linux-leds@vger.kernel.org, linux-block@vger.kernel.org,
u.kleine-koenig@pengutronix.de, Jens Axboe <axboe@kernel.dk>,
Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] leds: trigger: implement block trigger
Date: Fri, 30 Apr 2021 22:11:21 +0200 [thread overview]
Message-ID: <20210430221121.46461c81@thinkpad> (raw)
In-Reply-To: <20210430183216.27458-3-ematsumiya@suse.de>
On Fri, 30 Apr 2021 15:32:11 -0300
Enzo Matsumiya <ematsumiya@suse.de> wrote:
> Activity is then represented in an accumulated manner (part_read_stat_accum()),
> with a fixed blinking interval of 50ms.
part_stat_read_accum, not part_read_stat_accum
Why only accum? With the netdev trigger, you can choose whether rx, tx,
or both are blinking the LED.
Also I think the trigger should be called "blockdev" instead of
"block". This is consistent with "netdev", and avoids misinterpretation
with the verb "to block".
Marek
next prev parent reply other threads:[~2021-04-30 20:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 18:32 [RFC PATCH 0/2] leds: trigger: introduce block trigger Enzo Matsumiya
2021-04-30 18:32 ` [RFC PATCH 1/2] block: export block_class and disk_type symbols Enzo Matsumiya
2021-05-01 6:24 ` Greg Kroah-Hartman
2021-05-03 2:37 ` Enzo Matsumiya
2021-05-03 4:48 ` Greg Kroah-Hartman
2021-05-03 7:04 ` Christoph Hellwig
2021-05-03 16:50 ` Enzo Matsumiya
2021-04-30 18:32 ` [RFC PATCH 2/2] leds: trigger: implement block trigger Enzo Matsumiya
2021-04-30 18:52 ` Randy Dunlap
2021-05-03 2:38 ` Enzo Matsumiya
2021-04-30 20:11 ` Marek Behun [this message]
2021-05-03 2:46 ` Enzo Matsumiya
2021-05-03 5:53 ` Hannes Reinecke
2021-05-03 10:11 ` Pavel Machek
2021-05-03 16:56 ` Enzo Matsumiya
2021-05-04 15:43 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430221121.46461c81@thinkpad \
--to=marek.behun@nic.cz \
--cc=axboe@kernel.dk \
--cc=ematsumiya@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.