From: Khaled ROMDHANI <khaledromdhani216@gmail.com>
To: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com
Cc: Khaled ROMDHANI <khaledromdhani216@gmail.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] fs/btrfs: Fix uninitialized variable
Date: Sat, 1 May 2021 23:50:46 +0100 [thread overview]
Message-ID: <20210501225046.9138-1-khaledromdhani216@gmail.com> (raw)
Fix the warning: variable 'zone' is used
uninitialized whenever '?:' condition is true.
Fix that by preventing the code to reach
the last assertion. If the variable 'mirror'
is invalid, the assertion fails and we return
immediately.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com>
---
fs/btrfs/zoned.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 8250ab3f0868..23da9d8dc184 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -145,7 +145,7 @@ static inline u32 sb_zone_number(int shift, int mirror)
case 2: zone = 1ULL << (BTRFS_SB_LOG_SECOND_SHIFT - shift); break;
default:
ASSERT((u32)mirror < 3);
- break;
+ return 0;
}
ASSERT(zone <= U32_MAX);
base-commit: b5c294aac8a6164ddf38bfbdd1776091b4a1eeba
--
2.17.1
next reply other threads:[~2021-05-01 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 22:50 Khaled ROMDHANI [this message]
2021-05-02 10:17 ` [PATCH] fs/btrfs: Fix uninitialized variable Christophe JAILLET
2021-05-03 8:49 ` Khaled Romdhani
2021-05-03 7:23 ` Dan Carpenter
2021-05-03 10:13 ` Khaled Romdhani
2021-05-03 11:55 ` Dan Carpenter
2021-05-03 11:58 ` Colin Ian King
2021-05-17 10:51 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210501225046.9138-1-khaledromdhani216@gmail.com \
--to=khaledromdhani216@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.