From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 1/3] package/libtomcrypt: add pkgconfig support
Date: Sun, 2 May 2021 12:27:46 +0200 [thread overview]
Message-ID: <20210502122746.7988707d@gmx.net> (raw)
In-Reply-To: <45c379f0-8ca0-6891-1b1e-b166600da9ca@mind.be>
Hello Arnout,
On Sat, 1 May 2021 15:18:42 +0200, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 12/04/2021 23:15, Peter Seiderer wrote:
> > Hello Thomas,
> >
> > On Mon, 12 Apr 2021 22:14:53 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> >
> >> On Mon, 12 Apr 2021 21:55:25 +0200
> >> Peter Seiderer <ps.report@gmx.net> wrote:
> >>
> >>> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> >>
> >> Is there any specific motivation? Does this had a chance of going
> >> upstream ?
> >
> > For an custom project, previously developed on with cmake on ubuntu (which
> > provides the pkgconfig file)....
> >
> > Can try to suggest upstream...
>
> Adding a .pc file in Buildroot usually doesn't make much sense, because no
> package that depends on it is going to use it. So yes, please organise this
> upstream.
But a buildroot provided library should be usable for buildroot packages AND
out-of-tree/custom packages?
Nevertheless, did take a second look at the libtomcrypt sources, already
providing a libtomcrypt.pc.in template (but only used/installed in case
of 'makefile.shared'/'makefile.unix' and the buildroot compile uses the
default 'makefile' one)...
Regards,
Peter
>
> Therefore, I've marked this patch as Rejected.
>
> Regards,
> Arnout
next prev parent reply other threads:[~2021-05-02 10:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 19:55 [Buildroot] [PATCH v1 1/3] package/libtomcrypt: add pkgconfig support Peter Seiderer
2021-04-12 19:55 ` [Buildroot] [PATCH v1 2/3] package/libtomcrypt: compile with -fPIC to enable linking to dynamic libraries/exectuables Peter Seiderer
2021-04-12 20:15 ` Thomas Petazzoni
2021-04-12 20:40 ` Peter Seiderer
2021-05-01 13:19 ` Arnout Vandecappelle
2021-05-02 10:15 ` Peter Seiderer
2021-04-12 19:55 ` [Buildroot] [PATCH v1 3/3] package/libtomcrypt: update home page URL to https Peter Seiderer
2021-05-01 13:19 ` Arnout Vandecappelle
2021-05-07 7:33 ` Peter Korsgaard
2021-04-12 20:14 ` [Buildroot] [PATCH v1 1/3] package/libtomcrypt: add pkgconfig support Thomas Petazzoni
2021-04-12 21:15 ` Peter Seiderer
2021-05-01 13:18 ` Arnout Vandecappelle
2021-05-02 10:27 ` Peter Seiderer [this message]
2021-05-03 7:58 ` Arnout Vandecappelle
2021-05-03 19:38 ` Peter Seiderer
2021-05-04 7:28 ` Arnout Vandecappelle
2021-05-06 19:45 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210502122746.7988707d@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.