From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Lee Date: Mon, 3 May 2021 17:40:55 +0800 Subject: [PATCH v2 1/3] dt-bindings: mmc: sdhci-of-aspeed: Add description for AST2600 EVB. In-Reply-To: <75226402-503c-4e9b-96dc-e4bd74cf20ac@www.fastmail.com> References: <20210503014336.20256-1-steven_lee@aspeedtech.com> <20210503014336.20256-2-steven_lee@aspeedtech.com> <75226402-503c-4e9b-96dc-e4bd74cf20ac@www.fastmail.com> Message-ID: <20210503094054.GA12520@aspeedtech.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit The 05/03/2021 12:19, Andrew Jeffery wrote: > Hi Steven, > > On Mon, 3 May 2021, at 11:13, Steven Lee wrote: > > Add the description for describing the AST 2600 EVB reference design of > > GPIO regulators and provide the example in the document. > > > > AST2600-A2 EVB has the reference design for enabling SD bus > > power and toggling SD bus signal voltage by GPIO pins. > > > > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to > > power load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is > > connected to a 1.8v and a 3.3v power load switch that providing > > signal voltage to > > SD1 bus. > > > > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > disabled. > > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 > > signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > enabled, SD1 signal voltage becomes 1.8v. > > > > AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > GPIOV3 as power-switch-gpio. > > > > Signed-off-by: Steven Lee > > --- > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 99 +++++++++++++++++++ > > 1 file changed, 99 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > index 987b287f3bff..dd894aba0bb7 100644 > > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > @@ -20,6 +20,19 @@ description: |+ > > the slots are dependent on the common configuration area, they are > > described > > as child nodes. > > > > + The signal voltage of SDHCIs on AST2600-A2 EVB is able to be toggled > > by GPIO > > + pins. In the reference design, GPIOV0 of AST2600-A2 EVB is connected > > to the > > + power load switch that providing 3.3v to SD1 bus vdd, GPIOV1 is > > connected to > > + a 1.8v and a 3.3v power load switch that providing signal voltage to > > + SD1 bus. > > + If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > + disabled. If GPIOV1 is active high, 3.3v power load switch is > > enabled, SD1 > > + signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > enabled, SD1 > > + signal voltage becomes 1.8v. > > + AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > + The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > GPIOV3 > > + as power-switch-gpio. > > I don't think we should be describing design-specific details in the > binding document. However, I think this would be a great comment in the > AST2600 EVB devicetree. Can you please move it there? > Ok, I will move it to the device tree. I was wondering if the following place is a good place to put the comment at line 534 of aspeed-g6.dtsi sdc: sdc at 1e740000 { // Comment here... compatible = "aspeed,ast2600-sd-controller"; reg = <0x1e740000 0x100>; sdhci0: sdhci at 1e740100 { compatible = "aspeed,ast2600-sdhci", "sdhci"; reg = <0x100 0x100>; interrupts = ; ... } > > + > > properties: > > compatible: > > enum: > > @@ -78,6 +91,7 @@ required: > > - clocks > > > > examples: > > + //Example 1 > > - | > > #include > > sdc at 1e740000 { > > @@ -104,3 +118,88 @@ examples: > > clocks = <&syscon ASPEED_CLK_SDIO>; > > }; > > }; > > + > > + //Example 2 (AST2600EVB with GPIO regulator) > > I feel you didn't test this with `make dt_binding_check` as `//` isn't > a valid YAML comment token. You need to use `#` for comments ( > https://yaml.org/spec/1.2/spec.html#id2780069 ). > Sorry, I don't know that there is a binding check command for valiating YAML document. Regardless, thanks for the reference link. I will test with dt_binding_check. > > + - | > > + #include > > + #include > > + vcc_sdhci0: regulator-vcc-sdhci0 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "SDHCI0 Vcc"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 0) > > + GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + }; > > + > > + vccq_sdhci0: regulator-vccq-sdhci0 { > > + compatible = "regulator-gpio"; > > + > > + regulator-name = "SDHCI0 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 1) > > + GPIO_ACTIVE_HIGH>; > > + gpios-states = <1>; > > + states = <3300000 1 > > + 1800000 0>; > > + }; > > + > > + vcc_sdhci1: regulator-vcc-sdhci1 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "SDHCI1 Vcc"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 2) > > + GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + }; > > + > > + vccq_sdhci1: regulator-vccq-sdhci1 { > > + compatible = "regulator-gpio"; > > + > > + regulator-name = "SDHCI1 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 3) > > + GPIO_ACTIVE_HIGH>; > > + gpios-states = <1>; > > + states = <3300000 1 > > + 1800000 0>; > > + }; > > + > > + sdc at 1e740000 { > > + compatible = "aspeed,ast2600-sd-controller"; > > + reg = <0x1e740000 0x100>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x1e740000 0x20000>; > > + clocks = <&syscon ASPEED_CLK_GATE_SDCLK>; > > + > > + sdhci0: sdhci at 100 { > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > + reg = <0x100 0x100>; > > + interrupts = ; > > + sdhci,auto-cmd12; > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > + vmmc-supply = <&vcc_sdhci0>; > > + vqmmc-supply = <&vccq_sdhci0>; > > + sd-uhs-sdr104; > > + clk-phase-uhs-sdr104 = <180>, <180>; > > + }; > > + > > + sdhci1: sdhci at 200 { > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > + reg = <0x200 0x100>; > > + interrupts = ; > > + sdhci,auto-cmd12; > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > + vmmc-supply = <&vcc_sdhci1>; > > + vqmmc-supply = <&vccq_sdhci1>; > > + sd-uhs-sdr104; > > + clk-phase-uhs-sdr104 = <0>, <0>; > > + }; > > + }; > > This is a good example, so can we keep this and just drop the comment > from the binding document? Ok, I will remove the comment. > > Cheers, > > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9558EC433ED for ; Mon, 3 May 2021 09:41:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FFEE61353 for ; Mon, 3 May 2021 09:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232960AbhECJl5 (ORCPT ); Mon, 3 May 2021 05:41:57 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:22164 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231523AbhECJl4 (ORCPT ); Mon, 3 May 2021 05:41:56 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1439TKIo029925; Mon, 3 May 2021 17:29:20 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 May 2021 17:40:58 +0800 Date: Mon, 3 May 2021 17:40:55 +0800 From: Steven Lee To: Andrew Jeffery CC: Ulf Hansson , Rob Herring , Joel Stanley , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Hongwei Zhang , Ryan Chen , Chin-Ting Kuo Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: sdhci-of-aspeed: Add description for AST2600 EVB. Message-ID: <20210503094054.GA12520@aspeedtech.com> References: <20210503014336.20256-1-steven_lee@aspeedtech.com> <20210503014336.20256-2-steven_lee@aspeedtech.com> <75226402-503c-4e9b-96dc-e4bd74cf20ac@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <75226402-503c-4e9b-96dc-e4bd74cf20ac@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1439TKIo029925 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The 05/03/2021 12:19, Andrew Jeffery wrote: > Hi Steven, > > On Mon, 3 May 2021, at 11:13, Steven Lee wrote: > > Add the description for describing the AST 2600 EVB reference design of > > GPIO regulators and provide the example in the document. > > > > AST2600-A2 EVB has the reference design for enabling SD bus > > power and toggling SD bus signal voltage by GPIO pins. > > > > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to > > power load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is > > connected to a 1.8v and a 3.3v power load switch that providing > > signal voltage to > > SD1 bus. > > > > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > disabled. > > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 > > signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > enabled, SD1 signal voltage becomes 1.8v. > > > > AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > GPIOV3 as power-switch-gpio. > > > > Signed-off-by: Steven Lee > > --- > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 99 +++++++++++++++++++ > > 1 file changed, 99 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > index 987b287f3bff..dd894aba0bb7 100644 > > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > @@ -20,6 +20,19 @@ description: |+ > > the slots are dependent on the common configuration area, they are > > described > > as child nodes. > > > > + The signal voltage of SDHCIs on AST2600-A2 EVB is able to be toggled > > by GPIO > > + pins. In the reference design, GPIOV0 of AST2600-A2 EVB is connected > > to the > > + power load switch that providing 3.3v to SD1 bus vdd, GPIOV1 is > > connected to > > + a 1.8v and a 3.3v power load switch that providing signal voltage to > > + SD1 bus. > > + If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > + disabled. If GPIOV1 is active high, 3.3v power load switch is > > enabled, SD1 > > + signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > enabled, SD1 > > + signal voltage becomes 1.8v. > > + AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > + The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > GPIOV3 > > + as power-switch-gpio. > > I don't think we should be describing design-specific details in the > binding document. However, I think this would be a great comment in the > AST2600 EVB devicetree. Can you please move it there? > Ok, I will move it to the device tree. I was wondering if the following place is a good place to put the comment at line 534 of aspeed-g6.dtsi sdc: sdc@1e740000 { // Comment here... compatible = "aspeed,ast2600-sd-controller"; reg = <0x1e740000 0x100>; sdhci0: sdhci@1e740100 { compatible = "aspeed,ast2600-sdhci", "sdhci"; reg = <0x100 0x100>; interrupts = ; ... } > > + > > properties: > > compatible: > > enum: > > @@ -78,6 +91,7 @@ required: > > - clocks > > > > examples: > > + //Example 1 > > - | > > #include > > sdc@1e740000 { > > @@ -104,3 +118,88 @@ examples: > > clocks = <&syscon ASPEED_CLK_SDIO>; > > }; > > }; > > + > > + //Example 2 (AST2600EVB with GPIO regulator) > > I feel you didn't test this with `make dt_binding_check` as `//` isn't > a valid YAML comment token. You need to use `#` for comments ( > https://yaml.org/spec/1.2/spec.html#id2780069 ). > Sorry, I don't know that there is a binding check command for valiating YAML document. Regardless, thanks for the reference link. I will test with dt_binding_check. > > + - | > > + #include > > + #include > > + vcc_sdhci0: regulator-vcc-sdhci0 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "SDHCI0 Vcc"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 0) > > + GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + }; > > + > > + vccq_sdhci0: regulator-vccq-sdhci0 { > > + compatible = "regulator-gpio"; > > + > > + regulator-name = "SDHCI0 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 1) > > + GPIO_ACTIVE_HIGH>; > > + gpios-states = <1>; > > + states = <3300000 1 > > + 1800000 0>; > > + }; > > + > > + vcc_sdhci1: regulator-vcc-sdhci1 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "SDHCI1 Vcc"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 2) > > + GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + }; > > + > > + vccq_sdhci1: regulator-vccq-sdhci1 { > > + compatible = "regulator-gpio"; > > + > > + regulator-name = "SDHCI1 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 3) > > + GPIO_ACTIVE_HIGH>; > > + gpios-states = <1>; > > + states = <3300000 1 > > + 1800000 0>; > > + }; > > + > > + sdc@1e740000 { > > + compatible = "aspeed,ast2600-sd-controller"; > > + reg = <0x1e740000 0x100>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x1e740000 0x20000>; > > + clocks = <&syscon ASPEED_CLK_GATE_SDCLK>; > > + > > + sdhci0: sdhci@100 { > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > + reg = <0x100 0x100>; > > + interrupts = ; > > + sdhci,auto-cmd12; > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > + vmmc-supply = <&vcc_sdhci0>; > > + vqmmc-supply = <&vccq_sdhci0>; > > + sd-uhs-sdr104; > > + clk-phase-uhs-sdr104 = <180>, <180>; > > + }; > > + > > + sdhci1: sdhci@200 { > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > + reg = <0x200 0x100>; > > + interrupts = ; > > + sdhci,auto-cmd12; > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > + vmmc-supply = <&vcc_sdhci1>; > > + vqmmc-supply = <&vccq_sdhci1>; > > + sd-uhs-sdr104; > > + clk-phase-uhs-sdr104 = <0>, <0>; > > + }; > > + }; > > This is a good example, so can we keep this and just drop the comment > from the binding document? Ok, I will remove the comment. > > Cheers, > > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E475AC433B4 for ; Mon, 3 May 2021 09:42:31 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30D0A611CE for ; Mon, 3 May 2021 09:42:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30D0A611CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FYdLF4Gm3z301s for ; Mon, 3 May 2021 19:42:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=fail (SPF fail - not authorized) smtp.mailfrom=aspeedtech.com (client-ip=211.20.114.71; helo=twspam01.aspeedtech.com; envelope-from=steven_lee@aspeedtech.com; receiver=) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FYdKp2BT3z2xb8; Mon, 3 May 2021 19:42:04 +1000 (AEST) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1439TKIo029925; Mon, 3 May 2021 17:29:20 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 May 2021 17:40:58 +0800 Date: Mon, 3 May 2021 17:40:55 +0800 From: Steven Lee To: Andrew Jeffery Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: sdhci-of-aspeed: Add description for AST2600 EVB. Message-ID: <20210503094054.GA12520@aspeedtech.com> References: <20210503014336.20256-1-steven_lee@aspeedtech.com> <20210503014336.20256-2-steven_lee@aspeedtech.com> <75226402-503c-4e9b-96dc-e4bd74cf20ac@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <75226402-503c-4e9b-96dc-e4bd74cf20ac@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1439TKIo029925 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ulf Hansson , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "moderated list:ASPEED SD/MMC DRIVER" , Ryan Chen , open list , Chin-Ting Kuo , Rob Herring , Hongwei Zhang , "moderated list:ARM/ASPEED MACHINE SUPPORT" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" The 05/03/2021 12:19, Andrew Jeffery wrote: > Hi Steven, > > On Mon, 3 May 2021, at 11:13, Steven Lee wrote: > > Add the description for describing the AST 2600 EVB reference design of > > GPIO regulators and provide the example in the document. > > > > AST2600-A2 EVB has the reference design for enabling SD bus > > power and toggling SD bus signal voltage by GPIO pins. > > > > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to > > power load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is > > connected to a 1.8v and a 3.3v power load switch that providing > > signal voltage to > > SD1 bus. > > > > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > disabled. > > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 > > signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > enabled, SD1 signal voltage becomes 1.8v. > > > > AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > GPIOV3 as power-switch-gpio. > > > > Signed-off-by: Steven Lee > > --- > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 99 +++++++++++++++++++ > > 1 file changed, 99 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > index 987b287f3bff..dd894aba0bb7 100644 > > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > @@ -20,6 +20,19 @@ description: |+ > > the slots are dependent on the common configuration area, they are > > described > > as child nodes. > > > > + The signal voltage of SDHCIs on AST2600-A2 EVB is able to be toggled > > by GPIO > > + pins. In the reference design, GPIOV0 of AST2600-A2 EVB is connected > > to the > > + power load switch that providing 3.3v to SD1 bus vdd, GPIOV1 is > > connected to > > + a 1.8v and a 3.3v power load switch that providing signal voltage to > > + SD1 bus. > > + If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > + disabled. If GPIOV1 is active high, 3.3v power load switch is > > enabled, SD1 > > + signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > enabled, SD1 > > + signal voltage becomes 1.8v. > > + AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > + The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > GPIOV3 > > + as power-switch-gpio. > > I don't think we should be describing design-specific details in the > binding document. However, I think this would be a great comment in the > AST2600 EVB devicetree. Can you please move it there? > Ok, I will move it to the device tree. I was wondering if the following place is a good place to put the comment at line 534 of aspeed-g6.dtsi sdc: sdc@1e740000 { // Comment here... compatible = "aspeed,ast2600-sd-controller"; reg = <0x1e740000 0x100>; sdhci0: sdhci@1e740100 { compatible = "aspeed,ast2600-sdhci", "sdhci"; reg = <0x100 0x100>; interrupts = ; ... } > > + > > properties: > > compatible: > > enum: > > @@ -78,6 +91,7 @@ required: > > - clocks > > > > examples: > > + //Example 1 > > - | > > #include > > sdc@1e740000 { > > @@ -104,3 +118,88 @@ examples: > > clocks = <&syscon ASPEED_CLK_SDIO>; > > }; > > }; > > + > > + //Example 2 (AST2600EVB with GPIO regulator) > > I feel you didn't test this with `make dt_binding_check` as `//` isn't > a valid YAML comment token. You need to use `#` for comments ( > https://yaml.org/spec/1.2/spec.html#id2780069 ). > Sorry, I don't know that there is a binding check command for valiating YAML document. Regardless, thanks for the reference link. I will test with dt_binding_check. > > + - | > > + #include > > + #include > > + vcc_sdhci0: regulator-vcc-sdhci0 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "SDHCI0 Vcc"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 0) > > + GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + }; > > + > > + vccq_sdhci0: regulator-vccq-sdhci0 { > > + compatible = "regulator-gpio"; > > + > > + regulator-name = "SDHCI0 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 1) > > + GPIO_ACTIVE_HIGH>; > > + gpios-states = <1>; > > + states = <3300000 1 > > + 1800000 0>; > > + }; > > + > > + vcc_sdhci1: regulator-vcc-sdhci1 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "SDHCI1 Vcc"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 2) > > + GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + }; > > + > > + vccq_sdhci1: regulator-vccq-sdhci1 { > > + compatible = "regulator-gpio"; > > + > > + regulator-name = "SDHCI1 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 3) > > + GPIO_ACTIVE_HIGH>; > > + gpios-states = <1>; > > + states = <3300000 1 > > + 1800000 0>; > > + }; > > + > > + sdc@1e740000 { > > + compatible = "aspeed,ast2600-sd-controller"; > > + reg = <0x1e740000 0x100>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x1e740000 0x20000>; > > + clocks = <&syscon ASPEED_CLK_GATE_SDCLK>; > > + > > + sdhci0: sdhci@100 { > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > + reg = <0x100 0x100>; > > + interrupts = ; > > + sdhci,auto-cmd12; > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > + vmmc-supply = <&vcc_sdhci0>; > > + vqmmc-supply = <&vccq_sdhci0>; > > + sd-uhs-sdr104; > > + clk-phase-uhs-sdr104 = <180>, <180>; > > + }; > > + > > + sdhci1: sdhci@200 { > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > + reg = <0x200 0x100>; > > + interrupts = ; > > + sdhci,auto-cmd12; > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > + vmmc-supply = <&vcc_sdhci1>; > > + vqmmc-supply = <&vccq_sdhci1>; > > + sd-uhs-sdr104; > > + clk-phase-uhs-sdr104 = <0>, <0>; > > + }; > > + }; > > This is a good example, so can we keep this and just drop the comment > from the binding document? Ok, I will remove the comment. > > Cheers, > > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D06C433ED for ; Mon, 3 May 2021 09:44:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C085611EE for ; Mon, 3 May 2021 09:44:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C085611EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TS0mbhvnWNB/iCYHZAs7hJf/3q0gOhK7QtrqcaIovvg=; b=f2XBYuL9ODhC6bKuUD9HdBR7d Qcy9IahksbkwX9W8FA74E1qbC9ZdASOBRccgOndi+a6WYuYHOqJUOG8soDjg6yj8rRD6258AtU9cE jh1MH24FG6zOPLuow7JOwzZ9JS8yuXQJAHBqDGDwh/b1hoCozOQftfwlS4V9wlGiL0WtetUHq4DBE 5FXJBMJxO03u7kMTEUAni5wYFXRSP7W8VPPdbpICe8DbVKDBRQeeL+T+z4QMz+Cqe/AXYnF7E6VGg d97MN5G6/wgBThI22LMrIUkfwBBXm2JuYPLUWe8IstIon1UpCxs/lkj0I04LyZW8/ZuEg29lnpVqL hdXJCNJ5w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldV5y-00DZC8-5X; Mon, 03 May 2021 09:42:30 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldV5U-00DZ8u-Kr for linux-arm-kernel@desiato.infradead.org; Mon, 03 May 2021 09:42:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=n5QhbLldtRbjuEIdknPA4CBBv0o7fxp4+xyyObDEB1I=; b=Mr6buH7f27tbyJBZUc35RT2Om/ aS1jSz7yfj3vHAZnj5za26frvOED0mym3yODq1GQs+TY6ar8jcVWC5JpbH6/Cjk4dcfWMLZn1l+t4 JaiavpyEe2U5C2/ex7J38erpQ8i5yg9CNQclsEr2Q5tCfy0SeIj3rG/aNYBYHDj9AGyd+FFOJ/JUN xeQM0VZjgb35xN5pw15bkDgWulys1QfJ2leKhZPw4XsFSXUQJk3SciUVHTfyU4ONjAnKNs7uo2jk3 vp9Y/ss85xFJchxjAIQCDxNugdqLHKZHPLfAAG+WRVfj5lsSCmZRzn1S6slV+1MkmSzDM/hObr+Wv 3ADgJLNg==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldV5N-00EuNg-Eq for linux-arm-kernel@lists.infradead.org; Mon, 03 May 2021 09:41:59 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1439TKIo029925; Mon, 3 May 2021 17:29:20 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 May 2021 17:40:58 +0800 Date: Mon, 3 May 2021 17:40:55 +0800 From: Steven Lee To: Andrew Jeffery CC: Ulf Hansson , Rob Herring , Joel Stanley , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Hongwei Zhang , Ryan Chen , Chin-Ting Kuo Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: sdhci-of-aspeed: Add description for AST2600 EVB. Message-ID: <20210503094054.GA12520@aspeedtech.com> References: <20210503014336.20256-1-steven_lee@aspeedtech.com> <20210503014336.20256-2-steven_lee@aspeedtech.com> <75226402-503c-4e9b-96dc-e4bd74cf20ac@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <75226402-503c-4e9b-96dc-e4bd74cf20ac@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1439TKIo029925 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210503_104156_788365_68100B05 X-CRM114-Status: GOOD ( 31.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 05/03/2021 12:19, Andrew Jeffery wrote: > Hi Steven, > > On Mon, 3 May 2021, at 11:13, Steven Lee wrote: > > Add the description for describing the AST 2600 EVB reference design of > > GPIO regulators and provide the example in the document. > > > > AST2600-A2 EVB has the reference design for enabling SD bus > > power and toggling SD bus signal voltage by GPIO pins. > > > > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to > > power load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is > > connected to a 1.8v and a 3.3v power load switch that providing > > signal voltage to > > SD1 bus. > > > > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > disabled. > > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 > > signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > enabled, SD1 signal voltage becomes 1.8v. > > > > AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > GPIOV3 as power-switch-gpio. > > > > Signed-off-by: Steven Lee > > --- > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 99 +++++++++++++++++++ > > 1 file changed, 99 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > index 987b287f3bff..dd894aba0bb7 100644 > > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > @@ -20,6 +20,19 @@ description: |+ > > the slots are dependent on the common configuration area, they are > > described > > as child nodes. > > > > + The signal voltage of SDHCIs on AST2600-A2 EVB is able to be toggled > > by GPIO > > + pins. In the reference design, GPIOV0 of AST2600-A2 EVB is connected > > to the > > + power load switch that providing 3.3v to SD1 bus vdd, GPIOV1 is > > connected to > > + a 1.8v and a 3.3v power load switch that providing signal voltage to > > + SD1 bus. > > + If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > + disabled. If GPIOV1 is active high, 3.3v power load switch is > > enabled, SD1 > > + signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > enabled, SD1 > > + signal voltage becomes 1.8v. > > + AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > + The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > GPIOV3 > > + as power-switch-gpio. > > I don't think we should be describing design-specific details in the > binding document. However, I think this would be a great comment in the > AST2600 EVB devicetree. Can you please move it there? > Ok, I will move it to the device tree. I was wondering if the following place is a good place to put the comment at line 534 of aspeed-g6.dtsi sdc: sdc@1e740000 { // Comment here... compatible = "aspeed,ast2600-sd-controller"; reg = <0x1e740000 0x100>; sdhci0: sdhci@1e740100 { compatible = "aspeed,ast2600-sdhci", "sdhci"; reg = <0x100 0x100>; interrupts = ; ... } > > + > > properties: > > compatible: > > enum: > > @@ -78,6 +91,7 @@ required: > > - clocks > > > > examples: > > + //Example 1 > > - | > > #include > > sdc@1e740000 { > > @@ -104,3 +118,88 @@ examples: > > clocks = <&syscon ASPEED_CLK_SDIO>; > > }; > > }; > > + > > + //Example 2 (AST2600EVB with GPIO regulator) > > I feel you didn't test this with `make dt_binding_check` as `//` isn't > a valid YAML comment token. You need to use `#` for comments ( > https://yaml.org/spec/1.2/spec.html#id2780069 ). > Sorry, I don't know that there is a binding check command for valiating YAML document. Regardless, thanks for the reference link. I will test with dt_binding_check. > > + - | > > + #include > > + #include > > + vcc_sdhci0: regulator-vcc-sdhci0 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "SDHCI0 Vcc"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 0) > > + GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + }; > > + > > + vccq_sdhci0: regulator-vccq-sdhci0 { > > + compatible = "regulator-gpio"; > > + > > + regulator-name = "SDHCI0 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 1) > > + GPIO_ACTIVE_HIGH>; > > + gpios-states = <1>; > > + states = <3300000 1 > > + 1800000 0>; > > + }; > > + > > + vcc_sdhci1: regulator-vcc-sdhci1 { > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "SDHCI1 Vcc"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 2) > > + GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + }; > > + > > + vccq_sdhci1: regulator-vccq-sdhci1 { > > + compatible = "regulator-gpio"; > > + > > + regulator-name = "SDHCI1 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&gpio0 ASPEED_GPIO(V, 3) > > + GPIO_ACTIVE_HIGH>; > > + gpios-states = <1>; > > + states = <3300000 1 > > + 1800000 0>; > > + }; > > + > > + sdc@1e740000 { > > + compatible = "aspeed,ast2600-sd-controller"; > > + reg = <0x1e740000 0x100>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x1e740000 0x20000>; > > + clocks = <&syscon ASPEED_CLK_GATE_SDCLK>; > > + > > + sdhci0: sdhci@100 { > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > + reg = <0x100 0x100>; > > + interrupts = ; > > + sdhci,auto-cmd12; > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > + vmmc-supply = <&vcc_sdhci0>; > > + vqmmc-supply = <&vccq_sdhci0>; > > + sd-uhs-sdr104; > > + clk-phase-uhs-sdr104 = <180>, <180>; > > + }; > > + > > + sdhci1: sdhci@200 { > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > + reg = <0x200 0x100>; > > + interrupts = ; > > + sdhci,auto-cmd12; > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > + vmmc-supply = <&vcc_sdhci1>; > > + vqmmc-supply = <&vccq_sdhci1>; > > + sd-uhs-sdr104; > > + clk-phase-uhs-sdr104 = <0>, <0>; > > + }; > > + }; > > This is a good example, so can we keep this and just drop the comment > from the binding document? Ok, I will remove the comment. > > Cheers, > > Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel