From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B045C433B4 for ; Mon, 3 May 2021 17:01:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 254EE61075 for ; Mon, 3 May 2021 17:01:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 254EE61075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A243A1689; Mon, 3 May 2021 19:00:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A243A1689 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1620061300; bh=IoqGH1xRzhuiYK3opt++hOa29dkSpz07yip1I3JB3vg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ABxzwEoIYMhWl0uS91MOEDIWbyPGF+xUfWRUuwTSfhLcA49wq/5OT2zfvZcGEnErH q4ZqT15Qr/+LfOhMgR7LIyukvNR32MQyGuRIDUerjfMNXCypgP9XBLqC0sFXXHaQ1X dOcrazV8mPAqfJ9Dfdoa8+6zrNAO0rRN2+jhU7w8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 34C37F80257; Mon, 3 May 2021 19:00:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EFFA2F8025F; Mon, 3 May 2021 19:00:43 +0200 (CEST) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7235BF80111 for ; Mon, 3 May 2021 19:00:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7235BF80111 Received: by mail-ot1-f53.google.com with SMTP id x54-20020a05683040b6b02902a527443e2fso5707183ott.1 for ; Mon, 03 May 2021 10:00:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MpWS97nnXbRs49r1fForFBwiCI3FlCAOFGO2IucCbgI=; b=pkz2X5IWj3D2HvZ0fFFeW0mXqkBFmbsZUBFOpVQcQjk54i2YF+4KX7WOAG63VpQiY7 TdJimjwi6CE7z1wqVrBJewQYE8i6CuvfyDJEFtZEsLHUHmSDzXJA3xiK+2KxiSvy/1JL 8OxwzeZ2GrcFSiOAszlaftJjC3BhgQLPbJcaCukbUcG7zWGC9rwz4mmno1kxbq5w9h+O UiA42DX7LlmvIKaxxh0ccf2tftzckhjG76z0FPzNm+YWCE8OeGJJzi5M9Zt8FA3J1oOD dYas9aGu/A3ZQ3iGLbBEI4JBcNAT8JpCEsLU6OmLmkjKavShFUtj5tN26C67VT1vtwp7 S0lA== X-Gm-Message-State: AOAM532CRPdMtu3FJRgiZsszwOG6XypdZS1waZuEtORpljqPs287D0L1 EMB3Pv6rilOn0bDHYNGvxg== X-Google-Smtp-Source: ABdhPJz3axdorHwGCwuPSEqF9Bw80gZAqMDgQOmNpRuGn93hjcvSZSCtx5vibHriB9CdGrpMOJJZig== X-Received: by 2002:a9d:7085:: with SMTP id l5mr15416541otj.345.1620061233291; Mon, 03 May 2021 10:00:33 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t25sm71651oic.23.2021.05.03.10.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 10:00:32 -0700 (PDT) Received: (nullmailer pid 2008247 invoked by uid 1000); Mon, 03 May 2021 17:00:30 -0000 Date: Mon, 3 May 2021 12:00:30 -0500 From: Rob Herring To: Shengjiu Wang Subject: Re: [PATCH 2/2] ASoC: dt-bindings: imx-akcodec: Add binding doc for akcodec machine driver Message-ID: <20210503170030.GA1987906@robh.at.kernel.org> References: <1619157107-3734-1-git-send-email-shengjiu.wang@nxp.com> <1619157107-3734-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619157107-3734-2-git-send-email-shengjiu.wang@nxp.com> Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, linuxppc-dev@lists.ozlabs.org, tiwai@suse.com, lgirdwood@gmail.com, nicoleotsuka@gmail.com, broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Apr 23, 2021 at 01:51:47PM +0800, Shengjiu Wang wrote: > Imx-akcodec is a new added machine driver for supporting > ak4458/ak5558/ak5552/ak4497 codec on i.MX platforms. > > Signed-off-by: Shengjiu Wang > --- > .../bindings/sound/imx-audio-akcodec.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > new file mode 100644 > index 000000000000..7419bf7224e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/imx-audio-akcodec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX audio complex with AK4458/AK5558/AK5552/AK4497 codec Looks like the existing fsl-asoc-card.txt? You should convert to schema and use that. Otherwise, my comments are based on this all being 'new'. > + > +maintainers: > + - Shengjiu Wang > + > +properties: > + compatible: > + enum: > + - fsl,imx8mq-audio-ak4458 > + - fsl,imx8mq-audio-ak4497 > + - fsl,imx8mq-audio-ak5558 > + - fsl,imx-audio-ak4497 > + - fsl,imx-audio-ak4458 > + - fsl,imx-audio-ak5558 > + - fsl,imx-audio-ak5552 I continue to not understand why audio bindings need the codec(s) in the compatible strings. Can't you look up the codec thru the audio-codec property? > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + audio-cpu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of a CPU DAI controller > + > + audio-codec: > + description: The phandle of Codec DAI controllers, there are two > + controllers maximum. We have the common 'sound-dai' property. See the simple-card.yaml binding. > + > + audio-asrc: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of ASRC. It can be absent if there's no > + need to add ASRC support via DPCM. Needs a vendor prefix. > + > + fsl,tdm: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + This is a boolean property. If present, the TDM mode is enabled. But this one seems like something that could or should be common. > + > +required: > + - compatible > + - model > + - audio-cpu > + - audio-codec > + > +additionalProperties: false > + > +examples: > + - | > + sound-ak4458 { > + compatible = "fsl,imx-audio-ak4458"; > + model = "ak4458-audio"; > + audio-cpu = <&sai1>; > + audio-codec = <&ak4458_1>, <&ak4458_2>; > + }; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861AFC433B4 for ; Mon, 3 May 2021 17:01:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAE9960230 for ; Mon, 3 May 2021 17:01:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAE9960230 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FYq4D6mkJz2yxP for ; Tue, 4 May 2021 03:01:00 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.44; helo=mail-ot1-f44.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FYq3n6ppMz2xZS for ; Tue, 4 May 2021 03:00:35 +1000 (AEST) Received: by mail-ot1-f44.google.com with SMTP id 92-20020a9d02e50000b029028fcc3d2c9eso5733354otl.0 for ; Mon, 03 May 2021 10:00:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MpWS97nnXbRs49r1fForFBwiCI3FlCAOFGO2IucCbgI=; b=pNArBc/IyPC6U+fhHzSnU8Tz2Gc5Nk6HyHJd47HMa0mztCkrWsGp4qs8r+EJVmcVcp RSXfvx64Terzg0rklXjJdNXpVdOOmyGZTQ4lCauDbDoJtwuhfOtS9uZ93Mtbt6mTok1n ikfy5BBYf5ho3gR6fIZoFB7XOFDOMKfj6J4cqlq/Dp6iLyLLJ54AhyS0PU4UcxgOnQJa 2Gww+/33TBE7yAaltEulrLXmrprEL/mgoWGfgAyr14UX6i6dcg0lfxJ9Af7vdx4ES53Q KZvkJXzkOtQIxqw95ywaOVi9G/LfQ0ie/zbVG098upC7anDa+cMNc3hZVd9EfjEFxuCd xTgg== X-Gm-Message-State: AOAM5317QvMPm6uWEfQuX8Iwr1LhEdf8VvdjwqX/9e8bTs0Jamz/jq2X SGNs4v6MewYsBnuhQ/Ki1Q== X-Google-Smtp-Source: ABdhPJz3axdorHwGCwuPSEqF9Bw80gZAqMDgQOmNpRuGn93hjcvSZSCtx5vibHriB9CdGrpMOJJZig== X-Received: by 2002:a9d:7085:: with SMTP id l5mr15416541otj.345.1620061233291; Mon, 03 May 2021 10:00:33 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t25sm71651oic.23.2021.05.03.10.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 10:00:32 -0700 (PDT) Received: (nullmailer pid 2008247 invoked by uid 1000); Mon, 03 May 2021 17:00:30 -0000 Date: Mon, 3 May 2021 12:00:30 -0500 From: Rob Herring To: Shengjiu Wang Subject: Re: [PATCH 2/2] ASoC: dt-bindings: imx-akcodec: Add binding doc for akcodec machine driver Message-ID: <20210503170030.GA1987906@robh.at.kernel.org> References: <1619157107-3734-1-git-send-email-shengjiu.wang@nxp.com> <1619157107-3734-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619157107-3734-2-git-send-email-shengjiu.wang@nxp.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, linuxppc-dev@lists.ozlabs.org, tiwai@suse.com, lgirdwood@gmail.com, nicoleotsuka@gmail.com, broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, perex@perex.cz, festevam@gmail.com, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Apr 23, 2021 at 01:51:47PM +0800, Shengjiu Wang wrote: > Imx-akcodec is a new added machine driver for supporting > ak4458/ak5558/ak5552/ak4497 codec on i.MX platforms. > > Signed-off-by: Shengjiu Wang > --- > .../bindings/sound/imx-audio-akcodec.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > new file mode 100644 > index 000000000000..7419bf7224e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/imx-audio-akcodec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX audio complex with AK4458/AK5558/AK5552/AK4497 codec Looks like the existing fsl-asoc-card.txt? You should convert to schema and use that. Otherwise, my comments are based on this all being 'new'. > + > +maintainers: > + - Shengjiu Wang > + > +properties: > + compatible: > + enum: > + - fsl,imx8mq-audio-ak4458 > + - fsl,imx8mq-audio-ak4497 > + - fsl,imx8mq-audio-ak5558 > + - fsl,imx-audio-ak4497 > + - fsl,imx-audio-ak4458 > + - fsl,imx-audio-ak5558 > + - fsl,imx-audio-ak5552 I continue to not understand why audio bindings need the codec(s) in the compatible strings. Can't you look up the codec thru the audio-codec property? > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + audio-cpu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of a CPU DAI controller > + > + audio-codec: > + description: The phandle of Codec DAI controllers, there are two > + controllers maximum. We have the common 'sound-dai' property. See the simple-card.yaml binding. > + > + audio-asrc: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of ASRC. It can be absent if there's no > + need to add ASRC support via DPCM. Needs a vendor prefix. > + > + fsl,tdm: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + This is a boolean property. If present, the TDM mode is enabled. But this one seems like something that could or should be common. > + > +required: > + - compatible > + - model > + - audio-cpu > + - audio-codec > + > +additionalProperties: false > + > +examples: > + - | > + sound-ak4458 { > + compatible = "fsl,imx-audio-ak4458"; > + model = "ak4458-audio"; > + audio-cpu = <&sai1>; > + audio-codec = <&ak4458_1>, <&ak4458_2>; > + }; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D22C43460 for ; Mon, 3 May 2021 17:02:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C66DC61075 for ; Mon, 3 May 2021 17:02:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C66DC61075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lCW38EPFgyiBwsh4P5OGID+iJtMnY4dlGhFwrR+Tgl8=; b=Iq3gJCZCfJ9DZRyfc2d3K1r0V 0+F4PMofhK32UHzl8l1pD95OscGbaeSToPBxNUqJAUX7GYOsC+mQDua/46jDu7tubSNfhdCBc4Lj/ CfAtZPFremHGpPOGtljNeHgRfinjcmJsvYCLLSxOr1opGHUWcTyq/txFMuIE1myLzfXAhFS9aXnlv Ii0BXVVjaMbNeorLJXFhh1R17V/+cKk8YwcSadkeh1jcefmbqPkdSSlPbyTv4wq48eyqRJ1Rxgyhx zOnf9JQLVB2rDRMZC6FJY4FWJdVwxoUQFYaDy3p49LDDhWH5TLhByDvvAEX+35jbB0ncdedDVqT3h WgnQDRxRA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldbw1-00ET7W-GM; Mon, 03 May 2021 17:00:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldbvx-00ET79-2P for linux-arm-kernel@desiato.infradead.org; Mon, 03 May 2021 17:00:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MpWS97nnXbRs49r1fForFBwiCI3FlCAOFGO2IucCbgI=; b=ErTc5joPeGmIWZ+6XC+WiPFwxx GL3o0lxzs6DaJESqmHaq7e6HXHnJwDfQ4SLB9T+KQ36sXZwkMeGodyZkagy3KNDYvz5wJZr2iAPjx YXyMRPoNEPxiehZ5RwbZJ1gLtt7R2wYpyRJlWmfaop1110iAnaZ5SLTuLNKsIoIOnSSazg5FYw/PC MIARwk3FHTddWkQNzLk7CwXMcBuJWZ7ZSNEE+nTIOCFTWh49FYsL9k4ep8oqUMF8m5cqWguWtALzD mKz7GsMgQB7jnf7f/70wfGYe3zLgLtrjLtHpJsTkVD53jqWlDOVE4wspRPepisj06gkkujQWXsbPR cWsXfB4g==; Received: from mail-ot1-f54.google.com ([209.85.210.54]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldbvt-003JXc-V2 for linux-arm-kernel@lists.infradead.org; Mon, 03 May 2021 17:00:35 +0000 Received: by mail-ot1-f54.google.com with SMTP id d3-20020a9d29030000b029027e8019067fso5654996otb.13 for ; Mon, 03 May 2021 10:00:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MpWS97nnXbRs49r1fForFBwiCI3FlCAOFGO2IucCbgI=; b=loJjmaTTL7mw4DuhGwyFlhtFWMzifa6Vs/opBAw4XELNmjQBEezng+PuArA1EJnnlO ViVHfFeMJEFqjQ+lCow5yVuuUCUZBDVAfydz1ttwRVuijtZoCUwAze2AVym0v9EmlPZG n13lb17rf5MBicOH8GY65z+mh9aRn7gfvk+sD9TTNk3GGD6GZKQD+R8Wit/SADMAoHv7 UWw6mI2CwKb5Ry/3lGgIfaYJ8izRWNi4XW8+tvGIbaXVl0QUE4ydb6IuFk92V0WwvhYh cOU+R9DNs7mx81CDZCAjTXuCC/Qq4jjrmI8VFtvYIRjLE4jLFXHYdcozGrGD1GDKJVlz UkNw== X-Gm-Message-State: AOAM5312nma+AKuzUEW00BqiCtUmFSjgq+YVLdGZ9oTXEMztHUvrjgh/ NHBAtX7SiWppdmJ3M5samw== X-Google-Smtp-Source: ABdhPJz3axdorHwGCwuPSEqF9Bw80gZAqMDgQOmNpRuGn93hjcvSZSCtx5vibHriB9CdGrpMOJJZig== X-Received: by 2002:a9d:7085:: with SMTP id l5mr15416541otj.345.1620061233291; Mon, 03 May 2021 10:00:33 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t25sm71651oic.23.2021.05.03.10.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 10:00:32 -0700 (PDT) Received: (nullmailer pid 2008247 invoked by uid 1000); Mon, 03 May 2021 17:00:30 -0000 Date: Mon, 3 May 2021 12:00:30 -0500 From: Rob Herring To: Shengjiu Wang Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/2] ASoC: dt-bindings: imx-akcodec: Add binding doc for akcodec machine driver Message-ID: <20210503170030.GA1987906@robh.at.kernel.org> References: <1619157107-3734-1-git-send-email-shengjiu.wang@nxp.com> <1619157107-3734-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1619157107-3734-2-git-send-email-shengjiu.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210503_100034_046177_DC9C67E1 X-CRM114-Status: GOOD ( 23.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 23, 2021 at 01:51:47PM +0800, Shengjiu Wang wrote: > Imx-akcodec is a new added machine driver for supporting > ak4458/ak5558/ak5552/ak4497 codec on i.MX platforms. > > Signed-off-by: Shengjiu Wang > --- > .../bindings/sound/imx-audio-akcodec.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > new file mode 100644 > index 000000000000..7419bf7224e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/imx-audio-akcodec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX audio complex with AK4458/AK5558/AK5552/AK4497 codec Looks like the existing fsl-asoc-card.txt? You should convert to schema and use that. Otherwise, my comments are based on this all being 'new'. > + > +maintainers: > + - Shengjiu Wang > + > +properties: > + compatible: > + enum: > + - fsl,imx8mq-audio-ak4458 > + - fsl,imx8mq-audio-ak4497 > + - fsl,imx8mq-audio-ak5558 > + - fsl,imx-audio-ak4497 > + - fsl,imx-audio-ak4458 > + - fsl,imx-audio-ak5558 > + - fsl,imx-audio-ak5552 I continue to not understand why audio bindings need the codec(s) in the compatible strings. Can't you look up the codec thru the audio-codec property? > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + audio-cpu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of a CPU DAI controller > + > + audio-codec: > + description: The phandle of Codec DAI controllers, there are two > + controllers maximum. We have the common 'sound-dai' property. See the simple-card.yaml binding. > + > + audio-asrc: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of ASRC. It can be absent if there's no > + need to add ASRC support via DPCM. Needs a vendor prefix. > + > + fsl,tdm: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + This is a boolean property. If present, the TDM mode is enabled. But this one seems like something that could or should be common. > + > +required: > + - compatible > + - model > + - audio-cpu > + - audio-codec > + > +additionalProperties: false > + > +examples: > + - | > + sound-ak4458 { > + compatible = "fsl,imx-audio-ak4458"; > + model = "ak4458-audio"; > + audio-cpu = <&sai1>; > + audio-codec = <&ak4458_1>, <&ak4458_2>; > + }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 458BEC433B4 for ; Mon, 3 May 2021 17:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16C856101A for ; Mon, 3 May 2021 17:02:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234953AbhECRDK (ORCPT ); Mon, 3 May 2021 13:03:10 -0400 Received: from mail-ot1-f47.google.com ([209.85.210.47]:37421 "EHLO mail-ot1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232549AbhECRB2 (ORCPT ); Mon, 3 May 2021 13:01:28 -0400 Received: by mail-ot1-f47.google.com with SMTP id c8-20020a9d78480000b0290289e9d1b7bcso5700093otm.4; Mon, 03 May 2021 10:00:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MpWS97nnXbRs49r1fForFBwiCI3FlCAOFGO2IucCbgI=; b=jKXIcz2msfofi3MX/6abqXQg7sXsaHLO/ycEbBYga/2/Odtv1sltaZlGi8kO5tdCto LtAUkU7cJkjm/PHxpInb60pU8NVT5GnpAnhutVjR/FLgw/khNtPFyJZg+IiLEy27HuI7 kdM5breokilINsN0PzKOthGlxF9vgDTGsR2Ie67JPMJvimxdE9Fsl/ng4N9zfpVV6vnV YSdJpBFoWVKneu32IahclfUnM61YAPYkJ4aVdJ/miq//gPfY5nuF0Lwy3kq1FwN18nbU xIMA0vZmB2vkZ41wt07Z325ReCz/AiYU4Fxe9JEqQ4XyW8Yq1v6wTUZ8ZtO3pm15K1up mgyA== X-Gm-Message-State: AOAM533lsExUoUJtSPlHxtpnQEiazPNJkaeyy36OqOjYco6SOFeYQNNT pX69mHD4zKMBSeu/9mA+uw== X-Google-Smtp-Source: ABdhPJz3axdorHwGCwuPSEqF9Bw80gZAqMDgQOmNpRuGn93hjcvSZSCtx5vibHriB9CdGrpMOJJZig== X-Received: by 2002:a9d:7085:: with SMTP id l5mr15416541otj.345.1620061233291; Mon, 03 May 2021 10:00:33 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t25sm71651oic.23.2021.05.03.10.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 10:00:32 -0700 (PDT) Received: (nullmailer pid 2008247 invoked by uid 1000); Mon, 03 May 2021 17:00:30 -0000 Date: Mon, 3 May 2021 12:00:30 -0500 From: Rob Herring To: Shengjiu Wang Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/2] ASoC: dt-bindings: imx-akcodec: Add binding doc for akcodec machine driver Message-ID: <20210503170030.GA1987906@robh.at.kernel.org> References: <1619157107-3734-1-git-send-email-shengjiu.wang@nxp.com> <1619157107-3734-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619157107-3734-2-git-send-email-shengjiu.wang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Apr 23, 2021 at 01:51:47PM +0800, Shengjiu Wang wrote: > Imx-akcodec is a new added machine driver for supporting > ak4458/ak5558/ak5552/ak4497 codec on i.MX platforms. > > Signed-off-by: Shengjiu Wang > --- > .../bindings/sound/imx-audio-akcodec.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > new file mode 100644 > index 000000000000..7419bf7224e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/imx-audio-akcodec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX audio complex with AK4458/AK5558/AK5552/AK4497 codec Looks like the existing fsl-asoc-card.txt? You should convert to schema and use that. Otherwise, my comments are based on this all being 'new'. > + > +maintainers: > + - Shengjiu Wang > + > +properties: > + compatible: > + enum: > + - fsl,imx8mq-audio-ak4458 > + - fsl,imx8mq-audio-ak4497 > + - fsl,imx8mq-audio-ak5558 > + - fsl,imx-audio-ak4497 > + - fsl,imx-audio-ak4458 > + - fsl,imx-audio-ak5558 > + - fsl,imx-audio-ak5552 I continue to not understand why audio bindings need the codec(s) in the compatible strings. Can't you look up the codec thru the audio-codec property? > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + audio-cpu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of a CPU DAI controller > + > + audio-codec: > + description: The phandle of Codec DAI controllers, there are two > + controllers maximum. We have the common 'sound-dai' property. See the simple-card.yaml binding. > + > + audio-asrc: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of ASRC. It can be absent if there's no > + need to add ASRC support via DPCM. Needs a vendor prefix. > + > + fsl,tdm: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + This is a boolean property. If present, the TDM mode is enabled. But this one seems like something that could or should be common. > + > +required: > + - compatible > + - model > + - audio-cpu > + - audio-codec > + > +additionalProperties: false > + > +examples: > + - | > + sound-ak4458 { > + compatible = "fsl,imx-audio-ak4458"; > + model = "ak4458-audio"; > + audio-cpu = <&sai1>; > + audio-codec = <&ak4458_1>, <&ak4458_2>; > + }; > -- > 2.17.1 >