From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E9E6C433ED for ; Tue, 4 May 2021 13:01:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26355613BC for ; Tue, 4 May 2021 13:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230373AbhEDNB5 (ORCPT ); Tue, 4 May 2021 09:01:57 -0400 Received: from 1.mo52.mail-out.ovh.net ([178.32.96.117]:38359 "EHLO 1.mo52.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230434AbhEDNB4 (ORCPT ); Tue, 4 May 2021 09:01:56 -0400 X-Greylist: delayed 2296 seconds by postgrey-1.27 at vger.kernel.org; Tue, 04 May 2021 09:01:56 EDT Received: from mxplan5.mail.ovh.net (unknown [10.108.4.240]) by mo52.mail-out.ovh.net (Postfix) with ESMTPS id CD06B275188; Tue, 4 May 2021 14:22:40 +0200 (CEST) Received: from kaod.org (37.59.142.101) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 4 May 2021 14:22:38 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-101G0043eda4e7a-de7c-4853-8406-edae349cf2a7, 233BADB9E061AA125F593C9F78707CF28220F307) smtp.auth=groug@kaod.org X-OVh-ClientIp: 78.197.208.248 Date: Tue, 4 May 2021 14:22:36 +0200 From: Greg Kurz To: Christoph Hellwig CC: Michael Ellerman , Alex Williamson , Jason Gunthorpe , , David Airlie , , , "Paul Mackerras" , Daniel Vetter , "Greg Kroah-Hartman" , , , , Subject: Re: remove the nvlink2 pci_vfio subdriver v2 Message-ID: <20210504142236.76994047@bahia.lan> In-Reply-To: <20210326061311.1497642-1-hch@lst.de> References: <20210326061311.1497642-1-hch@lst.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.101] X-ClientProxiedBy: DAG5EX1.mxp5.local (172.16.2.41) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: 316f1bea-914e-41ab-a4e8-46202395b6d3 X-Ovh-Tracer-Id: 4363706565853223297 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrvdefiedgheefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfhisehtjeeftdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeetgffffffggfekgeffteekhffhueelffdvhedvgfdthfeiudetvddulefgveevteenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdhpphgtsehnohhnghhnuhdrohhrgh Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Fri, 26 Mar 2021 07:13:09 +0100 Christoph Hellwig wrote: > Hi all, > > the nvlink2 vfio subdriver is a weird beast. It supports a hardware > feature without any open source component - what would normally be > the normal open source userspace that we require for kernel drivers, > although in this particular case user space could of course be a > kernel driver in a VM. It also happens to be a complete mess that > does not properly bind to PCI IDs, is hacked into the vfio_pci driver > and also pulles in over 1000 lines of code always build into powerpc > kernels that have Power NV support enabled. Because of all these > issues and the lack of breaking userspace when it is removed I think > the best idea is to simply kill. > > Changes since v1: > - document the removed subtypes as reserved > - add the ACK from Greg > > Diffstat: > arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- > b/arch/powerpc/include/asm/opal.h | 3 > b/arch/powerpc/include/asm/pci-bridge.h | 1 > b/arch/powerpc/include/asm/pci.h | 7 > b/arch/powerpc/platforms/powernv/Makefile | 2 > b/arch/powerpc/platforms/powernv/opal-call.c | 2 > b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- > b/arch/powerpc/platforms/powernv/pci.c | 11 > b/arch/powerpc/platforms/powernv/pci.h | 17 > b/arch/powerpc/platforms/pseries/pci.c | 23 > b/drivers/vfio/pci/Kconfig | 6 > b/drivers/vfio/pci/Makefile | 1 > b/drivers/vfio/pci/vfio_pci.c | 18 > b/drivers/vfio/pci/vfio_pci_private.h | 14 > b/include/uapi/linux/vfio.h | 38 - Hi Christoph, FYI, these uapi changes break build of QEMU. I guess QEMU people should take some action before this percolates to the QEMU source tree. Cc'ing relevant QEMU lists to bring the discussion there. Cheers, -- Greg > drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------ > 16 files changed, 12 insertions(+), 1511 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC88C433ED for ; Tue, 4 May 2021 12:41:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27E0D613B4 for ; Tue, 4 May 2021 12:41:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27E0D613B4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FZKFq51kZz30D9 for ; Tue, 4 May 2021 22:41:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kaod.org (client-ip=178.33.254.192; helo=3.mo52.mail-out.ovh.net; envelope-from=groug@kaod.org; receiver=) X-Greylist: delayed 1070 seconds by postgrey-1.36 at boromir; Tue, 04 May 2021 22:40:40 AEST Received: from 3.mo52.mail-out.ovh.net (3.mo52.mail-out.ovh.net [178.33.254.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FZKFN0LV4z2yRK for ; Tue, 4 May 2021 22:40:37 +1000 (AEST) Received: from mxplan5.mail.ovh.net (unknown [10.108.4.240]) by mo52.mail-out.ovh.net (Postfix) with ESMTPS id CD06B275188; Tue, 4 May 2021 14:22:40 +0200 (CEST) Received: from kaod.org (37.59.142.101) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 4 May 2021 14:22:38 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-101G0043eda4e7a-de7c-4853-8406-edae349cf2a7, 233BADB9E061AA125F593C9F78707CF28220F307) smtp.auth=groug@kaod.org X-OVh-ClientIp: 78.197.208.248 Date: Tue, 4 May 2021 14:22:36 +0200 From: Greg Kurz To: Christoph Hellwig Subject: Re: remove the nvlink2 pci_vfio subdriver v2 Message-ID: <20210504142236.76994047@bahia.lan> In-Reply-To: <20210326061311.1497642-1-hch@lst.de> References: <20210326061311.1497642-1-hch@lst.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.101] X-ClientProxiedBy: DAG5EX1.mxp5.local (172.16.2.41) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: 316f1bea-914e-41ab-a4e8-46202395b6d3 X-Ovh-Tracer-Id: 4363706565853223297 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrvdefiedgheefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfhisehtjeeftdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeetgffffffggfekgeffteekhffhueelffdvhedvgfdthfeiudetvddulefgveevteenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdhpphgtsehnohhnghhnuhdrohhrgh X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , kvm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, qemu-devel@nongnu.org, Alex Williamson , Paul Mackerras , Jason Gunthorpe , Greg Kroah-Hartman , qemu-ppc@nongnu.org, linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 26 Mar 2021 07:13:09 +0100 Christoph Hellwig wrote: > Hi all, > > the nvlink2 vfio subdriver is a weird beast. It supports a hardware > feature without any open source component - what would normally be > the normal open source userspace that we require for kernel drivers, > although in this particular case user space could of course be a > kernel driver in a VM. It also happens to be a complete mess that > does not properly bind to PCI IDs, is hacked into the vfio_pci driver > and also pulles in over 1000 lines of code always build into powerpc > kernels that have Power NV support enabled. Because of all these > issues and the lack of breaking userspace when it is removed I think > the best idea is to simply kill. > > Changes since v1: > - document the removed subtypes as reserved > - add the ACK from Greg > > Diffstat: > arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- > b/arch/powerpc/include/asm/opal.h | 3 > b/arch/powerpc/include/asm/pci-bridge.h | 1 > b/arch/powerpc/include/asm/pci.h | 7 > b/arch/powerpc/platforms/powernv/Makefile | 2 > b/arch/powerpc/platforms/powernv/opal-call.c | 2 > b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- > b/arch/powerpc/platforms/powernv/pci.c | 11 > b/arch/powerpc/platforms/powernv/pci.h | 17 > b/arch/powerpc/platforms/pseries/pci.c | 23 > b/drivers/vfio/pci/Kconfig | 6 > b/drivers/vfio/pci/Makefile | 1 > b/drivers/vfio/pci/vfio_pci.c | 18 > b/drivers/vfio/pci/vfio_pci_private.h | 14 > b/include/uapi/linux/vfio.h | 38 - Hi Christoph, FYI, these uapi changes break build of QEMU. I guess QEMU people should take some action before this percolates to the QEMU source tree. Cc'ing relevant QEMU lists to bring the discussion there. Cheers, -- Greg > drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------ > 16 files changed, 12 insertions(+), 1511 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA1AC43461 for ; Tue, 4 May 2021 16:49:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 205CB61177 for ; Tue, 4 May 2021 16:49:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 205CB61177 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 670A66EB33; Tue, 4 May 2021 16:49:51 +0000 (UTC) Received: from 8.mo52.mail-out.ovh.net (8.mo52.mail-out.ovh.net [46.105.37.156]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47C996EB18 for ; Tue, 4 May 2021 14:50:41 +0000 (UTC) Received: from mxplan5.mail.ovh.net (unknown [10.108.4.240]) by mo52.mail-out.ovh.net (Postfix) with ESMTPS id CD06B275188; Tue, 4 May 2021 14:22:40 +0200 (CEST) Received: from kaod.org (37.59.142.101) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 4 May 2021 14:22:38 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-101G0043eda4e7a-de7c-4853-8406-edae349cf2a7, 233BADB9E061AA125F593C9F78707CF28220F307) smtp.auth=groug@kaod.org X-OVh-ClientIp: 78.197.208.248 Date: Tue, 4 May 2021 14:22:36 +0200 From: Greg Kurz To: Christoph Hellwig Subject: Re: remove the nvlink2 pci_vfio subdriver v2 Message-ID: <20210504142236.76994047@bahia.lan> In-Reply-To: <20210326061311.1497642-1-hch@lst.de> References: <20210326061311.1497642-1-hch@lst.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Originating-IP: [37.59.142.101] X-ClientProxiedBy: DAG5EX1.mxp5.local (172.16.2.41) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: 316f1bea-914e-41ab-a4e8-46202395b6d3 X-Ovh-Tracer-Id: 4363706565853223297 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrvdefiedgheefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfhisehtjeeftdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeetgffffffggfekgeffteekhffhueelffdvhedvgfdthfeiudetvddulefgveevteenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdhpphgtsehnohhnghhnuhdrohhrgh X-Mailman-Approved-At: Tue, 04 May 2021 16:49:47 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Airlie , Michael Ellerman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, qemu-devel@nongnu.org, Alex Williamson , Paul Mackerras , Jason Gunthorpe , Greg Kroah-Hartman , qemu-ppc@nongnu.org, linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 26 Mar 2021 07:13:09 +0100 Christoph Hellwig wrote: > Hi all, > > the nvlink2 vfio subdriver is a weird beast. It supports a hardware > feature without any open source component - what would normally be > the normal open source userspace that we require for kernel drivers, > although in this particular case user space could of course be a > kernel driver in a VM. It also happens to be a complete mess that > does not properly bind to PCI IDs, is hacked into the vfio_pci driver > and also pulles in over 1000 lines of code always build into powerpc > kernels that have Power NV support enabled. Because of all these > issues and the lack of breaking userspace when it is removed I think > the best idea is to simply kill. > > Changes since v1: > - document the removed subtypes as reserved > - add the ACK from Greg > > Diffstat: > arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- > b/arch/powerpc/include/asm/opal.h | 3 > b/arch/powerpc/include/asm/pci-bridge.h | 1 > b/arch/powerpc/include/asm/pci.h | 7 > b/arch/powerpc/platforms/powernv/Makefile | 2 > b/arch/powerpc/platforms/powernv/opal-call.c | 2 > b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- > b/arch/powerpc/platforms/powernv/pci.c | 11 > b/arch/powerpc/platforms/powernv/pci.h | 17 > b/arch/powerpc/platforms/pseries/pci.c | 23 > b/drivers/vfio/pci/Kconfig | 6 > b/drivers/vfio/pci/Makefile | 1 > b/drivers/vfio/pci/vfio_pci.c | 18 > b/drivers/vfio/pci/vfio_pci_private.h | 14 > b/include/uapi/linux/vfio.h | 38 - Hi Christoph, FYI, these uapi changes break build of QEMU. I guess QEMU people should take some action before this percolates to the QEMU source tree. Cc'ing relevant QEMU lists to bring the discussion there. Cheers, -- Greg > drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------ > 16 files changed, 12 insertions(+), 1511 deletions(-) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A63C433B4 for ; Tue, 4 May 2021 12:25:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74DEF61075 for ; Tue, 4 May 2021 12:25:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74DEF61075 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldu6o-0005TC-A5 for qemu-devel@archiver.kernel.org; Tue, 04 May 2021 08:25:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldu4m-0004Zd-4F for qemu-devel@nongnu.org; Tue, 04 May 2021 08:22:56 -0400 Received: from 7.mo52.mail-out.ovh.net ([188.165.59.253]:41513) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldu4j-0005fy-G7 for qemu-devel@nongnu.org; Tue, 04 May 2021 08:22:55 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.108.4.240]) by mo52.mail-out.ovh.net (Postfix) with ESMTPS id CD06B275188; Tue, 4 May 2021 14:22:40 +0200 (CEST) Received: from kaod.org (37.59.142.101) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 4 May 2021 14:22:38 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-101G0043eda4e7a-de7c-4853-8406-edae349cf2a7, 233BADB9E061AA125F593C9F78707CF28220F307) smtp.auth=groug@kaod.org X-OVh-ClientIp: 78.197.208.248 Date: Tue, 4 May 2021 14:22:36 +0200 From: Greg Kurz To: Christoph Hellwig Subject: Re: remove the nvlink2 pci_vfio subdriver v2 Message-ID: <20210504142236.76994047@bahia.lan> In-Reply-To: <20210326061311.1497642-1-hch@lst.de> References: <20210326061311.1497642-1-hch@lst.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.101] X-ClientProxiedBy: DAG5EX1.mxp5.local (172.16.2.41) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: 316f1bea-914e-41ab-a4e8-46202395b6d3 X-Ovh-Tracer-Id: 4363706565853223297 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrvdefiedgheefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfhisehtjeeftdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeetgffffffggfekgeffteekhffhueelffdvhedvgfdthfeiudetvddulefgveevteenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdhpphgtsehnohhnghhnuhdrohhrgh Received-SPF: pass client-ip=188.165.59.253; envelope-from=groug@kaod.org; helo=7.mo52.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , kvm@vger.kernel.org, David Airlie , Michael Ellerman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, qemu-devel@nongnu.org, Alex Williamson , Paul Mackerras , Jason Gunthorpe , Greg Kroah-Hartman , qemu-ppc@nongnu.org, linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 26 Mar 2021 07:13:09 +0100 Christoph Hellwig wrote: > Hi all, > > the nvlink2 vfio subdriver is a weird beast. It supports a hardware > feature without any open source component - what would normally be > the normal open source userspace that we require for kernel drivers, > although in this particular case user space could of course be a > kernel driver in a VM. It also happens to be a complete mess that > does not properly bind to PCI IDs, is hacked into the vfio_pci driver > and also pulles in over 1000 lines of code always build into powerpc > kernels that have Power NV support enabled. Because of all these > issues and the lack of breaking userspace when it is removed I think > the best idea is to simply kill. > > Changes since v1: > - document the removed subtypes as reserved > - add the ACK from Greg > > Diffstat: > arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- > b/arch/powerpc/include/asm/opal.h | 3 > b/arch/powerpc/include/asm/pci-bridge.h | 1 > b/arch/powerpc/include/asm/pci.h | 7 > b/arch/powerpc/platforms/powernv/Makefile | 2 > b/arch/powerpc/platforms/powernv/opal-call.c | 2 > b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- > b/arch/powerpc/platforms/powernv/pci.c | 11 > b/arch/powerpc/platforms/powernv/pci.h | 17 > b/arch/powerpc/platforms/pseries/pci.c | 23 > b/drivers/vfio/pci/Kconfig | 6 > b/drivers/vfio/pci/Makefile | 1 > b/drivers/vfio/pci/vfio_pci.c | 18 > b/drivers/vfio/pci/vfio_pci_private.h | 14 > b/include/uapi/linux/vfio.h | 38 - Hi Christoph, FYI, these uapi changes break build of QEMU. I guess QEMU people should take some action before this percolates to the QEMU source tree. Cc'ing relevant QEMU lists to bring the discussion there. Cheers, -- Greg > drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------ > 16 files changed, 12 insertions(+), 1511 deletions(-)