From: Guenter Roeck <linux@roeck-us.net>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
kernel test robot <lkp@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI
Date: Tue, 4 May 2021 10:40:19 -0700 [thread overview]
Message-ID: <20210504174019.2134652-1-linux@roeck-us.net> (raw)
With CONFIG_ACPI=n and -Werror, 0-day reports:
drivers/iio/chemical/bme680_i2c.c:46:36: error:
'bme680_acpi_match' defined but not used
Reported-by: kernel test robot <lkp@intel.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Given the other patch, question of course is if this ACPI ID
is real. A Google search suggests that this might not be the case.
Should we remove it as well ? STK8312 has the same problem.
Jonathan, I think this needs your input before I send more patches.
drivers/iio/chemical/bme680_i2c.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/chemical/bme680_i2c.c b/drivers/iio/chemical/bme680_i2c.c
index 29c0dfa4702b..b5e75f145c19 100644
--- a/drivers/iio/chemical/bme680_i2c.c
+++ b/drivers/iio/chemical/bme680_i2c.c
@@ -42,11 +42,13 @@ static const struct i2c_device_id bme680_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, bme680_i2c_id);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id bme680_acpi_match[] = {
{"BME0680", 0},
{},
};
MODULE_DEVICE_TABLE(acpi, bme680_acpi_match);
+#endif
static const struct of_device_id bme680_of_i2c_match[] = {
{ .compatible = "bosch,bme680", },
--
2.25.1
next reply other threads:[~2021-05-04 17:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 17:40 Guenter Roeck [this message]
2021-05-04 17:44 ` [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI Andy Shevchenko
2021-05-04 17:46 ` Andy Shevchenko
2021-05-04 18:00 ` Guenter Roeck
2021-05-05 8:32 ` Jonathan Cameron
2021-05-05 8:34 ` Jonathan Cameron
2021-05-05 13:00 ` Guenter Roeck
2021-05-05 13:22 ` Andy Shevchenko
2021-05-05 13:39 ` Hans de Goede
2021-05-05 13:53 ` Andy Shevchenko
2021-05-05 14:04 ` Hans de Goede
2021-05-05 14:18 ` Andy Shevchenko
2021-05-05 15:19 ` Hans de Goede
2021-05-05 16:26 ` Andy Shevchenko
2021-05-05 16:30 ` Hans de Goede
2021-05-07 11:53 ` Pavel Machek
2021-05-07 12:39 ` Andy Shevchenko
2021-05-05 9:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504174019.2134652-1-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.