From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - pvremove: use consistent error message
Date: Tue, 4 May 2021 18:08:52 +0000 (GMT) [thread overview]
Message-ID: <20210504180852.4ECD8395144A@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=2419345b9d407d8b07327d7484f765ee92be5994
Commit: 2419345b9d407d8b07327d7484f765ee92be5994
Parent: 4dc5d4ac7e7a9457ccc46ff04796b347e58bf4da
Author: David Teigland <teigland@redhat.com>
AuthorDate: Tue May 4 13:03:25 2021 -0500
Committer: David Teigland <teigland@redhat.com>
CommitterDate: Tue May 4 13:08:02 2021 -0500
pvremove: use consistent error message
When the device is not a PV print
"No PV found on device ..."
instead of
"Failed to read lvm info for ... PVID ."
an earlier check had been added with a different
message for the same condition.
---
tools/toollib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/toollib.c b/tools/toollib.c
index 8f9ea1e6b..07f065322 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -5028,7 +5028,7 @@ static int _pvremove_check_used(struct cmd_context *cmd,
if (!(info = lvmcache_info_from_pvid(pd->dev->pvid, pd->dev, 0))) {
if (pp->force)
return 1;
- log_error("Failed to read lvm info for %s PVID %s.", dev_name(pd->dev), pd->dev->pvid);
+ log_error("No PV found on device %s.", dev_name(pd->dev));
dm_list_move(&pp->arg_fail, &pd->list);
return 0;
}
reply other threads:[~2021-05-04 18:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504180852.4ECD8395144A@sourceware.org \
--to=teigland@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.