From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [jlayton:ceph-fscache-iter 4/5] fs/ceph/inode.c:1981:2: error: too many arguments to function 'ceph_fscache_resize'
Date: Thu, 06 May 2021 09:59:12 +0800 [thread overview]
Message-ID: <202105060910.FNcLtp44-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4000 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git ceph-fscache-iter
head: f4c48a18a893921e9aae865fc88995bfee81eac6
commit: ac0b2544d16d85892ce71e1f4df50ef53e4a0549 [4/5] ceph: conversion to new fscache API
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git/commit/?id=ac0b2544d16d85892ce71e1f4df50ef53e4a0549
git remote add jlayton https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git
git fetch --no-tags jlayton ceph-fscache-iter
git checkout ac0b2544d16d85892ce71e1f4df50ef53e4a0549
# save the attached .config to linux build tree
make W=1 W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from fs/ceph/inode.c:20:
fs/ceph/cache.h:162:53: warning: 'struct netfs_read_request' declared inside parameter list will not be visible outside of this definition or declaration
162 | static inline int ceph_begin_cache_operation(struct netfs_read_request *rreq)
| ^~~~~~~~~~~~~~~~~~
fs/ceph/inode.c: In function '__ceph_do_pending_vmtruncate':
>> fs/ceph/inode.c:1981:2: error: too many arguments to function 'ceph_fscache_resize'
1981 | ceph_fscache_resize(inode, to);
| ^~~~~~~~~~~~~~~~~~~
In file included from fs/ceph/inode.c:20:
fs/ceph/cache.h:139:20: note: declared here
139 | static inline void ceph_fscache_resize(struct inode *inode)
| ^~~~~~~~~~~~~~~~~~~
vim +/ceph_fscache_resize +1981 fs/ceph/inode.c
1938
1939 /*
1940 * Make sure any pending truncation is applied before doing anything
1941 * that may depend on it.
1942 */
1943 void __ceph_do_pending_vmtruncate(struct inode *inode)
1944 {
1945 struct ceph_inode_info *ci = ceph_inode(inode);
1946 u64 to;
1947 int wrbuffer_refs, finish = 0;
1948
1949 mutex_lock(&ci->i_truncate_mutex);
1950 retry:
1951 spin_lock(&ci->i_ceph_lock);
1952 if (ci->i_truncate_pending == 0) {
1953 dout("__do_pending_vmtruncate %p none pending\n", inode);
1954 spin_unlock(&ci->i_ceph_lock);
1955 mutex_unlock(&ci->i_truncate_mutex);
1956 return;
1957 }
1958
1959 /*
1960 * make sure any dirty snapped pages are flushed before we
1961 * possibly truncate them.. so write AND block!
1962 */
1963 if (ci->i_wrbuffer_ref_head < ci->i_wrbuffer_ref) {
1964 spin_unlock(&ci->i_ceph_lock);
1965 dout("__do_pending_vmtruncate %p flushing snaps first\n",
1966 inode);
1967 filemap_write_and_wait_range(&inode->i_data, 0,
1968 inode->i_sb->s_maxbytes);
1969 goto retry;
1970 }
1971
1972 /* there should be no reader or writer */
1973 WARN_ON_ONCE(ci->i_rd_ref || ci->i_wr_ref);
1974
1975 to = ci->i_truncate_size;
1976 wrbuffer_refs = ci->i_wrbuffer_ref;
1977 dout("__do_pending_vmtruncate %p (%d) to %lld\n", inode,
1978 ci->i_truncate_pending, to);
1979 spin_unlock(&ci->i_ceph_lock);
1980
> 1981 ceph_fscache_resize(inode, to);
1982 truncate_pagecache(inode, to);
1983
1984 spin_lock(&ci->i_ceph_lock);
1985 if (to == ci->i_truncate_size) {
1986 ci->i_truncate_pending = 0;
1987 finish = 1;
1988 }
1989 spin_unlock(&ci->i_ceph_lock);
1990 if (!finish)
1991 goto retry;
1992
1993 mutex_unlock(&ci->i_truncate_mutex);
1994
1995 if (wrbuffer_refs == 0)
1996 ceph_check_caps(ci, 0, NULL);
1997
1998 wake_up_all(&ci->i_cap_wq);
1999 }
2000
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41725 bytes --]
reply other threads:[~2021-05-06 1:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105060910.FNcLtp44-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.