From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4176DC433B4 for ; Thu, 6 May 2021 15:32:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 056046140F for ; Thu, 6 May 2021 15:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235331AbhEFPdq (ORCPT ); Thu, 6 May 2021 11:33:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:45838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235179AbhEFPdp (ORCPT ); Thu, 6 May 2021 11:33:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2DA3A611AE; Thu, 6 May 2021 15:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620315167; bh=IdVDiP6+1WGD69KpQ4ecO/tfD5bBRFQpZYGTE4VGzkg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FFXKmiEySlP/tZydvoImG/r31EU1UBJOR46SWzqYuKF8d6dwqLioVT282SYuBon16 ZRsbVcR4jXWpUzObLhzWQlTxIRTpuABm6P1jZUKpalx6JkBewu7iPI+OlWWvQjUAUy iTRvMZWwTZz4+yoPs4sr80K+rdlkqMVNnzB1/V9W2ndn/NZOkKf26pSL0JzpzOJE/g aIrhLIf3SU5yM/BkX38DhYt7jHN3IARbpN9tQy/3fYWZZVHn6r9Sm2CfXK0W8a4lax 7WbduU0lKwoswL0nKcjbWNALDQsn9zmiT+jQpUdoNV+AzNSe/KDVWApIczPlRyTctW BG7PP6ZanlpHA== Received: by pali.im (Postfix) id 1E226E79; Thu, 6 May 2021 17:32:45 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas Cc: Russell King , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/42] PCI: aardvark: Increase polling delay to 1.5s while waiting for PIO response Date: Thu, 6 May 2021 17:31:15 +0200 Message-Id: <20210506153153.30454-5-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506153153.30454-1-pali@kernel.org> References: <20210506153153.30454-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Measurements in different conditions showed that aardvark hardware PIO response can take up to 1.44s. Increase wait timeout from 1ms to 1.5s to ensure that we do not miss responses from hardware. After 1.44s hardware returns errors (e.g. Completer abort). The previous two patches fixed checking for PIO status, so now we can use it to also catch errors which are reported by hardware after 1.44s. After applying this patch, kernel can detect and print PIO errors to dmesg: [ 6.879999] advk-pcie d0070000.pcie: Non-posted PIO Response Status: CA, 0xe00 @ 0x100004 [ 6.896436] advk-pcie d0070000.pcie: Posted PIO Response Status: COMP_ERR, 0x804 @ 0x100004 [ 6.913049] advk-pcie d0070000.pcie: Posted PIO Response Status: COMP_ERR, 0x804 @ 0x100010 [ 6.929663] advk-pcie d0070000.pcie: Non-posted PIO Response Status: CA, 0xe00 @ 0x100010 [ 6.953558] advk-pcie d0070000.pcie: Posted PIO Response Status: COMP_ERR, 0x804 @ 0x100014 [ 6.970170] advk-pcie d0070000.pcie: Non-posted PIO Response Status: CA, 0xe00 @ 0x100014 [ 6.994328] advk-pcie d0070000.pcie: Posted PIO Response Status: COMP_ERR, 0x804 @ 0x100004 Without this patch kernel prints only a generic error to dmesg: [ 5.246847] advk-pcie d0070000.pcie: config read/write timed out Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Cc: stable@vger.kernel.org # 7fbcb5da811b ("PCI: aardvark: Don't rely on jiffies while holding spinlock") --- drivers/pci/controller/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index a37ba86f1b2d..3f3c72927afb 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -166,7 +166,7 @@ #define PCIE_CONFIG_WR_TYPE0 0xa #define PCIE_CONFIG_WR_TYPE1 0xb -#define PIO_RETRY_CNT 500 +#define PIO_RETRY_CNT 750000 /* 1.5 s */ #define PIO_RETRY_DELAY 2 /* 2 us*/ #define LINK_WAIT_MAX_RETRIES 10 -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA455C4360C for ; Thu, 6 May 2021 15:34:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 330986109E for ; Thu, 6 May 2021 15:34:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 330986109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oeAqK8bs4WV0eA275lcaHcV3jSOMzl926Eyj0IONHnc=; b=VaHvd5Xd3JyU41CmIw8nR6Tiy pRPdApW5dITP7oBWsDYyuHQ+zxOdR2RArqTlDcQQHquQNQUas35DdqIg47GmgLIxhGiVjDlqDKriG RbvK+8U9u1pPAahalHxBNMdQnbf0hKSvukMFRw8ZLsjSqfa4aI2gr0EMJCavA7Bt6hPHwm9xGRVOK wKemMZS9JdFBdUZCNqWOmn8Zx/PjXG1dfbVgUXAtoKkY26JAy4VteuuPZy2xq+Dl2zVI+uD5Vn0hO 8Rjy1IMy+DmkZ8yxmhSk7jUkZZpshQeR+GgIEnLegA48kwokPfEo8F/ZcGuHnXLV3mGfFB/4IZlFE pbVoF6s9Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leg04-004aCE-69; Thu, 06 May 2021 15:33:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lefzg-004a2W-3h for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 15:32:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=SKqy2jVPczMdzntmqoj/cPGbVcXPe6VOfn/BSmJ+br8=; b=qxKeZWO8TAog6y8WP4BwsxV9vY 7qni1q700hzPnCXbCgOAoPoOcnxmCsv4jrBvvTMIM5AcTT/gYlx+Thy9QxS6betIYInCz8HZG8EMb tirIudombVbMClvXQWG10QFjiDNgmGBY16x37OXdOXVmARVjw0zuywKAHtvIGVytTLpMxmAd0xus7 SNl2DgK+Yx6BeqP2+9K2ermmiSbZDB/sXEU5DVmcVvg4XklOTjkw2Ws64xW1SPyFA3KLUh8x9k2Pe D7AWgH79dQMtore3DoNsTY+M7lp9zD+Tv5n+X0U0EktC1GfdVgNmfjpAd+AJwdt1dXyESgOlf3Axc NOcEu8Ww==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lefzb-0069f1-W0 for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 15:32:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2DA3A611AE; Thu, 6 May 2021 15:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620315167; bh=IdVDiP6+1WGD69KpQ4ecO/tfD5bBRFQpZYGTE4VGzkg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FFXKmiEySlP/tZydvoImG/r31EU1UBJOR46SWzqYuKF8d6dwqLioVT282SYuBon16 ZRsbVcR4jXWpUzObLhzWQlTxIRTpuABm6P1jZUKpalx6JkBewu7iPI+OlWWvQjUAUy iTRvMZWwTZz4+yoPs4sr80K+rdlkqMVNnzB1/V9W2ndn/NZOkKf26pSL0JzpzOJE/g aIrhLIf3SU5yM/BkX38DhYt7jHN3IARbpN9tQy/3fYWZZVHn6r9Sm2CfXK0W8a4lax 7WbduU0lKwoswL0nKcjbWNALDQsn9zmiT+jQpUdoNV+AzNSe/KDVWApIczPlRyTctW BG7PP6ZanlpHA== Received: by pali.im (Postfix) id 1E226E79; Thu, 6 May 2021 17:32:45 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas Cc: Russell King , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/42] PCI: aardvark: Increase polling delay to 1.5s while waiting for PIO response Date: Thu, 6 May 2021 17:31:15 +0200 Message-Id: <20210506153153.30454-5-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506153153.30454-1-pali@kernel.org> References: <20210506153153.30454-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_083248_119530_64701AA0 X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TWVhc3VyZW1lbnRzIGluIGRpZmZlcmVudCBjb25kaXRpb25zIHNob3dlZCB0aGF0IGFhcmR2YXJr IGhhcmR3YXJlIFBJTwpyZXNwb25zZSBjYW4gdGFrZSB1cCB0byAxLjQ0cy4gSW5jcmVhc2Ugd2Fp dCB0aW1lb3V0IGZyb20gMW1zIHRvIDEuNXMgdG8KZW5zdXJlIHRoYXQgd2UgZG8gbm90IG1pc3Mg cmVzcG9uc2VzIGZyb20gaGFyZHdhcmUuIEFmdGVyIDEuNDRzIGhhcmR3YXJlCnJldHVybnMgZXJy b3JzIChlLmcuIENvbXBsZXRlciBhYm9ydCkuCgpUaGUgcHJldmlvdXMgdHdvIHBhdGNoZXMgZml4 ZWQgY2hlY2tpbmcgZm9yIFBJTyBzdGF0dXMsIHNvIG5vdyB3ZSBjYW4gdXNlCml0IHRvIGFsc28g Y2F0Y2ggZXJyb3JzIHdoaWNoIGFyZSByZXBvcnRlZCBieSBoYXJkd2FyZSBhZnRlciAxLjQ0cy4K CkFmdGVyIGFwcGx5aW5nIHRoaXMgcGF0Y2gsIGtlcm5lbCBjYW4gZGV0ZWN0IGFuZCBwcmludCBQ SU8gZXJyb3JzIHRvIGRtZXNnOgoKICAgIFsgICAgNi44Nzk5OTldIGFkdmstcGNpZSBkMDA3MDAw MC5wY2llOiBOb24tcG9zdGVkIFBJTyBSZXNwb25zZSBTdGF0dXM6IENBLCAweGUwMCBAIDB4MTAw MDA0CiAgICBbICAgIDYuODk2NDM2XSBhZHZrLXBjaWUgZDAwNzAwMDAucGNpZTogUG9zdGVkIFBJ TyBSZXNwb25zZSBTdGF0dXM6IENPTVBfRVJSLCAweDgwNCBAIDB4MTAwMDA0CiAgICBbICAgIDYu OTEzMDQ5XSBhZHZrLXBjaWUgZDAwNzAwMDAucGNpZTogUG9zdGVkIFBJTyBSZXNwb25zZSBTdGF0 dXM6IENPTVBfRVJSLCAweDgwNCBAIDB4MTAwMDEwCiAgICBbICAgIDYuOTI5NjYzXSBhZHZrLXBj aWUgZDAwNzAwMDAucGNpZTogTm9uLXBvc3RlZCBQSU8gUmVzcG9uc2UgU3RhdHVzOiBDQSwgMHhl MDAgQCAweDEwMDAxMAogICAgWyAgICA2Ljk1MzU1OF0gYWR2ay1wY2llIGQwMDcwMDAwLnBjaWU6 IFBvc3RlZCBQSU8gUmVzcG9uc2UgU3RhdHVzOiBDT01QX0VSUiwgMHg4MDQgQCAweDEwMDAxNAog ICAgWyAgICA2Ljk3MDE3MF0gYWR2ay1wY2llIGQwMDcwMDAwLnBjaWU6IE5vbi1wb3N0ZWQgUElP IFJlc3BvbnNlIFN0YXR1czogQ0EsIDB4ZTAwIEAgMHgxMDAwMTQKICAgIFsgICAgNi45OTQzMjhd IGFkdmstcGNpZSBkMDA3MDAwMC5wY2llOiBQb3N0ZWQgUElPIFJlc3BvbnNlIFN0YXR1czogQ09N UF9FUlIsIDB4ODA0IEAgMHgxMDAwMDQKCldpdGhvdXQgdGhpcyBwYXRjaCBrZXJuZWwgcHJpbnRz IG9ubHkgYSBnZW5lcmljIGVycm9yIHRvIGRtZXNnOgoKICAgIFsgICAgNS4yNDY4NDddIGFkdmst cGNpZSBkMDA3MDAwMC5wY2llOiBjb25maWcgcmVhZC93cml0ZSB0aW1lZCBvdXQKClNpZ25lZC1v ZmYtYnk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+ClJldmlld2VkLWJ5OiBNYXJlayBC ZWjDum4gPGthYmVsQGtlcm5lbC5vcmc+CkNjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnICMgN2Zi Y2I1ZGE4MTFiICgiUENJOiBhYXJkdmFyazogRG9uJ3QgcmVseSBvbiBqaWZmaWVzIHdoaWxlIGhv bGRpbmcgc3BpbmxvY2siKQotLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJr LmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jIGIvZHJp dmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwppbmRleCBhMzdiYTg2ZjFiMmQuLjNm M2M3MjkyN2FmYiAxMDA2NDQKLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZh cmsuYworKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jCkBAIC0xNjYs NyArMTY2LDcgQEAKICNkZWZpbmUgUENJRV9DT05GSUdfV1JfVFlQRTAJCQkweGEKICNkZWZpbmUg UENJRV9DT05GSUdfV1JfVFlQRTEJCQkweGIKIAotI2RlZmluZSBQSU9fUkVUUllfQ05UCQkJNTAw CisjZGVmaW5lIFBJT19SRVRSWV9DTlQJCQk3NTAwMDAgLyogMS41IHMgKi8KICNkZWZpbmUgUElP X1JFVFJZX0RFTEFZCQkJMiAvKiAyIHVzKi8KIAogI2RlZmluZSBMSU5LX1dBSVRfTUFYX1JFVFJJ RVMJCTEwCi0tIAoyLjIwLjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==