From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev, Christoph Paasch <cpaasch@apple.com>,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH mptcp-net] mptcp: avoid OOB access in setsockopt()
Date: Thu, 6 May 2021 22:11:55 +0200 [thread overview]
Message-ID: <20210506201155.GE12364@breakpoint.cc> (raw)
In-Reply-To: <79b377c2cb932a86f0fd1a17f814064dd1ad7015.1620321074.git.pabeni@redhat.com>
Paolo Abeni <pabeni@redhat.com> wrote:
> We can't use tcp_set_congestion_control() on an mptcp socket, as
> such function can end-up accessing a tcp-specific field -
> prior_ssthresh - causing an OOB access.
Nice find.
> To allow propagating the correct ca algo on subflow, cache the ca
> name at initialization time.
Ok, this removes the problem of setting the right icsk_ca_ops on the
mptcp socket.
Thanks for fixing this!
next prev parent reply other threads:[~2021-05-06 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 17:24 [PATCH mptcp-net] mptcp: avoid OOB access in setsockopt() Paolo Abeni
2021-05-06 20:11 ` Florian Westphal [this message]
2021-05-07 0:46 ` Mat Martineau
2021-05-07 15:41 ` Matthieu Baerts
2021-05-07 16:45 ` Mat Martineau
2021-05-07 17:45 ` Matthieu Baerts
2021-05-07 19:00 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506201155.GE12364@breakpoint.cc \
--to=fw@strlen.de \
--cc=cpaasch@apple.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.