From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Lee Date: Fri, 7 May 2021 11:30:21 +0800 Subject: [PATCH v3 2/5] ARM: dts: aspeed: ast2600evb: Add comment for gpio regulator of sdhci In-Reply-To: <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-3-steven_lee@aspeedtech.com> <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> Message-ID: <20210507033021.GB23749@aspeedtech.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit The 05/07/2021 09:40, Andrew Jeffery wrote: > > > On Thu, 6 May 2021, at 19:33, Steven Lee wrote: > > Add the description for describing the AST2600-A2 EVB reference design of > > GPIO regulators. > > > > Signed-off-by: Steven Lee > > --- > > arch/arm/boot/dts/aspeed-ast2600-evb.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > index 2772796e215e..1ae0facc3d5f 100644 > > --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > @@ -104,6 +104,21 @@ > > status = "okay"; > > }; > > > > +/* > > + * The signal voltage of sdhci0 and sdhci1 on AST2600-A2 EVB is able to be > > + * toggled by GPIO pins. > > + * In the reference design, GPIOV0 of AST2600-A2 EVB is connected to the > > + * power load switch that providing 3.3v to sdhci0 vdd, GPIOV1 is connected to > > + * a 1.8v and a 3.3v power load switch that providing signal voltage to > > + * sdhci0 bus. > > + * If GPIOV0 is active high, sdhci0 is enabled, otherwise, sdhci0 is disabled. > > + * If GPIOV1 is active high, 3.3v power load switch is enabled, sdhci0 signal > > + * voltage is 3.3v, otherwise, 1.8v power load switch will be enabled, > > + * sdhci0 signal voltage becomes 1.8v. > > + * AST2600-A2 EVB also support toggling signal voltage for sdhci1. > > + * The design is the same as sdhci0, it uses GPIOV2 as power-gpio and GPIOV3 > > + * as power-switch-gpio. > > + */ > > Okay, I think the comment is in the right place, but I feel this patch > should also add the regulator nodes and hook them up to the SDHCIs. > > Given Rob isn't super keen on a second example in the binding document > I think you can just cut the example out and paste it in here. > Hi Andrew, Since AST2600-A0 and AST2600-A1 don't have regulators, do you mean cut the example from dt-binding and paste it to aspeed-ast2600-evb.dts but comment out the example? > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F320CC433B4 for ; Fri, 7 May 2021 03:31:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB57061041 for ; Fri, 7 May 2021 03:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230377AbhEGDcb (ORCPT ); Thu, 6 May 2021 23:32:31 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:56577 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230376AbhEGDcb (ORCPT ); Thu, 6 May 2021 23:32:31 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1473IbOq021620; Fri, 7 May 2021 11:18:37 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 7 May 2021 11:30:28 +0800 Date: Fri, 7 May 2021 11:30:21 +0800 From: Steven Lee To: Andrew Jeffery CC: Ulf Hansson , Rob Herring , Joel Stanley , Adrian Hunter , Philipp Zabel , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Ryan Chen , Chin-Ting Kuo , Hongwei Zhang Subject: Re: [PATCH v3 2/5] ARM: dts: aspeed: ast2600evb: Add comment for gpio regulator of sdhci Message-ID: <20210507033021.GB23749@aspeedtech.com> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-3-steven_lee@aspeedtech.com> <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1473IbOq021620 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The 05/07/2021 09:40, Andrew Jeffery wrote: > > > On Thu, 6 May 2021, at 19:33, Steven Lee wrote: > > Add the description for describing the AST2600-A2 EVB reference design of > > GPIO regulators. > > > > Signed-off-by: Steven Lee > > --- > > arch/arm/boot/dts/aspeed-ast2600-evb.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > index 2772796e215e..1ae0facc3d5f 100644 > > --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > @@ -104,6 +104,21 @@ > > status = "okay"; > > }; > > > > +/* > > + * The signal voltage of sdhci0 and sdhci1 on AST2600-A2 EVB is able to be > > + * toggled by GPIO pins. > > + * In the reference design, GPIOV0 of AST2600-A2 EVB is connected to the > > + * power load switch that providing 3.3v to sdhci0 vdd, GPIOV1 is connected to > > + * a 1.8v and a 3.3v power load switch that providing signal voltage to > > + * sdhci0 bus. > > + * If GPIOV0 is active high, sdhci0 is enabled, otherwise, sdhci0 is disabled. > > + * If GPIOV1 is active high, 3.3v power load switch is enabled, sdhci0 signal > > + * voltage is 3.3v, otherwise, 1.8v power load switch will be enabled, > > + * sdhci0 signal voltage becomes 1.8v. > > + * AST2600-A2 EVB also support toggling signal voltage for sdhci1. > > + * The design is the same as sdhci0, it uses GPIOV2 as power-gpio and GPIOV3 > > + * as power-switch-gpio. > > + */ > > Okay, I think the comment is in the right place, but I feel this patch > should also add the regulator nodes and hook them up to the SDHCIs. > > Given Rob isn't super keen on a second example in the binding document > I think you can just cut the example out and paste it in here. > Hi Andrew, Since AST2600-A0 and AST2600-A1 don't have regulators, do you mean cut the example from dt-binding and paste it to aspeed-ast2600-evb.dts but comment out the example? > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2C41C433ED for ; Fri, 7 May 2021 03:31:47 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 092A761041 for ; Fri, 7 May 2021 03:31:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 092A761041 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Fbwwd2v8Kz301m for ; Fri, 7 May 2021 13:31:45 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=fail (SPF fail - not authorized) smtp.mailfrom=aspeedtech.com (client-ip=211.20.114.71; helo=twspam01.aspeedtech.com; envelope-from=steven_lee@aspeedtech.com; receiver=) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FbwwF4XXPz2xv2; Fri, 7 May 2021 13:31:22 +1000 (AEST) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1473IbOq021620; Fri, 7 May 2021 11:18:37 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 7 May 2021 11:30:28 +0800 Date: Fri, 7 May 2021 11:30:21 +0800 From: Steven Lee To: Andrew Jeffery Subject: Re: [PATCH v3 2/5] ARM: dts: aspeed: ast2600evb: Add comment for gpio regulator of sdhci Message-ID: <20210507033021.GB23749@aspeedtech.com> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-3-steven_lee@aspeedtech.com> <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1473IbOq021620 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ulf Hansson , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "moderated list:ASPEED SD/MMC DRIVER" , Ryan Chen , Adrian Hunter , open list , Rob Herring , Philipp Zabel , Hongwei Zhang , Chin-Ting Kuo , "moderated list:ARM/ASPEED MACHINE SUPPORT" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" The 05/07/2021 09:40, Andrew Jeffery wrote: > > > On Thu, 6 May 2021, at 19:33, Steven Lee wrote: > > Add the description for describing the AST2600-A2 EVB reference design of > > GPIO regulators. > > > > Signed-off-by: Steven Lee > > --- > > arch/arm/boot/dts/aspeed-ast2600-evb.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > index 2772796e215e..1ae0facc3d5f 100644 > > --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > @@ -104,6 +104,21 @@ > > status = "okay"; > > }; > > > > +/* > > + * The signal voltage of sdhci0 and sdhci1 on AST2600-A2 EVB is able to be > > + * toggled by GPIO pins. > > + * In the reference design, GPIOV0 of AST2600-A2 EVB is connected to the > > + * power load switch that providing 3.3v to sdhci0 vdd, GPIOV1 is connected to > > + * a 1.8v and a 3.3v power load switch that providing signal voltage to > > + * sdhci0 bus. > > + * If GPIOV0 is active high, sdhci0 is enabled, otherwise, sdhci0 is disabled. > > + * If GPIOV1 is active high, 3.3v power load switch is enabled, sdhci0 signal > > + * voltage is 3.3v, otherwise, 1.8v power load switch will be enabled, > > + * sdhci0 signal voltage becomes 1.8v. > > + * AST2600-A2 EVB also support toggling signal voltage for sdhci1. > > + * The design is the same as sdhci0, it uses GPIOV2 as power-gpio and GPIOV3 > > + * as power-switch-gpio. > > + */ > > Okay, I think the comment is in the right place, but I feel this patch > should also add the regulator nodes and hook them up to the SDHCIs. > > Given Rob isn't super keen on a second example in the binding document > I think you can just cut the example out and paste it in here. > Hi Andrew, Since AST2600-A0 and AST2600-A1 don't have regulators, do you mean cut the example from dt-binding and paste it to aspeed-ast2600-evb.dts but comment out the example? > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99681C433B4 for ; Fri, 7 May 2021 03:32:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F3C6613D9 for ; Fri, 7 May 2021 03:32:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F3C6613D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3PEq90nPgFHDm5LGjxT/blq/w7NLJfi+JOYO97bWuv0=; b=biTyC55dBpZyX1GgHF7mO4euO OLPxrelEY1F6U2f1kiFvL7eCfZPHabnMB2StA/U2Sw1ZY/jEIrHwCHXxPzdNFCaVOE+TTTQ6t/UGu YTAqFAtxQnHb9ALtjFJZnqXP93yGcoqKA9K4lYA/Xj3islWip79Qn7UVbGfZz58cl+fNeSRj1AtRi wpofAa3orBawNyOX3nY3syk4y2CM8JfJnE49EfrfI2PnUWLv/UnTAcm90Qxu5ysgz0i/ZCuH8OmSJ V0M2LweB5apWLVUWota8PuOnZ6cEN4j4f40TV1wZeJ1cchlitDrigeH28SiURm+JFxZBt0MaFmuj+ 83AXv7nCg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lerCz-005ytg-SV; Fri, 07 May 2021 03:31:22 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lerCx-005ytQ-Hu for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 03:31:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Bfz9kZ6Mf74Ra3VjpFhBHR5zT6Lb+7bWs6+460QCTO0=; b=AU/PbJmuma4L84u6oSo6MpJguD cbu++YB3JlCXjcRLt1lOc0No4lZMZSYrIIha01PfRwJZrzHbLK6juDKOAGn7YMIE0eiB3EkMGG7h4 KCh/rIevQ65HEl5g3bMOsGAs+GRgZ5mn1Iq7YPz/eXRprCFwDQ+r/2+mSMsTulJp61mrpyAb5BR4L rv40YMDasrvbaW3fLJiOOmcp2GaSYo3hR4QhWYdqAA4EormMJgCKosGYddT2DHhlfopInxb/mzKjY AczA/oqN0FIN/LljWRbiQ4bkzBGR8nZB+NsiYffRJuZKKRCc3o3oK/U1bFr4PqDfI6FvFDR1pfgw0 sHYYgiJQ==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lerCl-002lxJ-K3 for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 03:31:12 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1473IbOq021620; Fri, 7 May 2021 11:18:37 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 7 May 2021 11:30:28 +0800 Date: Fri, 7 May 2021 11:30:21 +0800 From: Steven Lee To: Andrew Jeffery CC: Ulf Hansson , Rob Herring , Joel Stanley , Adrian Hunter , Philipp Zabel , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Ryan Chen , Chin-Ting Kuo , Hongwei Zhang Subject: Re: [PATCH v3 2/5] ARM: dts: aspeed: ast2600evb: Add comment for gpio regulator of sdhci Message-ID: <20210507033021.GB23749@aspeedtech.com> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-3-steven_lee@aspeedtech.com> <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1473IbOq021620 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_043110_491883_C8AF6ADE X-CRM114-Status: GOOD ( 24.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 05/07/2021 09:40, Andrew Jeffery wrote: > > > On Thu, 6 May 2021, at 19:33, Steven Lee wrote: > > Add the description for describing the AST2600-A2 EVB reference design of > > GPIO regulators. > > > > Signed-off-by: Steven Lee > > --- > > arch/arm/boot/dts/aspeed-ast2600-evb.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > index 2772796e215e..1ae0facc3d5f 100644 > > --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > @@ -104,6 +104,21 @@ > > status = "okay"; > > }; > > > > +/* > > + * The signal voltage of sdhci0 and sdhci1 on AST2600-A2 EVB is able to be > > + * toggled by GPIO pins. > > + * In the reference design, GPIOV0 of AST2600-A2 EVB is connected to the > > + * power load switch that providing 3.3v to sdhci0 vdd, GPIOV1 is connected to > > + * a 1.8v and a 3.3v power load switch that providing signal voltage to > > + * sdhci0 bus. > > + * If GPIOV0 is active high, sdhci0 is enabled, otherwise, sdhci0 is disabled. > > + * If GPIOV1 is active high, 3.3v power load switch is enabled, sdhci0 signal > > + * voltage is 3.3v, otherwise, 1.8v power load switch will be enabled, > > + * sdhci0 signal voltage becomes 1.8v. > > + * AST2600-A2 EVB also support toggling signal voltage for sdhci1. > > + * The design is the same as sdhci0, it uses GPIOV2 as power-gpio and GPIOV3 > > + * as power-switch-gpio. > > + */ > > Okay, I think the comment is in the right place, but I feel this patch > should also add the regulator nodes and hook them up to the SDHCIs. > > Given Rob isn't super keen on a second example in the binding document > I think you can just cut the example out and paste it in here. > Hi Andrew, Since AST2600-A0 and AST2600-A1 don't have regulators, do you mean cut the example from dt-binding and paste it to aspeed-ast2600-evb.dts but comment out the example? > Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel