[PATCH] userfaultfd: fix bugon.cocci warnings

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2036 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Andrea Arcangeli <aarcange@redhat.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

mm/huge_memory.c:2062:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)

 Use BUG_ON instead of a if condition followed by BUG.

Semantic patch information:
 This makes an effort to find cases where BUG() follows an if
 condition on an expression and replaces the if condition and BUG()
 with a BUG_ON having the conditional expression of the if statement
 as argument.

Generated by: scripts/coccinelle/misc/bugon.cocci

Fixes: 02c0714c4e4f ("userfaultfd: UFFDIO_REMAP uABI")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git master
head:   231327dd5f394c1d032155b7819eeca9e0efe5fd
commit: 02c0714c4e4f79be9c34d6a7b3614f86f2967210 [33/37] userfaultfd: UFFDIO_REMAP uABI
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

Please take the patch only if it's a positive warning. Thanks!

 huge_memory.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2057,9 +2057,7 @@ int remap_pages_huge_pmd(struct mm_struc
 	WRITE_ONCE(src_page->mapping, (struct address_space *) dst_anon_vma);
 	WRITE_ONCE(src_page->index, linear_page_index(dst_vma, dst_addr));
 
-	if (!pmd_same(pmdp_huge_clear_flush(src_vma, src_addr, src_pmd),
-		      src_pmdval))
-		BUG();
+	BUG_ON(!pmd_same(pmdp_huge_clear_flush(src_vma, src_addr, src_pmd), src_pmdval));
 	_dst_pmd = mk_huge_pmd(src_page, dst_vma->vm_page_prot);
 	_dst_pmd = maybe_pmd_mkwrite(pmd_mkdirty(_dst_pmd), dst_vma);
 	set_pmd_at(dst_mm, dst_addr, dst_pmd, _dst_pmd);