From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sean Christopherson <seanjc@google.com>
Cc: brijesh.singh@amd.com, kvm@vger.kernel.org
Subject: Re: [bug report] KVM: SVM: Add KVM_SEND_UPDATE_DATA command
Date: Fri, 7 May 2021 08:01:53 +0300 [thread overview]
Message-ID: <20210507050153.GC1922@kadam> (raw)
In-Reply-To: <YJQw8jlJcPO9ImNO@google.com>
On Thu, May 06, 2021 at 06:09:54PM +0000, Sean Christopherson wrote:
> On Thu, Apr 29, 2021, Dan Carpenter wrote:
> > Hello Brijesh Singh,
> >
> > The patch d3d1af85e2c7: "KVM: SVM: Add KVM_SEND_UPDATE_DATA command"
> > from Apr 15, 2021, leads to the following static checker warning:
> >
> > arch/x86/kvm/svm/sev.c:1268 sev_send_update_data() warn: 'guest_page' is an error pointer or valid
> > arch/x86/kvm/svm/sev.c:1316 sev_send_update_data() warn: maybe return -EFAULT instead of the bytes remaining?
> > arch/x86/kvm/svm/sev.c:1462 sev_receive_update_data() warn: 'guest_page' is an error pointer or valid
>
> Thanks for the report. Is the static checker you're using publicly available?
> Catching these bugs via a checker is super cool!
This is a Smatch check, but I'm glad you asked about this because it
turns out I never committed the "is an error pointer or valid" check.
I'll do that now and push it later today.
regards,
dan carpenter
prev parent reply other threads:[~2021-05-07 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 7:20 [bug report] KVM: SVM: Add KVM_SEND_UPDATE_DATA command Dan Carpenter
2021-05-06 18:09 ` Sean Christopherson
2021-05-07 5:01 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507050153.GC1922@kadam \
--to=dan.carpenter@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=kvm@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.