From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C456C433B4 for ; Fri, 7 May 2021 21:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4670F61106 for ; Fri, 7 May 2021 21:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbhEGVuj (ORCPT ); Fri, 7 May 2021 17:50:39 -0400 Received: from mail-ot1-f44.google.com ([209.85.210.44]:44672 "EHLO mail-ot1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbhEGVuj (ORCPT ); Fri, 7 May 2021 17:50:39 -0400 Received: by mail-ot1-f44.google.com with SMTP id r26-20020a056830121ab02902a5ff1c9b81so9142646otp.11; Fri, 07 May 2021 14:49:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PjEtFCe5+lrFxZTe/Zi9n6poa77xUGPKZ2g66tXrfzo=; b=F6O0xFmByoNTvtoO5AlV2pR0fMHloVdjm8lunjtVKiBe0r4DIG7L8OLlp29bfsDm9+ g6lOgWb4hmCTnKDS2zlhwSbcj+xQuwTIj0mDEVE0HZQcy6M3kbdGllMcHuOxWj/t4Nbr z0D9/4VTb0L3DMhQ8HKHw/HNf1IPyRntM0xXXF8WqM9I8hnJIbQHn7E1T0Wbi7OX8CfV eDsd1S9sJyP0RZb0ZUf01jqmESqSMj4SCGRcB9E40PusiIgg29BBc2Tgn3m33Ity+Q5E BK6T5CGAa3v8bS8HyH7huim4ADuyqlMPGEvjbK6wRdXxuZPiuBXPoJ/KZIC5cJV0eZZI SJ1Q== X-Gm-Message-State: AOAM531g9lqAFvZVoD/8uLXbszOK14yqZ6NYG7MyEmtK/+Hlx0EKxL4X l1XTcp/AnVeWmrmD9wSzsQ== X-Google-Smtp-Source: ABdhPJyQMXenAYcP+muUQjeAoJD82VnM0IixSPbaYREYvzrhdcxF/iI6pg2O2zAGiUqHjjdXcDhQXg== X-Received: by 2002:a9d:4115:: with SMTP id o21mr10002087ote.52.1620424178375; Fri, 07 May 2021 14:49:38 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 65sm1423105otj.17.2021.05.07.14.49.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 14:49:37 -0700 (PDT) Received: (nullmailer pid 2952512 invoked by uid 1000); Fri, 07 May 2021 21:49:36 -0000 Date: Fri, 7 May 2021 16:49:36 -0500 From: Rob Herring To: Chris Packham Cc: wsa@kernel.org, andriy.shevchenko@linux.intel.com, andy.shevchenko@gmail.com, mpe@ellerman.id.au, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: mpc: Add fsl,i2c-erratum-a004447 flag Message-ID: <20210507214936.GA2944698@robh.at.kernel.org> References: <20210507004047.4454-1-chris.packham@alliedtelesis.co.nz> <20210507004047.4454-2-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210507004047.4454-2-chris.packham@alliedtelesis.co.nz> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, May 07, 2021 at 12:40:45PM +1200, Chris Packham wrote: > Document the fsl,i2c-erratum-a004447 flag which indicates the presence > of an i2c erratum on some QorIQ SoCs. > > Signed-off-by: Chris Packham > --- > Documentation/devicetree/bindings/i2c/i2c-mpc.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml b/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml > index 7b553d559c83..98c6fcf7bf26 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml > @@ -46,6 +46,13 @@ properties: > description: | > I2C bus timeout in microseconds > > + fsl,i2c-erratum-a004447: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + Indicates the presence of QorIQ erratum A-004447, which > + says that the standard i2c recovery scheme mechanism does > + not work and an alternate implementation is needed. The problem with adding a property for an errata is you have to update the dtb. If you use the compatible string, then only an OS update is needed. That assumes you have specific enough compatible strings. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28960C433ED for ; Fri, 7 May 2021 21:50:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34E7E610FA for ; Fri, 7 May 2021 21:50:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34E7E610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FcPHz5pHbz3099 for ; Sat, 8 May 2021 07:50:07 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.45; helo=mail-ot1-f45.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FcPHW3wv5z2yXs for ; Sat, 8 May 2021 07:49:41 +1000 (AEST) Received: by mail-ot1-f45.google.com with SMTP id 36-20020a9d0ba70000b02902e0a0a8fe36so2842815oth.8 for ; Fri, 07 May 2021 14:49:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PjEtFCe5+lrFxZTe/Zi9n6poa77xUGPKZ2g66tXrfzo=; b=fjb5w9xXcd993g0FT5sKxh6bf8kf3FFb+hUstxx/z7nJ3tg8lJy0hiU4deYrY+nbPd grBzkuIr6ujlr+p2wdBHH/2XFtAofwfVDq2W4miIziE1oMPJQNlJNAALk1N6E2KZLQF8 ULgKp1NdDN/3jnGsiR/cmBpuUtnqGscAs+z6NMpjcBW6CE27d5Z1Nqznd8E23aYygPqJ Dv6iN53JqxFEeHRf+PwIPw6uJ8cYbcGUXqJegl4W4JRzHKM2TEHz/zITuwGrDRcfdE+D 46jrpD7CC1e+MjRnLGGV7vsPiQ6N5sTD+0apHl1gAYDpF1WohEs31pBIDT+pLxUjX9je a+sA== X-Gm-Message-State: AOAM531snhICUo9VQtCji90AaCBjPniO7AN7wIr/7OYZaLvyEoBqGZCI 9iDG+CVS8i1oPELRFTASEg== X-Google-Smtp-Source: ABdhPJyQMXenAYcP+muUQjeAoJD82VnM0IixSPbaYREYvzrhdcxF/iI6pg2O2zAGiUqHjjdXcDhQXg== X-Received: by 2002:a9d:4115:: with SMTP id o21mr10002087ote.52.1620424178375; Fri, 07 May 2021 14:49:38 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 65sm1423105otj.17.2021.05.07.14.49.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 14:49:37 -0700 (PDT) Received: (nullmailer pid 2952512 invoked by uid 1000); Fri, 07 May 2021 21:49:36 -0000 Date: Fri, 7 May 2021 16:49:36 -0500 From: Rob Herring To: Chris Packham Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: mpc: Add fsl,i2c-erratum-a004447 flag Message-ID: <20210507214936.GA2944698@robh.at.kernel.org> References: <20210507004047.4454-1-chris.packham@alliedtelesis.co.nz> <20210507004047.4454-2-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210507004047.4454-2-chris.packham@alliedtelesis.co.nz> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, wsa@kernel.org, andy.shevchenko@gmail.com, linux-i2c@vger.kernel.org, andriy.shevchenko@linux.intel.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 07, 2021 at 12:40:45PM +1200, Chris Packham wrote: > Document the fsl,i2c-erratum-a004447 flag which indicates the presence > of an i2c erratum on some QorIQ SoCs. > > Signed-off-by: Chris Packham > --- > Documentation/devicetree/bindings/i2c/i2c-mpc.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml b/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml > index 7b553d559c83..98c6fcf7bf26 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml > @@ -46,6 +46,13 @@ properties: > description: | > I2C bus timeout in microseconds > > + fsl,i2c-erratum-a004447: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + Indicates the presence of QorIQ erratum A-004447, which > + says that the standard i2c recovery scheme mechanism does > + not work and an alternate implementation is needed. The problem with adding a property for an errata is you have to update the dtb. If you use the compatible string, then only an OS update is needed. That assumes you have specific enough compatible strings. Rob