All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Skripkin <paskripkin@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: media: atomisp: code cleanup
Date: Sat, 8 May 2021 14:32:20 +0300	[thread overview]
Message-ID: <20210508143220.0b92bc37@gmail.com> (raw)
In-Reply-To: <YJZuviLa3SRLWASk@kroah.com>

Hi, Greg!

On Sat, 8 May 2021 12:58:06 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sat, May 08, 2021 at 01:51:29PM +0300, Pavel Skripkin wrote:
> > Breaks are not useful after a return, they can
> > simply be removed.
> > 
> > Also, dropped the individual return statements
> > after or inside switch cases
> 
> Almost always, when you say "also" in a patch changelog, that means
> this should be split up into two different patches.
> 

I thought, I could add this to current patch, because It was suggested
by maintainer, but, I guess, I was wrong :)

> I recommend doing that here as well, this should be a 2 patch series,
> right?
> 

Thanks for suggestion! I will also remove returns at the end of void
functions as 3rd patch in serie.

> thanks,
> 
> greg k-h

With regards,
Pavel Skripkin

  reply	other threads:[~2021-05-08 11:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 20:09 [PATCH] staging: media: atomisp: remove useless breaks Pavel Skripkin
2021-05-07  7:54 ` Sakari Ailus
2021-05-07 13:25   ` Pavel Skripkin
2021-05-08 10:51   ` [PATCH v2] staging: media: atomisp: code cleanup Pavel Skripkin
2021-05-08 10:58     ` Greg KH
2021-05-08 11:32       ` Pavel Skripkin [this message]
2021-05-08 12:21       ` [PATCH v3 0/3] staging: media: atomisp: code clean up Pavel Skripkin
2021-05-08 12:21         ` [PATCH v3 1/3] staging: media: atomisp: remove useless breaks Pavel Skripkin
2021-05-08 12:21         ` [PATCH v3 2/3] staging: media: atomisp: remove dublicate code Pavel Skripkin
2021-05-08 12:21         ` [PATCH v3 3/3] staging: media: atomisp: remove useless returns Pavel Skripkin
2021-05-08 12:43           ` Fabio Aiuto
2021-05-08 12:48             ` Dan Carpenter
2021-05-08 12:59               ` Fabio Aiuto
2021-05-08 13:05             ` Pavel Skripkin
2021-05-08 13:16             ` [PATCH v4 0/3] staging: media: atomisp: code clean up Pavel Skripkin
2021-05-08 13:17               ` [PATCH v4 1/3] staging: media: atomisp: remove useless breaks Pavel Skripkin
2021-05-08 13:17               ` [PATCH v4 2/3] staging: media: atomisp: remove dublicate code Pavel Skripkin
2021-05-08 13:17               ` [PATCH v4 3/3] staging: media: atomisp: remove useless returns Pavel Skripkin
2021-05-25 16:18               ` [PATCH v4 0/3] staging: media: atomisp: code clean up Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210508143220.0b92bc37@gmail.com \
    --to=paskripkin@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.