From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Edmundo Carmona Antoranz <eantoranz@gmail.com>,
christophe.jaillet@wanadoo.fr, kernel-janitors@vger.kernel.org
Subject: Re: [RFC 1/2] rtc: max77686: use symbolic error messages
Date: Mon, 10 May 2021 09:03:40 +0300 [thread overview]
Message-ID: <20210510060340.GP1955@kadam> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2105100703230.3126@hadrien>
On Mon, May 10, 2021 at 07:03:59AM +0200, Julia Lawall wrote:
>
>
> On Mon, 10 May 2021, Dan Carpenter wrote:
>
> > On Sun, May 09, 2021 at 11:17:42PM +0200, Julia Lawall wrote:
> > > ---------------------------
> > >
> > > Patch of a recent linux next:
> > >
> > > diff --git a/arch/arm/mach-pxa/cm-x300.c b/arch/arm/mach-pxa/cm-x300.c
> > > index 2e35354b61f5..ff75e928772a 100644
> > > --- a/arch/arm/mach-pxa/cm-x300.c
> > > +++ b/arch/arm/mach-pxa/cm-x300.c
> > > @@ -531,7 +531,7 @@ static int cm_x300_u2d_init(struct device *dev)
> > > pout_clk = clk_get(NULL, "CLK_POUT");
> > > if (IS_ERR(pout_clk)) {
> > > err = PTR_ERR(pout_clk);
> > > - pr_err("failed to get CLK_POUT: %d\n", err);
> > > + pr_err("failed to get CLK_POUT: %pe\n", err);
> >
> > It has to print the pointer and not the err. So it should be:
> >
> > pr_err("failed to get CLK_POUT: %pe\n", pout_clk);
>
> Oops! Thanks. That is easy to fix.
Yeah, but I would prefer to wait until %e exists and use that instead.
regards,
dan carpenter
next prev parent reply other threads:[~2021-05-10 6:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 0:41 [RFC 1/2] rtc: max77686: use symbolic error messages Edmundo Carmona Antoranz
2021-05-09 0:41 ` [RFC 2/2] staging: fbtft: " Edmundo Carmona Antoranz
2021-05-09 0:44 ` Edmundo Carmona Antoranz
2021-05-09 7:39 ` [RFC 1/2] rtc: max77686: " Christophe JAILLET
2021-05-10 4:30 ` Dan Carpenter
2021-05-10 5:06 ` Julia Lawall
2021-05-10 5:45 ` Marion & Christophe JAILLET
[not found] ` <alpine.DEB.2.22.394.2105092315330.24280@hadrien>
2021-05-10 4:35 ` Dan Carpenter
2021-05-10 5:03 ` Julia Lawall
2021-05-10 6:03 ` Dan Carpenter [this message]
2021-05-10 6:04 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510060340.GP1955@kadam \
--to=dan.carpenter@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=eantoranz@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.