From: Christoph Hellwig <hch@lst.de>
To: Chanho Park <chanho61.park@samsung.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-kernel@vger.kernel.org,
Bumyong Lee <bumyong.lee@samsung.com>,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] swiotlb: manipulate orig_addr when tlb_addr has offset
Date: Mon, 10 May 2021 10:44:06 +0200 [thread overview]
Message-ID: <20210510084406.GA1093@lst.de> (raw)
In-Reply-To: <20210510083057.46476-1-chanho61.park@samsung.com>
On Mon, May 10, 2021 at 05:30:57PM +0900, Chanho Park wrote:
> +static unsigned int swiotlb_align_offset(struct device *dev, u64 addr);
Please just move swiotlb_align_offset up to avoid the forward declaration.
> /*
> * Bounce: copy the swiotlb buffer from or back to the original dma location
> */
> @@ -346,10 +347,17 @@ static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size
> size_t alloc_size = mem->slots[index].alloc_size;
> unsigned long pfn = PFN_DOWN(orig_addr);
> unsigned char *vaddr = phys_to_virt(tlb_addr);
> + unsigned int tlb_offset;
>
> if (orig_addr == INVALID_PHYS_ADDR)
> return;
>
> + tlb_offset = (unsigned int)tlb_addr & (IO_TLB_SIZE - 1);
> + tlb_offset -= swiotlb_align_offset(dev, orig_addr);
Nit: I'd write this as:
tlb_offset = (tlb_addr & (IO_TLB_SIZE - 1)) -
swiotlb_align_offset(dev, orig_addr);
as there is no need for the cast, and just having a single assignment
is easier to follow.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Chanho Park <chanho61.park@samsung.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Bumyong Lee <bumyong.lee@samsung.com>
Subject: Re: [PATCH] swiotlb: manipulate orig_addr when tlb_addr has offset
Date: Mon, 10 May 2021 10:44:06 +0200 [thread overview]
Message-ID: <20210510084406.GA1093@lst.de> (raw)
In-Reply-To: <20210510083057.46476-1-chanho61.park@samsung.com>
On Mon, May 10, 2021 at 05:30:57PM +0900, Chanho Park wrote:
> +static unsigned int swiotlb_align_offset(struct device *dev, u64 addr);
Please just move swiotlb_align_offset up to avoid the forward declaration.
> /*
> * Bounce: copy the swiotlb buffer from or back to the original dma location
> */
> @@ -346,10 +347,17 @@ static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size
> size_t alloc_size = mem->slots[index].alloc_size;
> unsigned long pfn = PFN_DOWN(orig_addr);
> unsigned char *vaddr = phys_to_virt(tlb_addr);
> + unsigned int tlb_offset;
>
> if (orig_addr == INVALID_PHYS_ADDR)
> return;
>
> + tlb_offset = (unsigned int)tlb_addr & (IO_TLB_SIZE - 1);
> + tlb_offset -= swiotlb_align_offset(dev, orig_addr);
Nit: I'd write this as:
tlb_offset = (tlb_addr & (IO_TLB_SIZE - 1)) -
swiotlb_align_offset(dev, orig_addr);
as there is no need for the cast, and just having a single assignment
is easier to follow.
next prev parent reply other threads:[~2021-05-10 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210510083139epcas2p211d9bee16e5e8f8ea34e606c83ac3a55@epcas2p2.samsung.com>
2021-05-10 8:30 ` [PATCH] swiotlb: manipulate orig_addr when tlb_addr has offset Chanho Park
2021-05-10 8:30 ` Chanho Park
2021-05-10 8:44 ` Christoph Hellwig [this message]
2021-05-10 8:44 ` Christoph Hellwig
2021-05-10 9:04 ` Chanho Park
2021-05-10 9:04 ` Chanho Park
[not found] <CGME20210510085719epcas2p3b4467098ba64c4bdd51fe3ede38e3753@epcms2p4>
2021-05-10 8:57 ` CHANHO PARK
[not found] <CGME20210628065652epcas2p28f39187d9c1519cea42bd99a7e9dd75d@epcas2p2.samsung.com>
2021-06-25 9:26 ` FAILED: patch "[PATCH] swiotlb: manipulate orig_addr when tlb_addr has offset" failed to apply to 5.10-stable tree gregkh
2021-06-28 6:57 ` [PATCH] swiotlb: manipulate orig_addr when tlb_addr has offset Chanho Park
[not found] <CGME20210628065823epcas2p19305f8b888a7fc0e883ec51db61e3bae@epcas2p1.samsung.com>
2021-06-25 9:26 ` FAILED: patch "[PATCH] swiotlb: manipulate orig_addr when tlb_addr has offset" failed to apply to 5.12-stable tree gregkh
2021-06-28 6:59 ` [PATCH] swiotlb: manipulate orig_addr when tlb_addr has offset Chanho Park
2021-06-28 9:05 ` Greg KH
2021-06-28 9:25 ` Chanho Park
2021-06-28 9:36 ` 'Greg KH'
2021-06-28 10:05 ` Chanho Park
2021-06-28 12:20 ` 'Greg KH'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510084406.GA1093@lst.de \
--to=hch@lst.de \
--cc=bumyong.lee@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.