From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A98270 for ; Mon, 10 May 2021 14:55:19 +0000 (UTC) Received: by mail-wm1-f45.google.com with SMTP id s5-20020a7bc0c50000b0290147d0c21c51so9059858wmh.4 for ; Mon, 10 May 2021 07:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LdzN4vabxAaywTUCUyKAN9CsvFqkJ9+cyxQ6LXEIgIg=; b=tEEP9K0KtsbmbCmehq7nnKT79txVrDofPfBNxwbH4AsT6HNkMFHArBaJhDCwcp4inB ay3uCvGqLbaodlFhGc7Gll7MUTCqLhYHB0ZKw9ww3xJsVXo2DwswW/AfPhbOyH1pAcPH 4DXp+1/hnr+ziv7fNo2HzGfuQbykCWRHtQQAZnl0yDn8KqLuq/dte5K2evulvvLq04Bm 6MQExnad/ZGusbGBgtyyKP5YLMwCpMdtx2zKaUWBsYYFTYY6tHNzcobVuXbYNFiHMuRC tyQE5qITL4RKOvFT0YfPYsbHA6btY8ty1Se6D5mN7AVVG+lFIELsvJdo3WS51dg8uatC TObQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LdzN4vabxAaywTUCUyKAN9CsvFqkJ9+cyxQ6LXEIgIg=; b=m91t/HSqdvye+TBy3WtR8BJhr50gHDbPeYdGxE2yVWHT5bjbXiabUVQIcOQCLvOlo3 FUvEnEUfiWTfPg7dQsVWo1e8PTvxp39w7zpm45ak03QWO9kmLlqxJkIgVG+d8Etp5C+m kSeF/wvilC0MDRoQrQg7WSwkrS6+os1cuDGeNzf0CLFQssga6TGesO8eaZrC57lQrWqV x1lIQ+s3xsHKma79bnqq6rSPB6Fi6JiDvoFc+JgcC5Qg0qkbyTX4aoEpgd5di2INF9Gt IeTGfVv0Z5vasBPUCg3GHi2yUF9iPDY+95VF92Z98ljH9+NQZxJm/GVLJbYQd34WBOGE IS5g== X-Gm-Message-State: AOAM5325AdG5EJK3/87x9NuTXzrOQRflQPArXbF2xoViMs25WeiRxALG GjtngHmnlf9/vKitZOZ62NI= X-Google-Smtp-Source: ABdhPJyJGOksxuTa1I03eCfUNXSQXfSlP99bP4r9fmwr8UHi5oDDmGa7+XJW4+i2guA91NWX4yFBSQ== X-Received: by 2002:a05:600c:1909:: with SMTP id j9mr21284358wmq.100.1620658518019; Mon, 10 May 2021 07:55:18 -0700 (PDT) Received: from agape.jhs ([5.171.73.3]) by smtp.gmail.com with ESMTPSA id i3sm26014413wrb.46.2021.05.10.07.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 07:55:17 -0700 (PDT) Date: Mon, 10 May 2021 16:55:14 +0200 From: Fabio Aiuto To: Ashish Vara Cc: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, coiby.xu@gmail.com, gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: Subject: [PATCH] staging: qlge: removed unnecessary debug message to fix coding style warning Message-ID: <20210510145513.GD4434@agape.jhs> References: X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Hi Ashish, in your subject line there is one Subject: too many On Mon, May 10, 2021 at 08:13:37PM +0530, Ashish Vara wrote: > From: Ashish Vara > > removed unnecessary out of memory message to fix coding style warning. > > Signed-off-by: Ashish Vara > --- > drivers/staging/qlge/qlge_main.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index c9dc6a852af4..a9e0bccc52d0 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -2796,12 +2796,8 @@ static int qlge_init_bq(struct qlge_bq *bq) > > bq->base = dma_alloc_coherent(&qdev->pdev->dev, QLGE_BQ_SIZE, > &bq->base_dma, GFP_ATOMIC); > - if (!bq->base) { > - netif_err(qdev, ifup, qdev->ndev, > - "ring %u %s allocation failed.\n", rx_ring->cq_id, > - bq_type_name[bq->type]); > + if (!bq->base) > return -ENOMEM; > - } > > bq->queue = kmalloc_array(QLGE_BQ_LEN, sizeof(struct qlge_bq_desc), > GFP_KERNEL); > -- > 2.30.2 > thank you, fabio