From: Jason Gunthorpe <jgg@nvidia.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: yishaih@nvidia.com, dledford@redhat.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/mlx4: Remove unnessesary check in mlx4_ib_modify_wq()
Date: Tue, 11 May 2021 14:43:02 -0300 [thread overview]
Message-ID: <20210511174302.GA1291834@nvidia.com> (raw)
In-Reply-To: <1620382961-69701-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Fri, May 07, 2021 at 06:22:41PM +0800, Jiapeng Chong wrote:
> cur_state and new_state are enums and when GCC considers
> them as unsigned, the conditions are never met.
But doesn't gcc consider enums to be 'int' as the standard requires?
This change looks really sketchy to me, cur_state and new_state are
both userspace controlled data. We should not make assumptions about
the underlying signedness of an enum when validating user data.
Jason
next prev parent reply other threads:[~2021-05-11 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 10:22 [PATCH] RDMA/mlx4: Remove unnessesary check in mlx4_ib_modify_wq() Jiapeng Chong
2021-05-09 8:58 ` Leon Romanovsky
2021-05-09 9:40 ` Leon Romanovsky
2021-05-11 17:43 ` Jason Gunthorpe [this message]
2021-05-18 7:05 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511174302.GA1291834@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.