All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory Anders <greg@gpanders.com>
To: git@vger.kernel.org
Cc: Gregory Anders <greg@gpanders.com>
Subject: [PATCH v3] git-send-email: use ! to indicate relative path to command
Date: Tue, 11 May 2021 13:15:11 -0600	[thread overview]
Message-ID: <20210511191510.25888-1-greg@gpanders.com> (raw)

When the smtpServer config option is prefixed with a ! character, the
value of the option should be interpreted as a command to look up on
PATH.

Signed-off-by: Gregory Anders <greg@gpanders.com>
---

Remove the PATH lookup, since Perl's exec() does this already.

Thanks to Jeff King for the assist.

 git-send-email.perl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 175da07d94..022dcf0999 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1492,11 +1492,14 @@ sub send_message {
 
 	if ($dry_run) {
 		# We don't want to send the email.
-	} elsif (file_name_is_absolute($smtp_server)) {
+	} elsif (file_name_is_absolute($smtp_server) || $smtp_server =~ /^!/) {
+		my $prog = $smtp_server;
+		$prog =~ s/^!//;
+
 		my $pid = open my $sm, '|-';
 		defined $pid or die $!;
 		if (!$pid) {
-			exec($smtp_server, @sendmail_parameters) or die $!;
+			exec($prog, @sendmail_parameters) or die $!;
 		}
 		print $sm "$header\n$message";
 		close $sm or die $!;
-- 
2.31.1.576.g06d230b258


             reply	other threads:[~2021-05-11 19:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 19:15 Gregory Anders [this message]
2021-05-11 19:24 ` [PATCH v3] git-send-email: use ! to indicate relative path to command Jeff King
2021-05-11 20:40   ` [PATCH v4] " Gregory Anders
2021-05-11 21:39     ` Jeff King
2021-05-11 22:18       ` Gregory Anders
2021-05-11 23:09     ` Junio C Hamano
2021-05-11 23:49     ` [PATCH v5] " Gregory Anders
2021-05-12  0:00       ` brian m. carlson
2021-05-12  0:35         ` Jeff King
2021-05-12  0:45           ` Gregory Anders
2021-05-12  0:49             ` Jeff King
2021-05-12  3:29             ` Junio C Hamano
2021-05-12  0:51           ` brian m. carlson
2021-05-11 20:03 ` [PATCH v3] " Felipe Contreras
2021-05-11 20:42   ` Gregory Anders
2021-05-11 22:07     ` Felipe Contreras
2021-05-11 22:19       ` Gregory Anders
2021-05-12  0:47         ` Jeff King
2021-05-12  1:08           ` Felipe Contreras
2021-05-12  1:24             ` Jeff King
2021-05-12  1:52               ` Felipe Contreras
2021-05-12  1:58                 ` Gregory Anders
2021-05-12  4:17                   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511191510.25888-1-greg@gpanders.com \
    --to=greg@gpanders.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.