From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C01C433ED for ; Tue, 11 May 2021 20:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5202460241 for ; Tue, 11 May 2021 20:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbhEKUtW (ORCPT ); Tue, 11 May 2021 16:49:22 -0400 Received: from elvis.franken.de ([193.175.24.41]:50412 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbhEKUtV (ORCPT ); Tue, 11 May 2021 16:49:21 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lgZIb-0003nj-03; Tue, 11 May 2021 22:48:13 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 245B2C0E42; Tue, 11 May 2021 22:47:58 +0200 (CEST) Date: Tue, 11 May 2021 22:47:58 +0200 From: Thomas Bogendoerfer To: Sergio Paracuellos Cc: "open list:MIPS" , Greg KH , linux-staging@lists.linux.dev Subject: Re: Some doubts about mt7621-pci mainline place Message-ID: <20210511204758.GD18185@alpha.franken.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, May 10, 2021 at 08:43:51AM +0200, Sergio Paracuellos wrote: > in staging and is properly using the pci generic APIs instead of the > PCI_LEGACY which seems that all other drivers in 'arch/mips/pci' are > using. The driver is generic enough but it needs mips iocu region > configuration that is done in the driver itself. So here it is where > my questions come. Is 'arch/mips/pci' the place to move this driver? moving to arch/mips/pci would work for me. Could you look at converting the driver to PCI_DRIVERS_GENERIC instead of LEGACY ? I want to get rid of PCI_LEGACY... > Is the driver the correct place to configure the iocu related with > pci? I see no problem with this at the moment. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]