All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Marco Oliverio <marco.oliverio@tanaza.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nftables PATCH] cache: check errno before invoking cache_release()
Date: Fri, 14 May 2021 01:30:36 +0200	[thread overview]
Message-ID: <20210513233036.GA26534@salvia> (raw)
In-Reply-To: <20210513141031.213490-1-marco.oliverio@tanaza.com>

On Thu, May 13, 2021 at 04:10:32PM +0200, Marco Oliverio wrote:
> if genid changes during cache_init(), check_genid() sets errno to EINTR to force
> a re-init of the cache.
> 
> cache_release() may inadvertly change errno by calling free().  Indeed free()
> may invoke madvise() that changes errno to ENOSYS on system where kernel is
> configured without support for this syscall.

Applied, thanks.

      reply	other threads:[~2021-05-13 23:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13 14:10 [nftables PATCH] cache: check errno before invoking cache_release() Marco Oliverio
2021-05-13 23:30 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210513233036.GA26534@salvia \
    --to=pablo@netfilter.org \
    --cc=marco.oliverio@tanaza.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.