From: "Darrick J. Wong" <djwong@kernel.org>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH RESEND v18 05/11] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete
Date: Thu, 13 May 2021 17:41:37 -0700 [thread overview]
Message-ID: <20210514004137.GF9675@magnolia> (raw)
In-Reply-To: <20210513234913.GE9675@magnolia>
On Thu, May 13, 2021 at 04:49:13PM -0700, Darrick J. Wong wrote:
> On Wed, May 12, 2021 at 09:14:02AM -0700, Allison Henderson wrote:
> > This patch separate xfs_attr_node_addname into two functions. This will
> > help to make it easier to hoist parts of xfs_attr_node_addname that need
> > state management
> >
> > Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
> > Reviewed-by: Brian Foster <bfoster@redhat.com>
> > Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
>
> Makes sense...
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> --D
>
> > ---
> > fs/xfs/libxfs/xfs_attr.c | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> > index 1a618a2..5cf2e71 100644
> > --- a/fs/xfs/libxfs/xfs_attr.c
> > +++ b/fs/xfs/libxfs/xfs_attr.c
> > @@ -54,6 +54,7 @@ STATIC int xfs_attr_leaf_hasname(struct xfs_da_args *args, struct xfs_buf **bp);
> > STATIC int xfs_attr_node_get(xfs_da_args_t *args);
> > STATIC int xfs_attr_node_addname(xfs_da_args_t *args);
> > STATIC int xfs_attr_node_removename(xfs_da_args_t *args);
> > +STATIC int xfs_attr_node_addname_clear_incomplete(struct xfs_da_args *args);
> > STATIC int xfs_attr_node_hasname(xfs_da_args_t *args,
> > struct xfs_da_state **state);
> > STATIC int xfs_attr_fillstate(xfs_da_state_t *state);
> > @@ -1073,6 +1074,28 @@ xfs_attr_node_addname(
> > return error;
> > }
> >
> > + error = xfs_attr_node_addname_clear_incomplete(args);
> > + if (error)
> > + goto out;
> > + retval = 0;
> > +out:
> > + if (state)
> > + xfs_da_state_free(state);
> > + if (error)
> > + return error;
> > + return retval;
> > +}
> > +
> > +
> > +STATIC
> > +int xfs_attr_node_addname_clear_incomplete(
...well, so long as this gets changed to:
STATIC int
xfs_attr_node_addname_clear_incomplete
--D
> > + struct xfs_da_args *args)
> > +{
> > + struct xfs_da_state *state = NULL;
> > + struct xfs_da_state_blk *blk;
> > + int retval = 0;
> > + int error = 0;
> > +
> > /*
> > * Re-find the "old" attribute entry after any split ops. The INCOMPLETE
> > * flag means that we will find the "old" attr, not the "new" one.
> > --
> > 2.7.4
> >
next prev parent reply other threads:[~2021-05-14 0:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 16:13 [PATCH RESEND v18 00/11] Delay Ready Attributes Allison Henderson
2021-05-12 16:13 ` [PATCH RESEND v18 01/11] xfs: Reverse apply 72b97ea40d Allison Henderson
2021-05-13 23:14 ` Darrick J. Wong
2021-05-12 16:13 ` [PATCH RESEND v18 02/11] xfs: Add xfs_attr_node_remove_name Allison Henderson
2021-05-12 16:14 ` [PATCH RESEND v18 03/11] xfs: Hoist xfs_attr_set_shortform Allison Henderson
2021-05-12 16:14 ` [PATCH RESEND v18 04/11] xfs: Add helper xfs_attr_set_fmt Allison Henderson
2021-05-13 23:46 ` Darrick J. Wong
2021-05-15 5:42 ` Allison Henderson
2021-05-15 15:40 ` Darrick J. Wong
2021-05-12 16:14 ` [PATCH RESEND v18 05/11] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete Allison Henderson
2021-05-13 23:49 ` Darrick J. Wong
2021-05-14 0:41 ` Darrick J. Wong [this message]
2021-05-15 5:41 ` Allison Henderson
2021-05-12 16:14 ` [PATCH RESEND v18 06/11] xfs: Add helper xfs_attr_node_addname_find_attr Allison Henderson
2021-05-12 16:14 ` [PATCH RESEND v18 07/11] xfs: Hoist xfs_attr_node_addname Allison Henderson
2021-05-12 16:14 ` [PATCH RESEND v18 08/11] xfs: Hoist xfs_attr_leaf_addname Allison Henderson
2021-05-12 16:14 ` [PATCH RESEND v18 09/11] xfs: Hoist node transaction handling Allison Henderson
2021-05-12 16:14 ` [PATCH RESEND v18 10/11] xfs: Add delay ready attr remove routines Allison Henderson
2021-05-14 0:46 ` Darrick J. Wong
2021-05-15 5:41 ` Allison Henderson
2021-05-15 15:28 ` Darrick J. Wong
2021-05-12 16:14 ` [PATCH RESEND v18 11/11] xfs: Add delay ready attr set routines Allison Henderson
2021-05-14 1:14 ` Darrick J. Wong
2021-05-15 5:41 ` Allison Henderson
2021-05-15 15:32 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514004137.GF9675@magnolia \
--to=djwong@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.