From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Vineet Gupta <vgupta@synopsys.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Brian Cain <bcain@codeaurora.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Sid Manning <sidneym@codeaurora.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
uclinux-h8-devel@lists.sourceforge.jp,
linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org, linux-um@lists.infradead.org
Subject: Re: [PATCH 3/6] [v2] hexagon: use generic strncpy/strnlen from_user
Date: Mon, 17 May 2021 08:16:35 +0200 [thread overview]
Message-ID: <20210517061635.GA23581@lst.de> (raw)
In-Reply-To: <20210515101803.924427-4-arnd@kernel.org>
On Sat, May 15, 2021 at 12:18:00PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Most per-architecture versions of these functions are broken in some form,
> and they are almost certainly slower than the generic code as well.
>
> Remove the ones for hexagon and instead use the generic version.
> This custom version reads the data twice for strncpy() by doing an extra
> strnlen(), and it apparently lacks a check for user_addr_max().
I'd be tempted to just remove the first paragraph and reword the second
as:
Remove the hexagon implementation of strncpy/strnlen and instead use the
generic versions. The hexago version of strncpy reads the data twice by
doing an extra strnlen(), and it apparently lacks a check for
user_addr_max().
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Vineet Gupta <vgupta@synopsys.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Brian Cain <bcain@codeaurora.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Sid Manning <sidneym@codeaurora.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger
Subject: Re: [PATCH 3/6] [v2] hexagon: use generic strncpy/strnlen from_user
Date: Mon, 17 May 2021 08:16:35 +0200 [thread overview]
Message-ID: <20210517061635.GA23581@lst.de> (raw)
In-Reply-To: <20210515101803.924427-4-arnd@kernel.org>
On Sat, May 15, 2021 at 12:18:00PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Most per-architecture versions of these functions are broken in some form,
> and they are almost certainly slower than the generic code as well.
>
> Remove the ones for hexagon and instead use the generic version.
> This custom version reads the data twice for strncpy() by doing an extra
> strnlen(), and it apparently lacks a check for user_addr_max().
I'd be tempted to just remove the first paragraph and reword the second
as:
Remove the hexagon implementation of strncpy/strnlen and instead use the
generic versions. The hexago version of strncpy reads the data twice by
doing an extra strnlen(), and it apparently lacks a check for
user_addr_max().
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Vineet Gupta <vgupta@synopsys.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Brian Cain <bcain@codeaurora.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Sid Manning <sidneym@codeaurora.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
uclinux-h8-devel@lists.sourceforge.jp,
linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org, linux-um@lists.infradead.org
Subject: Re: [PATCH 3/6] [v2] hexagon: use generic strncpy/strnlen from_user
Date: Mon, 17 May 2021 08:16:35 +0200 [thread overview]
Message-ID: <20210517061635.GA23581@lst.de> (raw)
In-Reply-To: <20210515101803.924427-4-arnd@kernel.org>
On Sat, May 15, 2021 at 12:18:00PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Most per-architecture versions of these functions are broken in some form,
> and they are almost certainly slower than the generic code as well.
>
> Remove the ones for hexagon and instead use the generic version.
> This custom version reads the data twice for strncpy() by doing an extra
> strnlen(), and it apparently lacks a check for user_addr_max().
I'd be tempted to just remove the first paragraph and reword the second
as:
Remove the hexagon implementation of strncpy/strnlen and instead use the
generic versions. The hexago version of strncpy reads the data twice by
doing an extra strnlen(), and it apparently lacks a check for
user_addr_max().
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Vineet Gupta <vgupta@synopsys.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Brian Cain <bcain@codeaurora.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Sid Manning <sidneym@codeaurora.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
uclinux-h8-devel@lists.sourceforge.jp,
linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org, linux-um@lists.infradead.org
Subject: Re: [PATCH 3/6] [v2] hexagon: use generic strncpy/strnlen from_user
Date: Mon, 17 May 2021 08:16:35 +0200 [thread overview]
Message-ID: <20210517061635.GA23581@lst.de> (raw)
In-Reply-To: <20210515101803.924427-4-arnd@kernel.org>
On Sat, May 15, 2021 at 12:18:00PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Most per-architecture versions of these functions are broken in some form,
> and they are almost certainly slower than the generic code as well.
>
> Remove the ones for hexagon and instead use the generic version.
> This custom version reads the data twice for strncpy() by doing an extra
> strnlen(), and it apparently lacks a check for user_addr_max().
I'd be tempted to just remove the first paragraph and reword the second
as:
Remove the hexagon implementation of strncpy/strnlen and instead use the
generic versions. The hexago version of strncpy reads the data twice by
doing an extra strnlen(), and it apparently lacks a check for
user_addr_max().
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2021-05-17 6:16 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 10:17 [PATCH 0/6] [v2] asm-generic: strncpy_from_user/strnlen_user cleanup Arnd Bergmann
2021-05-15 10:17 ` Arnd Bergmann
2021-05-15 10:17 ` Arnd Bergmann
2021-05-15 10:17 ` Arnd Bergmann
2021-05-15 10:17 ` [PATCH 1/6] [v2] asm-generic/uaccess.h: remove __strncpy_from_user/__strnlen_user Arnd Bergmann
2021-05-15 10:17 ` Arnd Bergmann
2021-05-15 10:17 ` Arnd Bergmann
2021-05-15 10:17 ` Arnd Bergmann
2021-05-15 10:17 ` [PATCH 2/6] [v2] h8300: remove stale strncpy_from_user Arnd Bergmann
2021-05-15 10:17 ` Arnd Bergmann
2021-05-15 10:17 ` Arnd Bergmann
2021-05-15 10:17 ` Arnd Bergmann
2021-05-15 10:18 ` [PATCH 3/6] [v2] hexagon: use generic strncpy/strnlen from_user Arnd Bergmann
2021-05-15 10:18 ` Arnd Bergmann
2021-05-15 10:18 ` Arnd Bergmann
2021-05-17 6:16 ` Christoph Hellwig [this message]
2021-05-17 6:16 ` Christoph Hellwig
2021-05-17 6:16 ` Christoph Hellwig
2021-05-17 6:16 ` Christoph Hellwig
2021-05-17 6:46 ` Arnd Bergmann
2021-05-17 6:46 ` Arnd Bergmann
2021-05-17 6:46 ` Arnd Bergmann
2021-05-17 6:46 ` Arnd Bergmann
2021-05-15 10:18 ` [PATCH 4/6] [v2] arc: " Arnd Bergmann
2021-05-15 10:18 ` Arnd Bergmann
2021-05-15 10:18 ` Arnd Bergmann
2021-05-17 6:16 ` Christoph Hellwig
2021-05-17 6:16 ` Christoph Hellwig
2021-05-17 6:16 ` Christoph Hellwig
2021-05-17 6:16 ` Christoph Hellwig
2021-05-17 6:47 ` Arnd Bergmann
2021-05-17 6:47 ` Arnd Bergmann
2021-05-17 6:47 ` Arnd Bergmann
2021-05-17 6:47 ` Arnd Bergmann
2021-05-15 10:18 ` [PATCH 5/6] [v2] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user Arnd Bergmann
2021-05-15 10:18 ` Arnd Bergmann
2021-05-15 10:18 ` Arnd Bergmann
2021-05-17 6:20 ` Christoph Hellwig
2021-05-17 6:20 ` Christoph Hellwig
2021-05-17 6:20 ` Christoph Hellwig
2021-05-17 6:20 ` Christoph Hellwig
2021-05-17 7:27 ` Arnd Bergmann
2021-05-17 7:27 ` Arnd Bergmann
2021-05-17 7:27 ` Arnd Bergmann
2021-05-17 7:27 ` Arnd Bergmann
2021-05-15 10:18 ` [PATCH 6/6] [v2] asm-generic: remove extra strn{cpy_from,len}_user declarations Arnd Bergmann
2021-05-15 10:18 ` [PATCH 6/6] [v2] asm-generic: remove extra strn{cpy_from, len}_user declarations Arnd Bergmann
2021-05-15 10:18 ` Arnd Bergmann
2021-05-15 10:18 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517061635.GA23581@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bcain@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=jdike@addtoit.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richard@nod.at \
--cc=rppt@kernel.org \
--cc=sidneym@codeaurora.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=vgupta@synopsys.com \
--cc=viro@zeniv.linux.org.uk \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.