From: Christoph Hellwig <hch@lst.de>
To: Martin Wilck <mwilck@suse.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org,
Daniel Wagner <daniel.wagner@suse.com>,
kbusch@kernel.org, sagi@grimberg.me
Subject: Re: [PATCH] nvme-multipath: fix double initialization of ANA state
Date: Mon, 17 May 2021 14:48:01 +0200 [thread overview]
Message-ID: <20210517124801.GA17259@lst.de> (raw)
In-Reply-To: <23286bbda8b62afcb8bc0ce0d4deb655197cf8a7.camel@suse.com>
On Fri, May 14, 2021 at 11:08:25PM +0200, Martin Wilck wrote:
> Hello Christoph,
>
> On Wed, 2021-05-12 at 16:53 +0200, Martin Wilck wrote:
> > On Thu, 2021-05-06 at 15:48 +0200, Christoph Hellwig wrote:
> > > nvme_init_identify and thus nvme_mpath_init can be called multiple
> > > times and thus must not overwrite potentially initialized or in-use
> > > fields. Split out a helper for the basic initialization when the
> > > controller is initialized and make sure the init_identify path does
> > > not blindly change in-use data structures.
> > >
> > > Fixes: 0d0b660f214d ("nvme: add ANA support")
> > > Reported-by: Martin Wilck <mwilck@suse.com>
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Thank you. I'll prepare another test kernel for our partner.
>
> Our partner reported a crash during NVMe controller initialization with
> the kernel I built with this patch applied. I'm still looking at the
> dump, and it's not impossible that I made a mistake backporting your
> patch. But I thought I should inform you anyway.
It does look weird for sure. Did you backport
"nvmet: use new ana_log_size instead the old one" as well? If not please
pick it up.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-17 12:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 13:48 [PATCH] nvme-multipath: fix double initialization of ANA state Christoph Hellwig
2021-05-06 14:51 ` Keith Busch
2021-05-07 16:54 ` Hannes Reinecke
2021-05-07 17:16 ` Sagi Grimberg
2021-05-12 14:53 ` Martin Wilck
2021-05-14 21:08 ` Martin Wilck
2021-05-14 23:05 ` Sagi Grimberg
2021-05-17 12:48 ` Christoph Hellwig [this message]
2021-05-17 16:47 ` Martin Wilck
2021-05-17 16:49 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517124801.GA17259@lst.de \
--to=hch@lst.de \
--cc=daniel.wagner@suse.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mwilck@suse.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.