From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCHv3] nvme: generate uevent once a multipath namespace is operational again
Date: Tue, 18 May 2021 09:05:44 +0200 [thread overview]
Message-ID: <20210518070544.GA8521@lst.de> (raw)
In-Reply-To: <2174fba2-9c43-b92c-ea73-da59cd91d3ca@suse.de>
On Tue, May 18, 2021 at 08:59:09AM +0200, Hannes Reinecke wrote:
>> I asked this on v1, is this only needed for mpath devices?
>
> Yes; we need to send the KOBJ_CHANGE event on the mpath device as it's not
> backed by hardware. The only non-multipathed devices I've seen so far are
> PCI devices where events are generated by the PCI device itself.
Which really goes back to my repeared request to add a comment to the
code to document why we need this uevent. It surely looks out of place
and it seems Hannes can tell a story of why it is required. I'd really
like to see that story next to the call.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-18 7:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 8:32 [PATCHv3] nvme: generate uevent once a multipath namespace is operational again Hannes Reinecke
2021-05-17 17:49 ` Sagi Grimberg
2021-05-18 6:59 ` Hannes Reinecke
2021-05-18 7:05 ` Christoph Hellwig [this message]
2021-05-18 7:49 ` Hannes Reinecke
2021-05-18 18:00 ` Sagi Grimberg
2021-05-18 18:09 ` Hannes Reinecke
2021-05-18 18:39 ` Sagi Grimberg
2021-05-18 18:49 ` Hannes Reinecke
2021-05-18 19:04 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518070544.GA8521@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.