From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/jh71xx-tools: new package
Date: Tue, 18 May 2021 17:45:44 +0200 [thread overview]
Message-ID: <20210518174544.2a48bcf5@windsurf.orange-hotspot> (raw)
In-Reply-To: <20210515121534.GF2506@scaer>
Hello,
On Sat, 15 May 2021 14:15:34 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > + source "package/jh71xx-tools/Config.in.host"
>
> Alphabetical order fixed, as spotted by Bin.
Thanks! It is interesting that this was not spotted by check-package.
> > +JH71XX_TOOLS_VERSION = 7a29f4b9d2355aa39afa8680680909bb74e4991d
> > +JH71XX_TOOLS_SITE = $(call github,kprasadvnsi,JH71xx-tools,$(JH71XX_TOOLS_VERSION))
> > +JH71XX_TOOLS_LICENSE = MIT
> > +JH71XX_TOOLS_LICENSE_FILES = jh7100-recover.c
>
> Not sure why you choose to use the source file as license file, when
> there is an actual LICENSE file in the tree. So I've switched to using
> that.
I'm not sure how I missed that, because I remember I looked at the code
base and thought "meh, there is no license file, I should file a github
issue about this". Anyway, you fixed it, so thanks for that!
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-05-18 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 22:03 [Buildroot] [PATCH 0/2] Add jh71xx-tools package Thomas Petazzoni
2021-05-14 22:03 ` [Buildroot] [PATCH 1/2] package/jh71xx-tools: new package Thomas Petazzoni
2021-05-15 0:05 ` Bin Meng
2021-05-15 12:15 ` Yann E. MORIN
2021-05-18 15:45 ` Thomas Petazzoni [this message]
2021-05-14 22:03 ` [Buildroot] [PATCH 2/2] configs/beaglev: enable host jh71xx-tools Thomas Petazzoni
2021-05-15 0:05 ` Bin Meng
2021-05-15 12:16 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518174544.2a48bcf5@windsurf.orange-hotspot \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.