Re: [PATCH] Avoid potentially erroneos RST drop.

[Florian Westphal <fw@strlen.de>]

Ali Abdallah <ali.abdallah@suse.com> wrote:
> On 05.05.2021 21:53, Florian Westphal wrote:
> > Ali, sorry for coming back to this again and again.
> > 
> > What do you think of this change?
> 
> Hi Florian, I tested your patch and it solved the issue, no more NFS
> hangs due to dropped RSTs. Please include it, together with the
> following two patches I previously sent:
> 
> https://patchwork.ozlabs.org/project/netfilter-devel/patch/20210428130911.cteglt52r5if7ynp@Fryzen495/

Do we still need this one after this revised patch?
If we do, the help text has to be fixed, after your patch, be-liberal
turns off all sequence number/window checks.  The revised text implies
it only has to do with RSTs.

Alternative would be to add another sysctl, or turn the existing sysctl
into integer (0, off, 1 current behaviour (sequence check on for rst
only, 2 off for everything).

> https://patchwork.ozlabs.org/project/netfilter-devel/patch/20210430093601.zibczc4cjnwx3qwn@Fryzen495/

I will send this patch for inclusion tomorrow or later today.

Pablo, please mark both patches as "Changes Requested".

I will deal with the 2nd patch and will resend it, with the more liberal
handing of RST when conntrack entry is closing.

Ali, if you still think the first patch is required please submit a new
version with at least a revised help text.