From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corey Minyard Date: Wed, 19 May 2021 07:34:01 -0500 Subject: [PATCH v3 0/7] Add Aspeed SSIF BMC driver In-Reply-To: <20210519074934.20712-1-quan@os.amperecomputing.com> References: <20210519074934.20712-1-quan@os.amperecomputing.com> Message-ID: <20210519123401.GG2921206@minyard.net> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, May 19, 2021 at 02:49:27PM +0700, Quan Nguyen wrote: > This series add support for the Aspeed specific SSIF BMC driver which > is to perform in-band IPMI communication with the host in management > (BMC) side. > > v3: > + Switched binding doc to use DT schema format [Rob] > + Splited into generic ssif_bmc and aspeed-specific [Corey, Joel] > + Removed redundant license info [Joel] > + Switched to use traditional if-else [Joel] > + Removed unused ssif_bmc_ioctl() [Joel] > + Made handle_request()/complete_response() to return void [Joel] > + Refactored send_ssif_bmc_response()/receive_ssif_bmc_request() [Corey] > + Remove mutex [Corey] > + Use spin_lock/unlock_irqsave/restore in callback [Corey] > + Removed the unnecessary memset [Corey] > + Switch to use dev_err() [Corey] > + Combine mask/unmask two interrupts together [Corey] > + Fixed unhandled Tx done with NAK [Quan] > + Late ack'ed Tx done w/wo Ack irq [Quan] > + Use aspeed-specific exported aspeed_set_slave_busy() when slave busy > to fix the deadlock [Graeme, Philipp, Quan] > + Clean buffer for last multipart read [Quan] > + Handle unknown incoming command [Quan] > > v2: > + Fixed compiling error with COMPILE_TEST for arc > > Quan Nguyen (7): > i2c: i2c-core-smbus: Expose PEC calculate function for generic use Note that for this I2C-specific change, I will need acks from the I2C maintainers to be able to include this in my tree. > ipmi: ssif_bmc: Add SSIF BMC driver > i2c: aspeed: Fix unhandled Tx done with NAK For the aspeed changes, they don't really belong here, they belong in the aspeed tree. I see that you need them for the device to work correctly, though. I'll need acks from maintainers to include them. > i2c: aspeed: Acknowledge Tx done w/wo ACK irq late > i2c: aspeed: Add aspeed_set_slave_busy() > ipmi: ssif_bmc: Add Aspeed SSIF BMC driver > bindings: ipmi: Add binding for Aspeed SSIF BMC driver > > .../bindings/ipmi/aspeed-ssif-bmc.yaml | 33 + > drivers/char/ipmi/Kconfig | 22 + > drivers/char/ipmi/Makefile | 2 + > drivers/char/ipmi/ssif_bmc.c | 605 ++++++++++++++++++ > drivers/char/ipmi/ssif_bmc.h | 93 +++ > drivers/char/ipmi/ssif_bmc_aspeed.c | 75 +++ > drivers/i2c/busses/i2c-aspeed.c | 51 +- > drivers/i2c/i2c-core-smbus.c | 12 +- > include/linux/i2c.h | 1 + > 9 files changed, 884 insertions(+), 10 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.yaml > create mode 100644 drivers/char/ipmi/ssif_bmc.c > create mode 100644 drivers/char/ipmi/ssif_bmc.h > create mode 100644 drivers/char/ipmi/ssif_bmc_aspeed.c > > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34ADEC43460 for ; Wed, 19 May 2021 12:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A02C613AD for ; Wed, 19 May 2021 12:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346441AbhESMfY (ORCPT ); Wed, 19 May 2021 08:35:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230423AbhESMfY (ORCPT ); Wed, 19 May 2021 08:35:24 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D98C061760; Wed, 19 May 2021 05:34:04 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id j75so12910201oih.10; Wed, 19 May 2021 05:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=VrjofVBqpi4EHgG9TcMkr4kH1OnwVdI3jKjQrhy1Fug=; b=WSbmTBjMuGsiyyywp5Dh3Q3mVYW2nbZQjg0K6XpN0ym7Jrl7a5IQuCF3IA3QXe4shk Ng8JJSYbNTWhKXk9LZm6Ks6Q4VkQ67uzl+BHacClNTEsfVOw/4DTeqzd/8NTDS2Xbk0Z ta+hXBtHynyG4MWZyKPg6/es2FymwlidZMkU7Z+7qGt2kU16NoC7yi0X/hKPBlybJxLS nW30UfL3+CWamV4v6eEu79DvmCx7vOijxZNl6iGcLa6U530GJ6DakL3VwL2DteDB0c9M xoJXf0W7rhuoTQrHKa1N7zPYAfPaMS9yiITcKYvZaU4xDeDvS0H6OHndrcIElujRWsT0 j8+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=VrjofVBqpi4EHgG9TcMkr4kH1OnwVdI3jKjQrhy1Fug=; b=TwBGtqkPxxYQkCBgm+7AxeQuNqihyDhR8AIujeE/pXteuIpfAbDotYEe3DAPYkEhAj fcr6jpdFOw3aux34XphR9wpx5KnR1b5x8j/8XfYCKfnPmsCT1qVmItYjO/iJLhxuxA+q zD0Da4qpgFQRdToiEuiGnC4LoG3ld0T0szG6pD3UWxkYvHaJVtmrCEm4DUmNoYfaml9L HlJEpgl3lkICqRArffqCt6rumDgSu3Oeid1FUuwTZm10IUljH0yJhNXHVStwvprNAT7E gwPDQTfr1UWx4aca6WrL+S1h1b0RmhMzHgyqLl4sRXvRD+sXfkd93qUVGL26uEB4dp2X pEBQ== X-Gm-Message-State: AOAM531WZeqO4L+iNFQVt/a5J435qtOHYZRPOWiWwJWedbSqCNmBvI5e q8SuVPPqq8Eib9WDqHusjg== X-Google-Smtp-Source: ABdhPJzF+Fy8did2QXIYwMFyj+Pr3q+myW/DhiifWrK0n5h2AtQhvpL+QDG4LfcQO07Tc5btOdZCGg== X-Received: by 2002:aca:b5c4:: with SMTP id e187mr8250914oif.149.1621427643980; Wed, 19 May 2021 05:34:03 -0700 (PDT) Received: from serve.minyard.net ([47.184.156.158]) by smtp.gmail.com with ESMTPSA id x78sm888530ooa.15.2021.05.19.05.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 05:34:03 -0700 (PDT) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:9144:ba66:ea13:f260]) by serve.minyard.net (Postfix) with ESMTPSA id 93A3618000C; Wed, 19 May 2021 12:34:02 +0000 (UTC) Date: Wed, 19 May 2021 07:34:01 -0500 From: Corey Minyard To: Quan Nguyen Cc: Rob Herring , Joel Stanley , Andrew Jeffery , Brendan Higgins , Benjamin Herrenschmidt , Wolfram Sang , Philipp Zabel , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" , openbmc@lists.ozlabs.org Subject: Re: [PATCH v3 0/7] Add Aspeed SSIF BMC driver Message-ID: <20210519123401.GG2921206@minyard.net> Reply-To: minyard@acm.org References: <20210519074934.20712-1-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519074934.20712-1-quan@os.amperecomputing.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, May 19, 2021 at 02:49:27PM +0700, Quan Nguyen wrote: > This series add support for the Aspeed specific SSIF BMC driver which > is to perform in-band IPMI communication with the host in management > (BMC) side. > > v3: > + Switched binding doc to use DT schema format [Rob] > + Splited into generic ssif_bmc and aspeed-specific [Corey, Joel] > + Removed redundant license info [Joel] > + Switched to use traditional if-else [Joel] > + Removed unused ssif_bmc_ioctl() [Joel] > + Made handle_request()/complete_response() to return void [Joel] > + Refactored send_ssif_bmc_response()/receive_ssif_bmc_request() [Corey] > + Remove mutex [Corey] > + Use spin_lock/unlock_irqsave/restore in callback [Corey] > + Removed the unnecessary memset [Corey] > + Switch to use dev_err() [Corey] > + Combine mask/unmask two interrupts together [Corey] > + Fixed unhandled Tx done with NAK [Quan] > + Late ack'ed Tx done w/wo Ack irq [Quan] > + Use aspeed-specific exported aspeed_set_slave_busy() when slave busy > to fix the deadlock [Graeme, Philipp, Quan] > + Clean buffer for last multipart read [Quan] > + Handle unknown incoming command [Quan] > > v2: > + Fixed compiling error with COMPILE_TEST for arc > > Quan Nguyen (7): > i2c: i2c-core-smbus: Expose PEC calculate function for generic use Note that for this I2C-specific change, I will need acks from the I2C maintainers to be able to include this in my tree. > ipmi: ssif_bmc: Add SSIF BMC driver > i2c: aspeed: Fix unhandled Tx done with NAK For the aspeed changes, they don't really belong here, they belong in the aspeed tree. I see that you need them for the device to work correctly, though. I'll need acks from maintainers to include them. > i2c: aspeed: Acknowledge Tx done w/wo ACK irq late > i2c: aspeed: Add aspeed_set_slave_busy() > ipmi: ssif_bmc: Add Aspeed SSIF BMC driver > bindings: ipmi: Add binding for Aspeed SSIF BMC driver > > .../bindings/ipmi/aspeed-ssif-bmc.yaml | 33 + > drivers/char/ipmi/Kconfig | 22 + > drivers/char/ipmi/Makefile | 2 + > drivers/char/ipmi/ssif_bmc.c | 605 ++++++++++++++++++ > drivers/char/ipmi/ssif_bmc.h | 93 +++ > drivers/char/ipmi/ssif_bmc_aspeed.c | 75 +++ > drivers/i2c/busses/i2c-aspeed.c | 51 +- > drivers/i2c/i2c-core-smbus.c | 12 +- > include/linux/i2c.h | 1 + > 9 files changed, 884 insertions(+), 10 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.yaml > create mode 100644 drivers/char/ipmi/ssif_bmc.c > create mode 100644 drivers/char/ipmi/ssif_bmc.h > create mode 100644 drivers/char/ipmi/ssif_bmc_aspeed.c > > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46AAEC433ED for ; Wed, 19 May 2021 12:34:35 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88BCA6108B for ; Wed, 19 May 2021 12:34:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88BCA6108B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FlXPP0sBXz302f for ; Wed, 19 May 2021 22:34:33 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=WSbmTBjM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::230; helo=mail-oi1-x230.google.com; envelope-from=tcminyard@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=WSbmTBjM; dkim-atps=neutral Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FlXNv2M9pz2xZZ; Wed, 19 May 2021 22:34:06 +1000 (AEST) Received: by mail-oi1-x230.google.com with SMTP id v22so12968389oic.2; Wed, 19 May 2021 05:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=VrjofVBqpi4EHgG9TcMkr4kH1OnwVdI3jKjQrhy1Fug=; b=WSbmTBjMuGsiyyywp5Dh3Q3mVYW2nbZQjg0K6XpN0ym7Jrl7a5IQuCF3IA3QXe4shk Ng8JJSYbNTWhKXk9LZm6Ks6Q4VkQ67uzl+BHacClNTEsfVOw/4DTeqzd/8NTDS2Xbk0Z ta+hXBtHynyG4MWZyKPg6/es2FymwlidZMkU7Z+7qGt2kU16NoC7yi0X/hKPBlybJxLS nW30UfL3+CWamV4v6eEu79DvmCx7vOijxZNl6iGcLa6U530GJ6DakL3VwL2DteDB0c9M xoJXf0W7rhuoTQrHKa1N7zPYAfPaMS9yiITcKYvZaU4xDeDvS0H6OHndrcIElujRWsT0 j8+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=VrjofVBqpi4EHgG9TcMkr4kH1OnwVdI3jKjQrhy1Fug=; b=UBHxJ6iiLvYEKqj5GS2lBbDaw8km91kNTHJvxXJbp/s64BiQlvpMjqdFSn1giaryiJ k7cN7OONp/lTLQxmoU5pg5CoNThXUPP5Agu7yYRWIVQsuLDUQB61rBMlrrsOp8cT+vOr yq9ijUhQYsFWX0FzjGuIOGTpJ8FaHhQovyjrLJ4hZM06oC2vdQkDINAfcfx4uwzL9da0 c70Dj2dZiMMb3W9JptuDpAjag0UWNA495Ja1mRjbZjucFUOpIZZAlIu9nrpvLGMOgWgB DDYUuRF7kGvJV88kniGZJ2cl210FHGGRmRVPC+EKiSCuHJtNnib8u0VDZiqMgx5SH0gV FcGg== X-Gm-Message-State: AOAM532PglxLW11nX3I//u+zLN1QEuIIF5L52E5gXwr61OoLYxuarZdj jT9/cA7zxVL/maagNwgFmg== X-Google-Smtp-Source: ABdhPJzF+Fy8did2QXIYwMFyj+Pr3q+myW/DhiifWrK0n5h2AtQhvpL+QDG4LfcQO07Tc5btOdZCGg== X-Received: by 2002:aca:b5c4:: with SMTP id e187mr8250914oif.149.1621427643980; Wed, 19 May 2021 05:34:03 -0700 (PDT) Received: from serve.minyard.net ([47.184.156.158]) by smtp.gmail.com with ESMTPSA id x78sm888530ooa.15.2021.05.19.05.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 05:34:03 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:9144:ba66:ea13:f260]) by serve.minyard.net (Postfix) with ESMTPSA id 93A3618000C; Wed, 19 May 2021 12:34:02 +0000 (UTC) Date: Wed, 19 May 2021 07:34:01 -0500 From: Corey Minyard To: Quan Nguyen Subject: Re: [PATCH v3 0/7] Add Aspeed SSIF BMC driver Message-ID: <20210519123401.GG2921206@minyard.net> References: <20210519074934.20712-1-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519074934.20712-1-quan@os.amperecomputing.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Andrew Jeffery , openbmc@lists.ozlabs.org, "Thang Q . Nguyen" , Brendan Higgins , linux-kernel@vger.kernel.org, Phong Vo , Wolfram Sang , Rob Herring , Philipp Zabel , openipmi-developer@lists.sourceforge.net, Open Source Submission , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Wed, May 19, 2021 at 02:49:27PM +0700, Quan Nguyen wrote: > This series add support for the Aspeed specific SSIF BMC driver which > is to perform in-band IPMI communication with the host in management > (BMC) side. > > v3: > + Switched binding doc to use DT schema format [Rob] > + Splited into generic ssif_bmc and aspeed-specific [Corey, Joel] > + Removed redundant license info [Joel] > + Switched to use traditional if-else [Joel] > + Removed unused ssif_bmc_ioctl() [Joel] > + Made handle_request()/complete_response() to return void [Joel] > + Refactored send_ssif_bmc_response()/receive_ssif_bmc_request() [Corey] > + Remove mutex [Corey] > + Use spin_lock/unlock_irqsave/restore in callback [Corey] > + Removed the unnecessary memset [Corey] > + Switch to use dev_err() [Corey] > + Combine mask/unmask two interrupts together [Corey] > + Fixed unhandled Tx done with NAK [Quan] > + Late ack'ed Tx done w/wo Ack irq [Quan] > + Use aspeed-specific exported aspeed_set_slave_busy() when slave busy > to fix the deadlock [Graeme, Philipp, Quan] > + Clean buffer for last multipart read [Quan] > + Handle unknown incoming command [Quan] > > v2: > + Fixed compiling error with COMPILE_TEST for arc > > Quan Nguyen (7): > i2c: i2c-core-smbus: Expose PEC calculate function for generic use Note that for this I2C-specific change, I will need acks from the I2C maintainers to be able to include this in my tree. > ipmi: ssif_bmc: Add SSIF BMC driver > i2c: aspeed: Fix unhandled Tx done with NAK For the aspeed changes, they don't really belong here, they belong in the aspeed tree. I see that you need them for the device to work correctly, though. I'll need acks from maintainers to include them. > i2c: aspeed: Acknowledge Tx done w/wo ACK irq late > i2c: aspeed: Add aspeed_set_slave_busy() > ipmi: ssif_bmc: Add Aspeed SSIF BMC driver > bindings: ipmi: Add binding for Aspeed SSIF BMC driver > > .../bindings/ipmi/aspeed-ssif-bmc.yaml | 33 + > drivers/char/ipmi/Kconfig | 22 + > drivers/char/ipmi/Makefile | 2 + > drivers/char/ipmi/ssif_bmc.c | 605 ++++++++++++++++++ > drivers/char/ipmi/ssif_bmc.h | 93 +++ > drivers/char/ipmi/ssif_bmc_aspeed.c | 75 +++ > drivers/i2c/busses/i2c-aspeed.c | 51 +- > drivers/i2c/i2c-core-smbus.c | 12 +- > include/linux/i2c.h | 1 + > 9 files changed, 884 insertions(+), 10 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.yaml > create mode 100644 drivers/char/ipmi/ssif_bmc.c > create mode 100644 drivers/char/ipmi/ssif_bmc.h > create mode 100644 drivers/char/ipmi/ssif_bmc_aspeed.c > > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D7BC433B4 for ; Wed, 19 May 2021 12:36:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FE316124C for ; Wed, 19 May 2021 12:36:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FE316124C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xTmJIZSEa37jotRQ0pFyBma/RfQ2S+84UZ5nGa6tVK0=; b=qQ0R+BDLwXa0IrakW4RllGrL6 86jPdqxtSXjcr7tZuf7upfjFGvJL+zchMhhYD1VMOqbB9I6rn6ssdAhHvqDCISU1naQX3EdSUHJQU Lxivl87jJOakkk4t1B/gZOXc+LEadFE1AkIeXxNXfHNKzUgEWEyctNYQRRwNruC6ixNrX3PIgaYHO j4V74FnDg5haPLhujTtR4Ol0l04rvsJ1eJarAYJZHG2cFesry5SNZ7y6nIyPS/78gTpbJLCFqx94W x/Bfa9gburwm8+ik8ppNF8q4knVTA+dsDKgl2E8YnQiyzI9BHBIkln/OUEn4Scm1UjPG7yS4itKOx FvkAK6mmA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljLOu-003vAA-QE; Wed, 19 May 2021 12:34:13 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljLOq-003v9N-SJ for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 12:34:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VrjofVBqpi4EHgG9TcMkr4kH1OnwVdI3jKjQrhy1Fug=; b=S4wEqngZXPA0QUH9dqhbHzvOhg qYREQ/6VZavv/g3NKVeqdOf7UApkRZInYtnk7Byr9g6GU7oiCTC4dQmxW/x/C9bxAAUcWVT/uw4bE CEzOgU2lBY5LYEFxihB4NnukOkEhcX+J+8sD4Q9OvymRFZVtjDqIJ9Tk6geTXMiSWVE+1nrLAB6QM 4Rp7As4eiNZzLZtMKaAy6JSqdJvNWGshrqgVYeEi/ec6tZik+h4WOuvNgVxC+ozeRpeA8EYpJVd9V 9yRHHbqbFtwuEPB5zysAo+6Pc7L6j/I7GcnLB9SHYJlldnYU3QEgz6k97Exqr6fNgaZyUG5+WVuMc cwAQD7QQ==; Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljLOn-00FSLz-6s for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 12:34:07 +0000 Received: by mail-oi1-x22c.google.com with SMTP id s19so12939887oic.7 for ; Wed, 19 May 2021 05:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=VrjofVBqpi4EHgG9TcMkr4kH1OnwVdI3jKjQrhy1Fug=; b=WSbmTBjMuGsiyyywp5Dh3Q3mVYW2nbZQjg0K6XpN0ym7Jrl7a5IQuCF3IA3QXe4shk Ng8JJSYbNTWhKXk9LZm6Ks6Q4VkQ67uzl+BHacClNTEsfVOw/4DTeqzd/8NTDS2Xbk0Z ta+hXBtHynyG4MWZyKPg6/es2FymwlidZMkU7Z+7qGt2kU16NoC7yi0X/hKPBlybJxLS nW30UfL3+CWamV4v6eEu79DvmCx7vOijxZNl6iGcLa6U530GJ6DakL3VwL2DteDB0c9M xoJXf0W7rhuoTQrHKa1N7zPYAfPaMS9yiITcKYvZaU4xDeDvS0H6OHndrcIElujRWsT0 j8+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=VrjofVBqpi4EHgG9TcMkr4kH1OnwVdI3jKjQrhy1Fug=; b=VnG40T3+kqH+bEGfZUrG6KYrJiq5Ly6ZLTuRQZaLyGXpf0hToKVudqk0xBVlhDxkEd o3wlANEyqwcwKTLowy+PkSEguvbQfpThsxgr+zplxpPrETsLEhM50UIa98Qid45V8YHd 9AEFEA3KYDD0vKRFtJ5uf0FBTtORQNbr1FTsq1o8+a4T7UbWXRVHl19tc0deP2xkzwEo MBamv7j5XwC8h9aNJ45pNOlRuebRune1aWKsBxlJk0IGK8TfVY2PQI+NSPN5yPqO2AOK XPvZXlafSB17UrLiaGRegG7/KnZDUiqHjqiDhtfdxYgFpnlCoHyrDPzE5W0Luo2biK2E SlaA== X-Gm-Message-State: AOAM530ZQtHRIEijCX1kWtuIpPfmUR8SXqjkQ2jbccECKbNXZnBuMS5w 9WZeghDoU8xh3MaNh2qrJQ== X-Google-Smtp-Source: ABdhPJzF+Fy8did2QXIYwMFyj+Pr3q+myW/DhiifWrK0n5h2AtQhvpL+QDG4LfcQO07Tc5btOdZCGg== X-Received: by 2002:aca:b5c4:: with SMTP id e187mr8250914oif.149.1621427643980; Wed, 19 May 2021 05:34:03 -0700 (PDT) Received: from serve.minyard.net ([47.184.156.158]) by smtp.gmail.com with ESMTPSA id x78sm888530ooa.15.2021.05.19.05.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 05:34:03 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:9144:ba66:ea13:f260]) by serve.minyard.net (Postfix) with ESMTPSA id 93A3618000C; Wed, 19 May 2021 12:34:02 +0000 (UTC) Date: Wed, 19 May 2021 07:34:01 -0500 From: Corey Minyard To: Quan Nguyen Cc: Rob Herring , Joel Stanley , Andrew Jeffery , Brendan Higgins , Benjamin Herrenschmidt , Wolfram Sang , Philipp Zabel , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" , openbmc@lists.ozlabs.org Subject: Re: [PATCH v3 0/7] Add Aspeed SSIF BMC driver Message-ID: <20210519123401.GG2921206@minyard.net> References: <20210519074934.20712-1-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210519074934.20712-1-quan@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_053405_275170_61CC1373 X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 19, 2021 at 02:49:27PM +0700, Quan Nguyen wrote: > This series add support for the Aspeed specific SSIF BMC driver which > is to perform in-band IPMI communication with the host in management > (BMC) side. > > v3: > + Switched binding doc to use DT schema format [Rob] > + Splited into generic ssif_bmc and aspeed-specific [Corey, Joel] > + Removed redundant license info [Joel] > + Switched to use traditional if-else [Joel] > + Removed unused ssif_bmc_ioctl() [Joel] > + Made handle_request()/complete_response() to return void [Joel] > + Refactored send_ssif_bmc_response()/receive_ssif_bmc_request() [Corey] > + Remove mutex [Corey] > + Use spin_lock/unlock_irqsave/restore in callback [Corey] > + Removed the unnecessary memset [Corey] > + Switch to use dev_err() [Corey] > + Combine mask/unmask two interrupts together [Corey] > + Fixed unhandled Tx done with NAK [Quan] > + Late ack'ed Tx done w/wo Ack irq [Quan] > + Use aspeed-specific exported aspeed_set_slave_busy() when slave busy > to fix the deadlock [Graeme, Philipp, Quan] > + Clean buffer for last multipart read [Quan] > + Handle unknown incoming command [Quan] > > v2: > + Fixed compiling error with COMPILE_TEST for arc > > Quan Nguyen (7): > i2c: i2c-core-smbus: Expose PEC calculate function for generic use Note that for this I2C-specific change, I will need acks from the I2C maintainers to be able to include this in my tree. > ipmi: ssif_bmc: Add SSIF BMC driver > i2c: aspeed: Fix unhandled Tx done with NAK For the aspeed changes, they don't really belong here, they belong in the aspeed tree. I see that you need them for the device to work correctly, though. I'll need acks from maintainers to include them. > i2c: aspeed: Acknowledge Tx done w/wo ACK irq late > i2c: aspeed: Add aspeed_set_slave_busy() > ipmi: ssif_bmc: Add Aspeed SSIF BMC driver > bindings: ipmi: Add binding for Aspeed SSIF BMC driver > > .../bindings/ipmi/aspeed-ssif-bmc.yaml | 33 + > drivers/char/ipmi/Kconfig | 22 + > drivers/char/ipmi/Makefile | 2 + > drivers/char/ipmi/ssif_bmc.c | 605 ++++++++++++++++++ > drivers/char/ipmi/ssif_bmc.h | 93 +++ > drivers/char/ipmi/ssif_bmc_aspeed.c | 75 +++ > drivers/i2c/busses/i2c-aspeed.c | 51 +- > drivers/i2c/i2c-core-smbus.c | 12 +- > include/linux/i2c.h | 1 + > 9 files changed, 884 insertions(+), 10 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.yaml > create mode 100644 drivers/char/ipmi/ssif_bmc.c > create mode 100644 drivers/char/ipmi/ssif_bmc.h > create mode 100644 drivers/char/ipmi/ssif_bmc_aspeed.c > > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel