From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Bryan Brattlof <hello@bryanbrattlof.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove if (true) statement
Date: Wed, 19 May 2021 14:44:38 +0200 [thread overview]
Message-ID: <20210519124438.GA1417@agape.jhs> (raw)
In-Reply-To: <20210518144335.1677320-1-hello@bryanbrattlof.com>
Hi Bryan,
On Tue, May 18, 2021 at 02:45:19PM +0000, Bryan Brattlof wrote:
> 'if (true) { ... }' will always evaluate to true. Remove it and
> save a few tabs for somewhere else.
>
> Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 159 ++++++++++++------------
> 1 file changed, 78 insertions(+), 81 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 9df4476b2e2d..98b1bec67999 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -59,112 +59,109 @@ static void update_BCNTIM(struct adapter *padapter)
>
I was wondering why are you using the first patch of a nine patch
series as a 'cover letter' of an eight patch patchset.
In other words, why putting the In-Reply-To field of all patches subsequent
to the first one ponting to the first patch itself as a cover letter,
is it a recommened practice?
thank you,
fabio
next prev parent reply other threads:[~2021-05-19 12:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 14:45 [PATCH] staging: rtl8723bs: remove if (true) statement Bryan Brattlof
2021-05-19 12:44 ` Fabio Aiuto [this message]
2021-05-19 13:25 ` Dan Carpenter
2021-05-19 13:31 ` Dan Carpenter
2021-05-19 13:51 ` Bryan Brattlof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519124438.GA1417@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hello@bryanbrattlof.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.