Re: [PATCH 1/3] dt-bindings: clock: convert cs2000-cp bindings to yaml

[Rob Herring <robh@kernel.org>]

On Mon, May 17, 2021 at 02:29:24PM +0200, Daniel Mack wrote:
> The original author of the file was added as maintainer.
> 
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  .../bindings/clock/cirrus,cs2000-cp.yaml      | 64 +++++++++++++++++++
>  .../devicetree/bindings/clock/cs2000-cp.txt   | 22 -------
>  2 files changed, 64 insertions(+), 22 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/cirrus,cs2000-cp.yaml
>  delete mode 100644 Documentation/devicetree/bindings/clock/cs2000-cp.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/cirrus,cs2000-cp.yaml b/Documentation/devicetree/bindings/clock/cirrus,cs2000-cp.yaml
> new file mode 100644
> index 000000000000..3af81087e5f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/cirrus,cs2000-cp.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/cirrus,cs2000-cp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Binding CIRRUS LOGIC Fractional-N Clock Synthesizer & Clock Multiplier
> +
> +maintainers:
> +  - Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> +
> +description: |
> +  The CS2000-CP is an extremely versatile system clocking device that
> +  utilizes a programmable phase lock loop.
> +
> +  Link: https://www.cirrus.com/products/cs2000/
> +
> +properties:
> +  compatible:
> +    enum:
> +      - cirrus,cs2000-cp
> +
> +  clocks:
> +    description:
> +      Common clock binding for CLK_IN, XTI/REF_CLK
> +    minItems: 2
> +    maxItems: 2
> +
> +  clock-names:
> +    minItems: 2
> +    maxItems: 2

Need to define the names and order.

> +
> +  '#clock-cells':
> +    const: 0
> +
> +  reg:
> +    description:
> +      The chip select number on the I2C bus

Drop. That's 'reg' for every I2C device.

> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c@0 {
> +      reg = <0x0 0x100>;
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      cs2000: clk_multiplier@4f {

clock-controller@4f

And drop cs2000 as it is unused here.

> +        #clock-cells = <0>;
> +        compatible = "cirrus,cs2000-cp";
> +        reg = <0x4f>;
> +        clocks = <&rcar_sound 0>, <&x12_clk>;
> +        clock-names = "clk_in", "ref_clk";
> +      };
> +    };
> diff --git a/Documentation/devicetree/bindings/clock/cs2000-cp.txt b/Documentation/devicetree/bindings/clock/cs2000-cp.txt
> deleted file mode 100644
> index 54e6df0bee8a..000000000000
> --- a/Documentation/devicetree/bindings/clock/cs2000-cp.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -CIRRUS LOGIC Fractional-N Clock Synthesizer & Clock Multiplier
> -
> -Required properties:
> -
> -- compatible:		"cirrus,cs2000-cp"
> -- reg:			The chip select number on the I2C bus
> -- clocks:		common clock binding for CLK_IN, XTI/REF_CLK
> -- clock-names:		CLK_IN : clk_in, XTI/REF_CLK : ref_clk
> -- #clock-cells:		must be <0>
> -
> -Example:
> -
> -&i2c2 {
> -	...
> -	cs2000: clk_multiplier@4f {
> -		#clock-cells = <0>;
> -		compatible = "cirrus,cs2000-cp";
> -		reg = <0x4f>;
> -		clocks = <&rcar_sound 0>, <&x12_clk>;
> -		clock-names = "clk_in", "ref_clk";
> -	};
> -};
> -- 
> 2.31.1
>