All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/python3-six: add python3 variant
Date: Wed, 19 May 2021 23:08:33 +0200	[thread overview]
Message-ID: <20210519210833.GO2268078@scaer> (raw)
In-Reply-To: <1621458008892.46397@lab126.com>

Chan, All,

On 2021-05-19 21:00 +0000, Chan, Donald via buildroot spake thusly:
> On 2021-05-18 20:43 +0000, Chan, Donald spake thusly:
> > > On 2021-05-12 20:59 +0000, Chan, Donald via buildroot spake thusly:
> > > >> Signed-off-by: Donald Chan <hoiho@lab126.com>
> > > >Why do you need a python3-specific version of six?
> > > This was for the host side Python packages
> > Your patch was adding both the target and the host variants, though.
> Should I remove the $(eval $(python-package)) line then?

Yes. Just keep the host-python-package one.

> > If you can provide such an example that a specific host-python3-six
> > is needed, do not hesitate to resend your patch with such an explanation
> > in your commit log.
> Yes do let me explain - I am making some contributions to another OSS
> software (OP-TEE) that uses buildroot, and it requires a python3
> variant of the python-cryptography module, which in returns requires
> python3 variants of its dependencies (python-cffi, python-six,
> python-pycparser, python-pip). etc.

Ah, good explanations. Thanks. Please explain that in the commit log
when you resubmit (see below).

> Shall I re-submit everything in a new patch set (split to multiple patches)?

Yes, please. Having the new host-python3-six alone does not make much
sense. If it is followed in the same series by a patch that makes use of
it, then it becones obvious what it is for.

Thanks you for the follow-up with the explanations! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-05-19 21:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 20:59 [Buildroot] [PATCH 1/1] package/python3-six: add python3 variant Chan, Donald
2021-05-18 15:00 ` Yann E. MORIN
2021-05-18 20:43   ` Chan, Donald
2021-05-19 12:00     ` Yann E. MORIN
2021-05-19 21:00       ` Chan, Donald
2021-05-19 21:08         ` Yann E. MORIN [this message]
2021-05-20  1:50           ` Chan, Donald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519210833.GO2268078@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.