From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-usb@vger.kernel.org
Cc: Yehezkel Bernat <YehezkelShB@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Andreas Noever <andreas.noever@gmail.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH 1/4] thunderbolt: dma_port: Fix NVM read buffer bounds and offset issue
Date: Thu, 20 May 2021 11:54:24 +0300 [thread overview]
Message-ID: <20210520085424.GF291593@lahna.fi.intel.com> (raw)
In-Reply-To: <20210517115907.52503-2-mika.westerberg@linux.intel.com>
On Mon, May 17, 2021 at 02:59:04PM +0300, Mika Westerberg wrote:
> From: Mathias Nyman <mathias.nyman@linux.intel.com>
>
> Up to 64 bytes of data can be read from NVM in one go. Read address
> must be dword aligned. Data is read into a local buffer.
>
> If caller asks to read data starting at an unaligned address then full
> dword is anyway read from NVM into a local buffer. Data is then copied
> from the local buffer starting at the unaligned offset to the caller
> buffer.
>
> In cases where asked data length + unaligned offset is over 64 bytes
> we need to make sure we don't read past the 64 bytes in the local
> buffer when copying to caller buffer, and make sure that we don't
> skip copying unaligned offset bytes from local buffer anymore after
> the first round of 64 byte NVM data read.
>
> Fixes: 3e13676862f9 ("thunderbolt: Add support for DMA configuration based mailbox")
> Cc: stable@vger.kernel.org
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied to thunderbolt.git/fixes.
next prev parent reply other threads:[~2021-05-20 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 11:59 [PATCH 0/4] thunderbolt: NVM fixes and consolidation Mika Westerberg
2021-05-17 11:59 ` [PATCH 1/4] thunderbolt: dma_port: Fix NVM read buffer bounds and offset issue Mika Westerberg
2021-05-20 8:54 ` Mika Westerberg [this message]
2021-05-17 11:59 ` [PATCH 2/4] thunderbolt: usb4: " Mika Westerberg
2021-05-20 8:54 ` Mika Westerberg
2021-05-17 11:59 ` [PATCH 3/4] thunderbolt: Split NVM read/write generic functions out from usb4.c Mika Westerberg
2021-05-31 11:38 ` Mika Westerberg
2021-05-17 11:59 ` [PATCH 4/4] thunderbolt: Use generic tb_nvm_[read|write]_data() for Thunderbolt 2/3 devices Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520085424.GF291593@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mathias.nyman@linux.intel.com \
--cc=michael.jamet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.