From: Cornelia Huck <cohuck@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>,
Frederic Konrad <konrad@adacore.com>
Subject: Re: [PATCH] hw/virtio: Have virtio_bus_get_vdev_bad_features() return 64-bit value
Date: Thu, 20 May 2021 12:52:00 +0200 [thread overview]
Message-ID: <20210520125200.4eec8e25.cohuck@redhat.com> (raw)
In-Reply-To: <20210520102822.2471710-1-philmd@redhat.com>
On Thu, 20 May 2021 12:28:22 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> In commit 019a3edbb25 ("virtio: make features 64bit wide") we
> increased the 'features' field to 64-bit, but forgot to update
> the virtio_bus_get_vdev_bad_features() helper. The 'bad features'
> are truncated to 32-bit. The virtio_net_bad_features() handler
> from the virtio-net devices is potentially affected.
>
> Have the virtio_bus_get_vdev_bad_features() helper return the
> full 64-bit value.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 019a3edbb25 ("virtio: make features 64bit wide")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/hw/virtio/virtio-bus.h | 2 +-
> hw/virtio/virtio-bus.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2021-05-20 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 10:28 [PATCH] hw/virtio: Have virtio_bus_get_vdev_bad_features() return 64-bit value Philippe Mathieu-Daudé
2021-05-20 10:52 ` Cornelia Huck [this message]
2021-05-23 8:07 ` Michael S. Tsirkin
2021-05-24 18:21 ` Philippe Mathieu-Daudé
2021-05-24 20:36 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520125200.4eec8e25.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=konrad@adacore.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.