From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corey Minyard Date: Thu, 20 May 2021 08:33:33 -0500 Subject: [PATCH v3 00/16] ipmi: Allow raw access to KCS devices In-Reply-To: <5b549fee-63b1-4c05-a1d6-f6a13e235e1e@www.fastmail.com> References: <20210510054213.1610760-1-andrew@aj.id.au> <5b549fee-63b1-4c05-a1d6-f6a13e235e1e@www.fastmail.com> Message-ID: <20210520133333.GH2921206@minyard.net> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, May 20, 2021 at 04:21:31PM +0930, Andrew Jeffery wrote: > Hi Corey, > > On Mon, 10 May 2021, at 15:11, Andrew Jeffery wrote: > > Hello, > > > > This is the 3rd spin of the series refactoring the keyboard-controller-style > > device drivers in the IPMI subsystem. > > > > v2 can be found (in two parts because yay patch workflow mistakes) at: > > > > Cover letter: > > https://lore.kernel.org/linux-arm-kernel/20210319061952.145040-1-andrew at aj.id.au/ > > > > Patches: > > https://lore.kernel.org/linux-arm-kernel/20210319062752.145730-1-andrew at aj.id.au/ > > > > Several significant changes in v3: > > > > 1. The series is rebased onto v5.13-rc1 > > > > 2. v5.13-rc1 includes Chiawei's patches reworking the LPC devicetree bindings, > > so they're no-longer required in the series. > > > > 3. After some discussion with Arnd[1] and investigating the serio subsystem, > > I've replaced the "raw" KCS driver (patch 16/21 in v2) with a serio adaptor > > (patch 11/16 in this series). The adaptor allows us to take advantage of the > > existing chardevs provided by serio. > > > > [1] > > https://lore.kernel.org/linux-arm-kernel/37e75b07-a5c6-422f-84b3-54f2bea0b917 at www.fastmail.com/ > > > > Finally, I've also addressed Zev Weiss' review comments where I thought it was > > required. These comments covered a lot of minor issues across (almost) all the > > patches, so it's best to review from a clean slate rather than attempt to review > > the differences between spins. > > I backported this series for OpenBMC and posting those patches provoked > some feedback: > > * A bug identified in patch 9/18 for the Nuvoton driver where we enable > the OBE interrupt: > > https://lore.kernel.org/openbmc/HK2PR03MB4371F006185ADBBF812A5892AE509 at HK2PR03MB4371.apcprd03.prod.outlook.com/ > > * A discussion on patch 10/18 about lifting the single-open constraint > > https://lore.kernel.org/openbmc/CAPnigKku-EjOnV9gsmnXzH=XZxSU78iLeccNbsK8k2_4b4UwSg at mail.gmail.com/ > > I need to do a v4 to fix the bug in the Nuvoton driver. Did you have any > feedback for the remaining patches or thoughts on the discussions linked > above? I'd like to incorporate whatever I can into the series before > respinning. This will take a little while to review, but I'll try to get to it today. Thanks, -corey > > Cheers, > > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B771C433B4 for ; Thu, 20 May 2021 13:34:13 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDFD6610CB for ; Thu, 20 May 2021 13:34:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDFD6610CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Fm9gl2mq8z307D for ; Thu, 20 May 2021 23:34:11 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=oGzkT0Zm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::331; helo=mail-ot1-x331.google.com; envelope-from=tcminyard@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=oGzkT0Zm; dkim-atps=neutral Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Fm9g93Q02z2yxq; Thu, 20 May 2021 23:33:40 +1000 (AEST) Received: by mail-ot1-x331.google.com with SMTP id 69-20020a9d0a4b0000b02902ed42f141e1so14855511otg.2; Thu, 20 May 2021 06:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=ripHwk91l8LSQFM8vArK3vjCpqN/bvdKWF2j1HC8u6c=; b=oGzkT0ZmY2x/MysH0+yDGwQ6i3nB+q8OwVdNbavdjXd94rxmVyemCwy2Z8Mq5/yuYD B59b1TRGuVH5ecwvRHcA1WN1U5fGWRweQQAaB99PUHhma/s1ZVf0Tmi+dfpAYxZwfTKl cUKJ8eVJYIvNZzA+JlkbIGtvOzlkF3rR1JlTCtJ4rozr4qAcFWCJhb8nY3oNUZ7K1Zyi EZ3hnEbxPqR3Ki8O8A1JequprYOi+wj+bgEGVde5cnfNGC0Iuq9NLRRasKIjbLyN148C 8/4FftsY+2L/BPAUq3E3LHIA1ljBXhbvr1+3IESlDuRR2dBwfiHVwEB4msdvaqApqfFL SxiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=ripHwk91l8LSQFM8vArK3vjCpqN/bvdKWF2j1HC8u6c=; b=XDHju+Yk4nqTKWmOvANMg2sfKlh/B2Vumg9sc2yUi61y//r7X1PzPpaV3PCtYV/T+C 8pU4pFVcSQi3HFwxnM8vQYBAKsU8gExZV/dKTCQd/i531rWAZxeu1OHAr9eE3ZxVtePx qV340sPfqx3WuhHCDU0Uz23o/N8z90mZKLQalMMXvU3l8FC8az2E6YDTHBL5fADssBeU rgJQ9QkDW+qJEXOkTopGbkLFNYkW+/0Ys0a9keKso3XtHGXHG1W8Bw6BY6LZGxhUDFAQ wYg7Z9Yl8O2vE32FIzCdfeszZzdL/CRQK9wQuhMCEFo0dX7yWPYEJnT8vtmtaW3TACZf ppzQ== X-Gm-Message-State: AOAM533fHCCMNu0qmUIdugHzEAw4AqDg87mbSV4tTGZRitZywpeBhr7R NfgfS62t+SJfYtwHKXwcaA== X-Google-Smtp-Source: ABdhPJwfdwmkwhxDmYQejkca84wENbYKz2nnMhRT8WLsQz8j3ij+A7Lt8Pum8A1B1aE5/0U4a7HSuQ== X-Received: by 2002:a9d:855:: with SMTP id 79mr3754200oty.36.1621517616633; Thu, 20 May 2021 06:33:36 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id j16sm616665otn.55.2021.05.20.06.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 06:33:35 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:ecd2:e60e:d7a6:d643]) by serve.minyard.net (Postfix) with ESMTPSA id 7EFFC18000C; Thu, 20 May 2021 13:33:34 +0000 (UTC) Date: Thu, 20 May 2021 08:33:33 -0500 From: Corey Minyard To: Andrew Jeffery Subject: Re: [PATCH v3 00/16] ipmi: Allow raw access to KCS devices Message-ID: <20210520133333.GH2921206@minyard.net> References: <20210510054213.1610760-1-andrew@aj.id.au> <5b549fee-63b1-4c05-a1d6-f6a13e235e1e@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b549fee-63b1-4c05-a1d6-f6a13e235e1e@www.fastmail.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: devicetree@vger.kernel.org, Tomer Maimon , linux-aspeed@lists.ozlabs.org, Avi Fishman , Patrick Venture , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, Tali Perry , Rob Herring , Arnd Bergmann , openipmi-developer@lists.sourceforge.net, Zev Weiss , "Chia-Wei, Wang" , linux-arm-kernel@lists.infradead.org, Benjamin Fair Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, May 20, 2021 at 04:21:31PM +0930, Andrew Jeffery wrote: > Hi Corey, > > On Mon, 10 May 2021, at 15:11, Andrew Jeffery wrote: > > Hello, > > > > This is the 3rd spin of the series refactoring the keyboard-controller-style > > device drivers in the IPMI subsystem. > > > > v2 can be found (in two parts because yay patch workflow mistakes) at: > > > > Cover letter: > > https://lore.kernel.org/linux-arm-kernel/20210319061952.145040-1-andrew@aj.id.au/ > > > > Patches: > > https://lore.kernel.org/linux-arm-kernel/20210319062752.145730-1-andrew@aj.id.au/ > > > > Several significant changes in v3: > > > > 1. The series is rebased onto v5.13-rc1 > > > > 2. v5.13-rc1 includes Chiawei's patches reworking the LPC devicetree bindings, > > so they're no-longer required in the series. > > > > 3. After some discussion with Arnd[1] and investigating the serio subsystem, > > I've replaced the "raw" KCS driver (patch 16/21 in v2) with a serio adaptor > > (patch 11/16 in this series). The adaptor allows us to take advantage of the > > existing chardevs provided by serio. > > > > [1] > > https://lore.kernel.org/linux-arm-kernel/37e75b07-a5c6-422f-84b3-54f2bea0b917@www.fastmail.com/ > > > > Finally, I've also addressed Zev Weiss' review comments where I thought it was > > required. These comments covered a lot of minor issues across (almost) all the > > patches, so it's best to review from a clean slate rather than attempt to review > > the differences between spins. > > I backported this series for OpenBMC and posting those patches provoked > some feedback: > > * A bug identified in patch 9/18 for the Nuvoton driver where we enable > the OBE interrupt: > > https://lore.kernel.org/openbmc/HK2PR03MB4371F006185ADBBF812A5892AE509@HK2PR03MB4371.apcprd03.prod.outlook.com/ > > * A discussion on patch 10/18 about lifting the single-open constraint > > https://lore.kernel.org/openbmc/CAPnigKku-EjOnV9gsmnXzH=XZxSU78iLeccNbsK8k2_4b4UwSg@mail.gmail.com/ > > I need to do a v4 to fix the bug in the Nuvoton driver. Did you have any > feedback for the remaining patches or thoughts on the discussions linked > above? I'd like to incorporate whatever I can into the series before > respinning. This will take a little while to review, but I'll try to get to it today. Thanks, -corey > > Cheers, > > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E2C8C433B4 for ; Thu, 20 May 2021 13:35:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84D28610A2 for ; Thu, 20 May 2021 13:35:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84D28610A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kcLVx0EY0Zdf0UrxztcvnImBIviemm/7fobdc+REi2M=; b=HkP7splBt1zFryelpSwhlO4jhK yXjDCQ+hj+tx+fpwMg5CL+3hl1QBALh3IhqlPredAjbZriQoCdnVDirqcw/F+R/Y/Cxo0/vwEt6TA 9QDVSGpy91Qze7kuIcBcKMPwkNuWIi28e5wKtOq+y8SiAsyS+fBeFyXvpcB5amLbVkTXQ9rFtH+jl FLylsWtxqm8qggCjiS64MV4Aj9ShhqK2YjnWlzVtrMmIxOfIwt9VjcJqIl5hFBhcTIxx9elbI1yho FC/QYzAP/JznErwZX08eri/QqnJsQO+XZP+rkcAw+9xKjfOsW6L2fdZ5O34yt/fSS4OojihYTJUuo OVDrV4Yw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljio4-001DFw-Mj; Thu, 20 May 2021 13:33:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljio3-001DFc-9W for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 13:33:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ripHwk91l8LSQFM8vArK3vjCpqN/bvdKWF2j1HC8u6c=; b=wKeFGIq6pqNyz2cI6pqeqzavL2 nVssb72YCTXYrqNajf04TT5zr+ef0qSG0QIqiLwQ/VGaJmjcpaHozUb8hrbaNr9OiI2UiCFlnS96w C1ZxqeIvryUMzAy8+Gw28u9ZF1hslZKsUNUOlAPP2C85L0tREYctdNf5OIq7cTKKUl4l/v8QjTcFd 23IVuCCVcIL+cwPKq6bB64soq/RMp1JUwG7SJTds4sR/y3wHrPd7I+/gj1oCL810EfjroIFv9D6Dm RfXfXyNaE3j4z+9Xe+MM/DfsV7welrOcDdOYGni8XvooD2NehjMElgMLlmhSh8RmrRtZJKul9qVwN cOueZoDg==; Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljio0-00GNK9-Ac for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 13:33:42 +0000 Received: by mail-ot1-x331.google.com with SMTP id u25-20020a0568302319b02902ac3d54c25eso14890134ote.1 for ; Thu, 20 May 2021 06:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=ripHwk91l8LSQFM8vArK3vjCpqN/bvdKWF2j1HC8u6c=; b=oGzkT0ZmY2x/MysH0+yDGwQ6i3nB+q8OwVdNbavdjXd94rxmVyemCwy2Z8Mq5/yuYD B59b1TRGuVH5ecwvRHcA1WN1U5fGWRweQQAaB99PUHhma/s1ZVf0Tmi+dfpAYxZwfTKl cUKJ8eVJYIvNZzA+JlkbIGtvOzlkF3rR1JlTCtJ4rozr4qAcFWCJhb8nY3oNUZ7K1Zyi EZ3hnEbxPqR3Ki8O8A1JequprYOi+wj+bgEGVde5cnfNGC0Iuq9NLRRasKIjbLyN148C 8/4FftsY+2L/BPAUq3E3LHIA1ljBXhbvr1+3IESlDuRR2dBwfiHVwEB4msdvaqApqfFL SxiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=ripHwk91l8LSQFM8vArK3vjCpqN/bvdKWF2j1HC8u6c=; b=J2d04YKVnbG/HBXmSEcUot9Uy8sgd8Fvy7/oK2HkIIQVlxgPz8OfZ/6jFLjdlG3e8/ dar6dsIp2O/LyYmKCzgCw/BFXSVoQREj7uMNZuXRf+uNdYVBT62KM3KXjKlhF+gCTP5f rLbEB/gvGGE/cvyxHPb54RFCVUI7pnl7T5Kau1RoNbYFGUOMuRRlAtSMfmmev9TCpu6b +9sFNcBZ3Bo+sLNBrfa2n5QvqFTmG+1oyWp0jpBGEymhB2UzBOxvEJWdACjI8Z1DdGp+ Dtcv+97CnpuVZ+Xg+AOB8qhbNiLTK915opc8L7D0vQheM7hiqPyV8K6jrl5IcWDbF1AT jAOg== X-Gm-Message-State: AOAM530R2TXSnkEnvEiGUNK2ZuCYHUFJGSnecP/yDZnMw6eikOK+r2wH RkK46OUIXSokMEKK+QgXcg== X-Google-Smtp-Source: ABdhPJwfdwmkwhxDmYQejkca84wENbYKz2nnMhRT8WLsQz8j3ij+A7Lt8Pum8A1B1aE5/0U4a7HSuQ== X-Received: by 2002:a9d:855:: with SMTP id 79mr3754200oty.36.1621517616633; Thu, 20 May 2021 06:33:36 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id j16sm616665otn.55.2021.05.20.06.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 06:33:35 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:ecd2:e60e:d7a6:d643]) by serve.minyard.net (Postfix) with ESMTPSA id 7EFFC18000C; Thu, 20 May 2021 13:33:34 +0000 (UTC) Date: Thu, 20 May 2021 08:33:33 -0500 From: Corey Minyard To: Andrew Jeffery Cc: openipmi-developer@lists.sourceforge.net, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, Tomer Maimon , linux-aspeed@lists.ozlabs.org, Avi Fishman , Patrick Venture , linux-kernel@vger.kernel.org, Tali Perry , Rob Herring , "Chia-Wei, Wang" , linux-arm-kernel@lists.infradead.org, Benjamin Fair , Arnd Bergmann , Zev Weiss Subject: Re: [PATCH v3 00/16] ipmi: Allow raw access to KCS devices Message-ID: <20210520133333.GH2921206@minyard.net> References: <20210510054213.1610760-1-andrew@aj.id.au> <5b549fee-63b1-4c05-a1d6-f6a13e235e1e@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5b549fee-63b1-4c05-a1d6-f6a13e235e1e@www.fastmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_063340_411326_5A6862C7 X-CRM114-Status: GOOD ( 27.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 20, 2021 at 04:21:31PM +0930, Andrew Jeffery wrote: > Hi Corey, > > On Mon, 10 May 2021, at 15:11, Andrew Jeffery wrote: > > Hello, > > > > This is the 3rd spin of the series refactoring the keyboard-controller-style > > device drivers in the IPMI subsystem. > > > > v2 can be found (in two parts because yay patch workflow mistakes) at: > > > > Cover letter: > > https://lore.kernel.org/linux-arm-kernel/20210319061952.145040-1-andrew@aj.id.au/ > > > > Patches: > > https://lore.kernel.org/linux-arm-kernel/20210319062752.145730-1-andrew@aj.id.au/ > > > > Several significant changes in v3: > > > > 1. The series is rebased onto v5.13-rc1 > > > > 2. v5.13-rc1 includes Chiawei's patches reworking the LPC devicetree bindings, > > so they're no-longer required in the series. > > > > 3. After some discussion with Arnd[1] and investigating the serio subsystem, > > I've replaced the "raw" KCS driver (patch 16/21 in v2) with a serio adaptor > > (patch 11/16 in this series). The adaptor allows us to take advantage of the > > existing chardevs provided by serio. > > > > [1] > > https://lore.kernel.org/linux-arm-kernel/37e75b07-a5c6-422f-84b3-54f2bea0b917@www.fastmail.com/ > > > > Finally, I've also addressed Zev Weiss' review comments where I thought it was > > required. These comments covered a lot of minor issues across (almost) all the > > patches, so it's best to review from a clean slate rather than attempt to review > > the differences between spins. > > I backported this series for OpenBMC and posting those patches provoked > some feedback: > > * A bug identified in patch 9/18 for the Nuvoton driver where we enable > the OBE interrupt: > > https://lore.kernel.org/openbmc/HK2PR03MB4371F006185ADBBF812A5892AE509@HK2PR03MB4371.apcprd03.prod.outlook.com/ > > * A discussion on patch 10/18 about lifting the single-open constraint > > https://lore.kernel.org/openbmc/CAPnigKku-EjOnV9gsmnXzH=XZxSU78iLeccNbsK8k2_4b4UwSg@mail.gmail.com/ > > I need to do a v4 to fix the bug in the Nuvoton driver. Did you have any > feedback for the remaining patches or thoughts on the discussions linked > above? I'd like to incorporate whatever I can into the series before > respinning. This will take a little while to review, but I'll try to get to it today. Thanks, -corey > > Cheers, > > Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E46C433ED for ; Thu, 20 May 2021 13:33:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56916610A2 for ; Thu, 20 May 2021 13:33:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237866AbhETNfB (ORCPT ); Thu, 20 May 2021 09:35:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238616AbhETNe6 (ORCPT ); Thu, 20 May 2021 09:34:58 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99DF0C06175F; Thu, 20 May 2021 06:33:37 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id d3-20020a9d29030000b029027e8019067fso14808514otb.13; Thu, 20 May 2021 06:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=ripHwk91l8LSQFM8vArK3vjCpqN/bvdKWF2j1HC8u6c=; b=oGzkT0ZmY2x/MysH0+yDGwQ6i3nB+q8OwVdNbavdjXd94rxmVyemCwy2Z8Mq5/yuYD B59b1TRGuVH5ecwvRHcA1WN1U5fGWRweQQAaB99PUHhma/s1ZVf0Tmi+dfpAYxZwfTKl cUKJ8eVJYIvNZzA+JlkbIGtvOzlkF3rR1JlTCtJ4rozr4qAcFWCJhb8nY3oNUZ7K1Zyi EZ3hnEbxPqR3Ki8O8A1JequprYOi+wj+bgEGVde5cnfNGC0Iuq9NLRRasKIjbLyN148C 8/4FftsY+2L/BPAUq3E3LHIA1ljBXhbvr1+3IESlDuRR2dBwfiHVwEB4msdvaqApqfFL SxiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=ripHwk91l8LSQFM8vArK3vjCpqN/bvdKWF2j1HC8u6c=; b=Oa1Y3TOZ5wqAoJ+LdHvQWDLpQy2LnT119fN6StHpQo3eiOxUETlgd6yTOBaAhX0NSQ y+AOd46YxAQnqmjrTlwmfmAK/8rBL8qHIwh3NRDETberu9pwnLabasA/9fx2Gi9iNwrM lle/W6k5P9QZ8hDMUAQbi8InWujSJaEdkk33rkdxtq951vFFqrwiZ6Kom4pjNPDL8TtI D6EKbGHgpoJ9LWy/la3FkNRko8Hb7XuORm2RN62JvFhB71KYcjJy0sYlnr15eRB6iCxG F/PySYjTHdu1Pyu330zN0YG8XFPlXFFr2uZHid2itjL78RYDL8B3I3Yi7PRUnC9lse+K PYdg== X-Gm-Message-State: AOAM532LJjMbRUOhSV0ke/7bBtMwdf7CJ9bkc9PQ+Q2dOnJHqfugJ/Sp MLsjTP/sdsXSz95a7AKMuA== X-Google-Smtp-Source: ABdhPJwfdwmkwhxDmYQejkca84wENbYKz2nnMhRT8WLsQz8j3ij+A7Lt8Pum8A1B1aE5/0U4a7HSuQ== X-Received: by 2002:a9d:855:: with SMTP id 79mr3754200oty.36.1621517616633; Thu, 20 May 2021 06:33:36 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id j16sm616665otn.55.2021.05.20.06.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 06:33:35 -0700 (PDT) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:ecd2:e60e:d7a6:d643]) by serve.minyard.net (Postfix) with ESMTPSA id 7EFFC18000C; Thu, 20 May 2021 13:33:34 +0000 (UTC) Date: Thu, 20 May 2021 08:33:33 -0500 From: Corey Minyard To: Andrew Jeffery Cc: openipmi-developer@lists.sourceforge.net, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, Tomer Maimon , linux-aspeed@lists.ozlabs.org, Avi Fishman , Patrick Venture , linux-kernel@vger.kernel.org, Tali Perry , Rob Herring , "Chia-Wei, Wang" , linux-arm-kernel@lists.infradead.org, Benjamin Fair , Arnd Bergmann , Zev Weiss Subject: Re: [PATCH v3 00/16] ipmi: Allow raw access to KCS devices Message-ID: <20210520133333.GH2921206@minyard.net> Reply-To: minyard@acm.org References: <20210510054213.1610760-1-andrew@aj.id.au> <5b549fee-63b1-4c05-a1d6-f6a13e235e1e@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b549fee-63b1-4c05-a1d6-f6a13e235e1e@www.fastmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, May 20, 2021 at 04:21:31PM +0930, Andrew Jeffery wrote: > Hi Corey, > > On Mon, 10 May 2021, at 15:11, Andrew Jeffery wrote: > > Hello, > > > > This is the 3rd spin of the series refactoring the keyboard-controller-style > > device drivers in the IPMI subsystem. > > > > v2 can be found (in two parts because yay patch workflow mistakes) at: > > > > Cover letter: > > https://lore.kernel.org/linux-arm-kernel/20210319061952.145040-1-andrew@aj.id.au/ > > > > Patches: > > https://lore.kernel.org/linux-arm-kernel/20210319062752.145730-1-andrew@aj.id.au/ > > > > Several significant changes in v3: > > > > 1. The series is rebased onto v5.13-rc1 > > > > 2. v5.13-rc1 includes Chiawei's patches reworking the LPC devicetree bindings, > > so they're no-longer required in the series. > > > > 3. After some discussion with Arnd[1] and investigating the serio subsystem, > > I've replaced the "raw" KCS driver (patch 16/21 in v2) with a serio adaptor > > (patch 11/16 in this series). The adaptor allows us to take advantage of the > > existing chardevs provided by serio. > > > > [1] > > https://lore.kernel.org/linux-arm-kernel/37e75b07-a5c6-422f-84b3-54f2bea0b917@www.fastmail.com/ > > > > Finally, I've also addressed Zev Weiss' review comments where I thought it was > > required. These comments covered a lot of minor issues across (almost) all the > > patches, so it's best to review from a clean slate rather than attempt to review > > the differences between spins. > > I backported this series for OpenBMC and posting those patches provoked > some feedback: > > * A bug identified in patch 9/18 for the Nuvoton driver where we enable > the OBE interrupt: > > https://lore.kernel.org/openbmc/HK2PR03MB4371F006185ADBBF812A5892AE509@HK2PR03MB4371.apcprd03.prod.outlook.com/ > > * A discussion on patch 10/18 about lifting the single-open constraint > > https://lore.kernel.org/openbmc/CAPnigKku-EjOnV9gsmnXzH=XZxSU78iLeccNbsK8k2_4b4UwSg@mail.gmail.com/ > > I need to do a v4 to fix the bug in the Nuvoton driver. Did you have any > feedback for the remaining patches or thoughts on the discussions linked > above? I'd like to incorporate whatever I can into the series before > respinning. This will take a little while to review, but I'll try to get to it today. Thanks, -corey > > Cheers, > > Andrew