From: Lukas Wunner <lukas@wunner.de>
To: Saravana Kannan <saravanak@google.com>
Cc: Mark Brown <broonie@kernel.org>,
kernel-team@android.com, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2] spi: Don't have controller clean up spi device before driver unbind
Date: Fri, 21 May 2021 07:09:46 +0200 [thread overview]
Message-ID: <20210521050946.GA26930@wunner.de> (raw)
In-Reply-To: <20210505164734.175546-1-saravanak@google.com>
On Wed, May 05, 2021 at 09:47:34AM -0700, Saravana Kannan wrote:
> When a spi device is unregistered and triggers a driver unbind, the
> driver might need to access the spi device. So, don't have the
> controller clean up the spi device before the driver is unbound. Clean
> up the spi device after the driver is unbound.
>
> Fixes: c7299fea6769 ("spi: Fix spi device unregister flow")
> Reported-by: Lukas Wunner <lukas@wunner.de>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
>
> v1->v2:
> - Made the clean up more symmetric.
>
> Lukas,
>
> Can you test this one your end to make sure you don't have issues
> anymore?
Tested-by: Lukas Wunner <lukas@wunner.de>
My apologies for the delay, yesterday I was finally able to set up a RasPi
in my home office and test the patch. I'm not seeing any issues when
unloading/reloading the SPI controller module, so this LGTM.
Thanks,
Lukas
prev parent reply other threads:[~2021-05-21 5:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 16:47 [PATCH v2] spi: Don't have controller clean up spi device before driver unbind Saravana Kannan
2021-05-05 17:53 ` Andy Shevchenko
2021-05-11 15:57 ` Mark Brown
2021-05-11 20:30 ` Andy Shevchenko
2021-05-14 15:22 ` Mark Brown
2021-05-21 5:09 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521050946.GA26930@wunner.de \
--to=lukas@wunner.de \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.